hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jaehong choi (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HBASE-1548) give a time range in MapReduce
Date Tue, 23 Jun 2009 02:02:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722929#action_12722929
] 

jaehong choi edited comment on HBASE-1548 at 6/22/09 7:01 PM:
--------------------------------------------------------------

Thank you for comments.

1. As far as I'm concerned, if you don't specify Scan's versions, it will be 1. So, even if
we give a time range, scanner will only return 1 cell. This is not what we want.

2. There is no unit test to verify IOE. But, if we give a time range whose min value is greater
than max, the existing unit test will be failed. I think this code should be changed in order
to check null values of minArg, maxArg in TableInputFormat.configure() rather than using 0s
to indicate that there is no time range. Because 0 is itself a kind of time range value, but
not absence of time range like null.

3. I didn't know HBASE-1385. I think this issue can be merged into HBASE-1385. 

      was (Author: jaehong choi):
    Thank you for comments.

1. As far as I'm concerned, if you don't specify Scan's versions, it will be 1. So, even if
we give a time range, scanner will only return 1 cell. This is not what we want.

2. There is no unit test to verify IOE. But, if we give a time range whose min value is greater
than max, the existing unit test will be failed. I think this code should be changed in order
to check null values of minArg, maxArg in TableInputFormat.configure() rather than using 0s
to indicate that there is no time range. Because 0 is itself a kind of time range value, but
not absence of time range like null.

3. I didn't know HBase-1385. I think this issue can be merged into HBase-1385. 
  
> give a time range in MapReduce
> ------------------------------
>
>                 Key: HBASE-1548
>                 URL: https://issues.apache.org/jira/browse/HBASE-1548
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: jaehong choi
>         Attachments: HBase-1548.patch
>
>
> I've seen a lot of changes in client APIs by HBASE-1304 patch.
> We can give a time range when we scan a table with assign TimeRange instance to Scan
class.
> I also see some code in org.apache.hadoop.hbase.mapreduce.TableInputForamtBase.java,
which uses a scan instance to get a Scanner instance.
> I think we can also give a time range to query when we do mapreduce on hbase. 
> I've already apply this one to my local copy for my purpose, which is about time series
analysis.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message