hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1385) Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit where we can make < maps than regions
Date Tue, 30 Jun 2009 00:13:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725402#action_12725402
] 

stack commented on HBASE-1385:
------------------------------

Should GroupingTableMap become GroupingTableMapper to match?

The configuration keys should be mapreduce rather than mapred as in "hbase.mapred.inputtable"
should be "hbase.mapreduce.inputtable"

I'm not sure how to pass filters via Configuration other than to name the filter and then
pass String arguments as in:

hbase.mapreduce.filter.name
hbase.mapreduce.filter.arg0
...

In TIF, you'd do get on Configuration till no more args and then use reflection to make an
instance.

We can do that in a different issue I'd say.

I like doing TIF spec. using Scan.  Its definetly way to go.

Should this be a convenience method on Scan?

{code}
+      byte[][] famQual = KeyValue.parseColumn(col);
+      if (famQual[1].length > 0) {
+        scan.addColumn(famQual[0], famQual[1]);
+      } else {
+        scan.addFamily(famQual[0]);
+      }
{code}

It happens a few times in this patch and I've needed it myself elsewhere.

Patch looks great.

> Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit where we
can make < maps than regions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1385
>                 URL: https://issues.apache.org/jira/browse/HBASE-1385
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.21.0
>
>         Attachments: 1385-v4.patch, 1385-v5.patch, 1385-v6.patch, 1385.patch, mr.patch
>
>
> Update TIF to match new MR.
> Remove the bit of logic where we will use number of configured maps as splits count rather
than regions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message