hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1507) iCMS as default JVM
Date Sun, 14 Jun 2009 20:33:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719329#action_12719329
] 

stack commented on HBASE-1507:
------------------------------

First, yes, my original commit was bad.  Sorry about that.

Rather than Ryan's patch where the default is set in hbase-conf.env, rather why not follow
convention where we set a default if environment variable is empty:

{code}
Index: bin/hbase
===================================================================
--- bin/hbase	(revision 784502)
+++ bin/hbase	(working copy)
@@ -206,7 +206,9 @@
 # and are named like the following: java_pid21612.hprof. Apparently it doesn't
 # 'cost' to have this flag enabled. Its a 1.6 flag only. See:
 # http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+if [ "$HBASE_OPTS" = "" ]; then
+  HBASE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+fi
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
{code}

> iCMS as default JVM
> -------------------
>
>                 Key: HBASE-1507
>                 URL: https://issues.apache.org/jira/browse/HBASE-1507
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message