hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryan rawson (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HBASE-1522) We delete splits before their time occasionally
Date Mon, 15 Jun 2009 05:44:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719402#action_12719402
] 

ryan rawson edited comment on HBASE-1522 at 6/14/09 10:42 PM:
--------------------------------------------------------------

here is a fix:

{noformat}
diff --git a/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java b/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
index 5da31c7..8f0f0e8 100644
--- a/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
+++ b/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
@@ -208,7 +208,7 @@ class CompactSplitThread extends Thread implements HConstants {
     put.add(CATALOG_FAMILY, SPLITA_QUALIFIER,
         Writables.getBytes(newRegions[0].getRegionInfo()));
     put.add(CATALOG_FAMILY, SPLITB_QUALIFIER,
-        Writables.getBytes(newRegions[0].getRegionInfo()));
+        Writables.getBytes(newRegions[1].getRegionInfo()));
     t.put(put);
     
     // Add new regions to META
{noformat}

      was (Author: ryanobjc):
    here is a fix:

diff --git a/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java b/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
index 5da31c7..8f0f0e8 100644
--- a/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
+++ b/src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
@@ -208,7 +208,7 @@ class CompactSplitThread extends Thread implements HConstants {
     put.add(CATALOG_FAMILY, SPLITA_QUALIFIER,
         Writables.getBytes(newRegions[0].getRegionInfo()));
     put.add(CATALOG_FAMILY, SPLITB_QUALIFIER,
-        Writables.getBytes(newRegions[0].getRegionInfo()));
+        Writables.getBytes(newRegions[1].getRegionInfo()));
     t.put(put);
     
     // Add new regions to META

  
> We delete splits before their time occasionally
> -----------------------------------------------
>
>                 Key: HBASE-1522
>                 URL: https://issues.apache.org/jira/browse/HBASE-1522
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>            Priority: Blocker
>             Fix For: 0.20.0
>
>
> the master logfile says:
> 2009-06-13 01:47:50,993 DEBUG org.apache.hadoop.hbase.master.BaseScanner: Looking for
reference files in: hdfs://borg13:9000/hbase-1304/table/582659871/default2009-06-13 01:47:50,994
DEBUG org.apache.hadoop.hbase.master.BaseScanner: isReference: hdfs://borg13:9000/hbase-1304/table/582659871/default/7693630986938671024
> 2009-06-13 01:47:50,995 DEBUG org.apache.hadoop.hbase.master.BaseScanner: table,,1244880487129/582659871
no longer has references to table,,1244877673805
> 2009-06-13 01:47:51,007 DEBUG org.apache.hadoop.hbase.master.BaseScanner: Looking for
reference files in: hdfs://borg13:9000/hbase-1304/table/582659871/default2009-06-13 01:47:51,007
DEBUG org.apache.hadoop.hbase.master.BaseScanner: isReference: hdfs://borg13:9000/hbase-1304/table/582659871/default/7693630986938671024
> 2009-06-13 01:47:51,008 DEBUG org.apache.hadoop.hbase.master.BaseScanner: table,,1244880487129/582659871
no longer has references to table,,12448776738
> 052009-06-13 01:47:51,009 INFO org.apache.hadoop.hbase.master.BaseScanner: Deleting region
table,,1244877673805 (encoded=1481906432) because daughter splits no longe
> r hold references2009-06-13 01:47:51,009 DEBUG org.apache.hadoop.hbase.regionserver.HRegion:
DELETING region hdfs://borg13:9000/hbase-1304/table/1481906432
> As you can see, apparently splitA and splitB point to the same region!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message