hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1561) HTable Mismatch between javadoc and what it actually does
Date Mon, 22 Jun 2009 16:48:07 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Gray updated HBASE-1561:
---------------------------------

    Attachment: HBASE-1561-v2.patch

Adds more explicit documentation in Delete javadoc.  Timestamp set in constructor is only
for a delete row, you have to specify individually if you do explicit families/columns.

Also updates old api in HTable to use new api properly.  Adds javadoc to Delete.deleteColumns
and adds timestamp to it.

I also copied over a private method stripColon() from HCD so that the old api is indifferent
as to whether it is passed "family:" or "family".  As it is before this patch, old code would
be sending family: but our new API expects it without that.

> HTable Mismatch between javadoc and what it actually does
> ---------------------------------------------------------
>
>                 Key: HBASE-1561
>                 URL: https://issues.apache.org/jira/browse/HBASE-1561
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1561-v2.patch, HBASE-1561.patch
>
>
> The code is:
>   /** 
>    * Delete all cells that match the passed row and column and whose
>    * timestamp is equal-to or older than the passed timestamp, using an
>    * existing row lock.
>    * @param row Row to update
>    * @param column name of column whose value is to be deleted
>    * @param ts Delete all cells of the same timestamp or older.
>    * @param rl Existing row lock
>    * @throws IOException 
>    * @deprecated As of hbase 0.20.0, replaced by {@link #delete(Delete)}
>    */
>   public void deleteAll(final byte [] row, final byte [] column, final long ts,
>       final RowLock rl)
>   throws IOException {
>     Delete d = new Delete(row, ts, rl);
>     d.deleteColumn(column);
>     delete(d);
>   }
> The code should call deleteColumns() instead.
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message