hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1385) Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit where we can make < maps than regions
Date Sat, 27 Jun 2009 23:54:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724908#action_12724908
] 

stack commented on HBASE-1385:
------------------------------

.bq I added "abstract" because Reducer is too - but does not have any abstract function calls,
so I could leave it out. But I assume that we also want to force people to extend this class
(or use IndentyTableReduce). Right?

I agree w/ above -- that folks now need to extend TableReducer (not IdentityTableReducer --
let that stand as an example/default).  Yeah, its unfortunate we can't get away with TM and
TR being Interfaces but the underlying MR API changed so no way around it.

I like the new KEYIN, VALUEIN namings.

We don't need to add specific types as inputs as you suggest.  I like your improvement leaving
them generic.

+1 on removing weirdo 'm_'.

+1 on renaming classes from TableMap to TableMapper and TableReduce to TableReducer; Mapper
and Reducer are parent names so makes more sense.

Looking at patch now.



> Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit where we
can make < maps than regions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1385
>                 URL: https://issues.apache.org/jira/browse/HBASE-1385
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.21.0
>
>         Attachments: 1385-v2.patch, 1385.patch, mr.patch
>
>
> Update TIF to match new MR.
> Remove the bit of logic where we will use number of configured maps as splits count rather
than regions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message