Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 88308 invoked from network); 14 May 2009 02:07:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 May 2009 02:07:07 -0000 Received: (qmail 7951 invoked by uid 500); 14 May 2009 02:07:07 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 7907 invoked by uid 500); 14 May 2009 02:07:07 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 7897 invoked by uid 99); 14 May 2009 02:07:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2009 02:07:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2009 02:07:05 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8B0F4234C004 for ; Wed, 13 May 2009 19:06:45 -0700 (PDT) Message-ID: <1186422729.1242266805554.JavaMail.jira@brutus> Date: Wed, 13 May 2009 19:06:45 -0700 (PDT) From: "Evgeny Ryabitskiy (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Updated: (HBASE-1422) Refactor to Server Manager In-Reply-To: <986408009.1242266685532.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Ryabitskiy updated HBASE-1422: ------------------------------------- Attachment: HBASE-1422.patch > Refactor to Server Manager > -------------------------- > > Key: HBASE-1422 > URL: https://issues.apache.org/jira/browse/HBASE-1422 > Project: Hadoop HBase > Issue Type: Sub-task > Affects Versions: 0.19.2 > Reporter: Evgeny Ryabitskiy > Assignee: Evgeny Ryabitskiy > Priority: Blocker > Fix For: 0.20.0 > > Attachments: HBASE-1422.patch > > > This is refactor to Server Manager class from HBASE-1017 > I separate it for reasons: > * Its better to have several small patchs and apply them iterativly then one great path > * I fu..** tired from synchronising w/ SVN (this class changes frequently), you can saw 10 patches in HBASE-1017 > > We need this refactoing for reasons: > * Server Manager looks like shi**.. bad thing... > * is every time harder to make any chnages > * it is becoming more ugly every time........ > What changes are done: > ServerManager has mapping: > * serverName 2 serverInfo, > * serverAddr 2 serverInfo, > * serverName 2 load, > * load 2 severName > 1) serverName 2 load - not necessary if you have serverName 2 serverInfo > 2) All mappings are encapsulated in ServersInfo class (inner class of ServerManager) > 3) ServersInfo has operations for adding, updating and removing information of HRS > + some code in RegionServer is puted in synchronised block... cause it is working with synchronised map... > Note: this task is to make code much much more clear.. and it's not going to change logic, so no much problem is going appear -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.