hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1405) Threads.shutdown has unnecessary branch
Date Mon, 11 May 2009 19:49:45 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-1405:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks for patch Nitay.

> Threads.shutdown has unnecessary branch
> ---------------------------------------
>
>                 Key: HBASE-1405
>                 URL: https://issues.apache.org/jira/browse/HBASE-1405
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: hbase-1405.patch
>
>
> {code}
>         if (joinwait == -1) {
>           t.join();
>         } else {
>           t.join(joinwait);
>         }
> {code}
> We don't need to use -1 as a special value, as join already has a special value of 0:
> From Thread.join() javadoc:
> "Waits at most millis milliseconds for this thread to die. A timeout of 0 means to wait
forever."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message