hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1367) get rid of thrift exception 'NotFound'
Date Tue, 05 May 2009 03:32:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705881#action_12705881

stack commented on HBASE-1367:


Below could be size of the in array rather than 1

+    List<TCell> list = new ArrayList<TCell>(1); 

Otherwise, patch looks good to me Andrew.

FYI, Kevin just branched thrift: http://svn.apache.org/viewvc/incubator/thrift/branches/0.1.x/
 if you want to add that instead (Not important -- shouldn't hold up commit.  Just FYI)

Discussion provoked by patch:

On the convertions from Cell and Cell [] to Lists of TCells, I suppose there is no way to
avoid this, even in the new stuff where we have lists of KeyValue (though KeyValue is nothing
but a byte [] really).  If we could have KeyValue subclass "byte []" then we could pass the
list of KeyValues to thrift -- but its not possible subclassing byte [].  I suppose no way
to have thrift use KeyValue lists directly -- treat them as containers of byte []?

> get rid of thrift exception 'NotFound'
> --------------------------------------
>                 Key: HBASE-1367
>                 URL: https://issues.apache.org/jira/browse/HBASE-1367
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: ryan rawson
>            Assignee: Andrew Purtell
>             Fix For: 0.20.0
>         Attachments: hbase-1367-1.patch.gz
> as per the discussion in HBASE-794, the use of exceptions is not good, since some clients
may disconnect.
> Return a structure like:
> { boolean: found, RowResult: result }
> where 'result' is optional if found is false.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message