hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1422) Refactor to Server Manager
Date Fri, 15 May 2009 04:21:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709696#action_12709696
] 

stack commented on HBASE-1422:
------------------------------

@Evgeny

I do not think this a blocker for 0.20.0.  As is it works.  0.20.0 is already late and overloaded
with issues.  We don't need to add more if we can avoid it. This refactor, while it'd be nice
since as you say ServerManager is a mess, seems low priority but high risk since its something
that can't be messed up since this class orchestrates servers in the cluster.

> Refactor to Server Manager
> --------------------------
>
>                 Key: HBASE-1422
>                 URL: https://issues.apache.org/jira/browse/HBASE-1422
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.19.2
>            Reporter: Evgeny Ryabitskiy
>            Assignee: Evgeny Ryabitskiy
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1422.patch, HBASE-1422_v2.patch, HBASE-1422_v3.patch
>
>
> This is refactor to Server Manager class from  HBASE-1017
> I separate it for reasons:
>  * Its better to have several small patchs and apply them iterativly then one great path
>  * I fu..**  tired from synchronising w/ SVN  (this class changes frequently), you can
saw 10 patches in HBASE-1017
>  
> We need this refactoing for reasons:
>  *  Server Manager looks like shi**.. bad thing...
>  * is every time harder to make any chnages
>  * it is becoming more ugly every time........
> What changes are done:
> ServerManager has mapping:
>     * serverName 2 serverInfo,
>     * serverAddr 2 serverInfo,
>     * serverName 2 load,
>     * load 2 severName
> 1) serverName 2 load - not necessary if you have serverName 2 serverInfo
> 2) All mappings are encapsulated in ServersInfo class (inner class of ServerManager)
> 3) ServersInfo has operations for adding, updating and removing information of HRS
> + some code in RegionServer is puted in synchronised block... cause it is working with
synchronised map...
> Note: this task is to make code much much more clear.. and it's not going to change logic,
so no much problem is going appear

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message