hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rong-En Fan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1292) php thrift's getRow() would throw an exception if the row does not exist
Date Sun, 05 Apr 2009 04:47:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695808#action_12695808
] 

Rong-En Fan commented on HBASE-1292:
------------------------------------

>From thrift mailing:

http://mail-archives.apache.org/mod_mbox/incubator-thrift-user/200806.mbox/%3C7e536b1f0806080534h183efef4t3f636c6101f6bb1b@mail.gmail.com%3E

It seems that thrift currently against using null as it may not be a native thing in some
languages.

Moreover, in our thrift definition, we already uses NotFound as a signal for no value for
a query and is used in methods like get() and scanner. So I think the best thing for now is
to use NotFound to signal the caller.

> php thrift's getRow() would throw an exception if the row does not exist
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1292
>                 URL: https://issues.apache.org/jira/browse/HBASE-1292
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.19.0, 0.19.1
>            Reporter: Rong-En Fan
>            Assignee: Rong-En Fan
>            Priority: Minor
>         Attachments: 1292-0.19.patch, 1292.patch
>
>
> I've been played with thrift recently, and observed an unexpected behavior: when getRow()
encounters an non-existent row key, it throws an exception like this:
> PHP Fatal error:  Uncaught exception 'Exception' with message 'getRow failed: unknown
result' in pear/thrift/packages/Hbase/Hbase.php:715
> Stack trace:
> #0 pear/thrift/packages/Hbase/Hbase.php(666): HbaseClient->recv_getRow()
> #1 htdocs/hbase/DemoClient.php(174): HbaseClient->getRow('demo_table', '00100-XXXX')
> #2 {main} thrown in pear/thrift/packages/Hbase/Hbase.php on line 715
> I would expect when we pass a non-existent key, it can throw something like NotFound
(as in scanner) or one can test with RowResult.isEmpty() just like in java api.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message