Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <752938775.1236876170476.JavaMail.jira@brutus>
Date: Thu, 12 Mar 2009 09:42:50 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-1258) ganglia metrics for 'requests' is
 confusing
In-Reply-To: <942226163.1236817192754.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681386#action_12681386 ] 

stack commented on HBASE-1258:
------------------------------

I applied to a clean trunk and when I tried to build I got this:

{code}
jspc:
     [echo] Setting jspc.notRequired property. jsp pages generated once per ant session only

compile:
    [javac] Compiling 285 source files to /Users/stack/checkouts/hbase/trunk.clean/build/classes
    [javac] /Users/stack/checkouts/hbase/trunk.clean/src/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java:107: cannot find symbol
    [javac] symbol  : variable atomicIncrementTime
    [javac] location: class org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
    [javac]       this.atomicIncrementTime.pushMetric(this.metricsRecord);
    [javac]           ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
{code}

You might also check out src/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java.  It has a toString method that summarizes regionserver metrics when called that is displayed in the regionserver UI.  Does it include your metrics naming changes?

Good on you Ryan.

> ganglia metrics for 'requests' is confusing
> -------------------------------------------
>
>                 Key: HBASE-1258
>                 URL: https://issues.apache.org/jira/browse/HBASE-1258
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.19.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.19.1, 0.20.0
>
>         Attachments: HBASE-1258-1259.patch
>
>
> the 'requests' metric is incremented for every request, but it is reset and published every interval.  Which means the number is actually 'requests per interval' which is a config value in hbase.  
> HBase should export 'requests/second' instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.