Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 30411 invoked from network); 20 Mar 2009 08:43:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Mar 2009 08:43:13 -0000 Received: (qmail 33482 invoked by uid 500); 20 Mar 2009 08:43:12 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 33456 invoked by uid 500); 20 Mar 2009 08:43:11 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 33443 invoked by uid 99); 20 Mar 2009 08:43:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2009 01:43:11 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Mar 2009 08:43:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D87FF234C003 for ; Fri, 20 Mar 2009 01:42:50 -0700 (PDT) Message-ID: <632239690.1237538570872.JavaMail.jira@brutus> Date: Fri, 20 Mar 2009 01:42:50 -0700 (PDT) From: "Nitay Joffe (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Issue Comment Edited: (HBASE-1274) TestMergeTable is broken in Hudson In-Reply-To: <1564254412.1237538330552.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683795#action_12683795 ] Nitay Joffe edited comment on HBASE-1274 at 3/20/09 1:41 AM: ------------------------------------------------------------- I know what caused this, it's this part of r755878: {code} diff --git src/java/org/apache/hadoop/hbase/HMerge.java src/java/org/apache/hadoop/hbase/HMerge.java index af0bc89..361d1d3 100644 --- src/java/org/apache/hadoop/hbase/HMerge.java +++ src/java/org/apache/hadoop/hbase/HMerge.java @@ -110,7 +110,7 @@ class HMerge implements HConstants { this.tabledir = new Path( fs.makeQualified(new Path(conf.get(HBASE_DIR))), - tableName.toString() + Bytes.toString(tableName) ); Path logdir = new Path(tabledir, "merge_" + System.currentTimeMillis() + HREGION_LOGDIR_NAME); {code} If I undo this the test passes. Stack and I thought that change was innocuous and only helpful (because calling toString on an tableName, which is an array, yields garbage). Turns out some logic in the test/code actually depends on it. Will dig deeper to find out why. was (Author: nitay): I know what caused this, it's this part of r755878: diff --git src/java/org/apache/hadoop/hbase/HMerge.java src/java/org/apache/hadoop/hbase/HMerge.java index af0bc89..361d1d3 100644 --- src/java/org/apache/hadoop/hbase/HMerge.java +++ src/java/org/apache/hadoop/hbase/HMerge.java @@ -110,7 +110,7 @@ class HMerge implements HConstants { this.tabledir = new Path( fs.makeQualified(new Path(conf.get(HBASE_DIR))), - tableName.toString() + Bytes.toString(tableName) ); Path logdir = new Path(tabledir, "merge_" + System.currentTimeMillis() + HREGION_LOGDIR_NAME); If I undo this the test passes. Stack and I thought that change was innocuous and only helpful (because calling toString on an tableName, which is an array, yields garbage). Turns out some logic in the test/code actually depends on it. Will dig deeper to find out why. > TestMergeTable is broken in Hudson > ---------------------------------- > > Key: HBASE-1274 > URL: https://issues.apache.org/jira/browse/HBASE-1274 > Project: Hadoop HBase > Issue Type: Bug > Components: test > Reporter: Nitay Joffe > Assignee: Nitay Joffe > Priority: Minor > Fix For: 0.20.0 > > > http://hudson.zones.apache.org/hudson/job/HBase-Patch/539/testReport/org.apache.hadoop.hbase/TestMergeTable/testMergeTable/ > java.io.IOException: Files have same sequenceid > at org.apache.hadoop.hbase.regionserver.HRegion.merge(HRegion.java:2500) > at org.apache.hadoop.hbase.regionserver.HRegion.mergeAdjacent(HRegion.java:2412) > at org.apache.hadoop.hbase.HMerge$Merger.merge(HMerge.java:167) > at org.apache.hadoop.hbase.HMerge$Merger.process(HMerge.java:126) > at org.apache.hadoop.hbase.HMerge.merge(HMerge.java:91) > at org.apache.hadoop.hbase.TestMergeTable.testMergeTable(TestMergeTable.java:35) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.