Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <2107916150.1236791450728.JavaMail.jira@brutus>
Date: Wed, 11 Mar 2009 10:10:50 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1256) NPE in StoreFileScanner durring cache
 flush
In-Reply-To: <1367638994.1236787370703.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1256:
-------------------------

    Fix Version/s: 0.19.1

Pulling into 0.19.1

I think I see the issue.  It looks like it was introduced by 1219/1220.  Here is the fix I think:

{code}
Index: src/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (revision 752526)
+++ src/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (working copy)
@@ -93,7 +93,7 @@
       } else {
         // Only add in non-null Readers
         int nonulls = 0;
-        for (int i = 1; i < this.readers.length; i++) {
+        for (int i = 0; i < this.readers.length; i++) {
           if (this.readers[i] != null) nonulls++;
         }
         MapFile.Reader [] newReaders = new MapFile.Reader[nonulls + 1];
{code}

Let me run some tests.

> NPE in StoreFileScanner durring cache flush
> -------------------------------------------
>
>                 Key: HBASE-1256
>                 URL: https://issues.apache.org/jira/browse/HBASE-1256
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.19.0
>         Environment: latest branch of 0.19 with some unrelated transactional fixes.
> Master, regionserver, and client all in the same JVM
>            Reporter: Clint Morgan
>             Fix For: 0.19.1
>
>
> About an hour into a bulk upload I'm consistently getting:
> org.apache.hadoop.hbase.DroppedSnapshotException: region: net_troove_coin_transaction_Transaction,,1236293201543
> 	at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:902)
> 	at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:795)
> 	at org.apache.hadoop.hbase.regionserver.MemcacheFlusher.flushRegion(MemcacheFlusher.java:228)
> 	at org.apache.hadoop.hbase.regionserver.MemcacheFlusher.run(MemcacheFlusher.java:138)
> Caused by: java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.regionserver.StoreFileScanner.findFirstRow(StoreFileScanner.java:314)
> 	at org.apache.hadoop.hbase.regionserver.StoreFileScanner.advance(StoreFileScanner.java:141)
> 	at org.apache.hadoop.hbase.regionserver.StoreFileScanner.openReaders(StoreFileScanner.java:109)
> 	at org.apache.hadoop.hbase.regionserver.StoreFileScanner.updateReaders(StoreFileScanner.java:413)
> 	at org.apache.hadoop.hbase.regionserver.HStoreScanner.updateReaders(HStoreScanner.java:346)
> 	at org.apache.hadoop.hbase.regionserver.HStore.notifyChangedReadersObservers(HStore.java:746)
> 	at org.apache.hadoop.hbase.regionserver.HStore.updateReaders(HStore.java:731)
> 	at org.apache.hadoop.hbase.regionserver.HStore.internalFlushCache(HStore.java:700)
> 	at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:636)
> 	at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:887)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.