Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 8131 invoked from network); 10 Mar 2009 23:33:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Mar 2009 23:33:14 -0000 Received: (qmail 24352 invoked by uid 500); 10 Mar 2009 23:33:13 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 24290 invoked by uid 500); 10 Mar 2009 23:33:13 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 24255 invoked by uid 99); 10 Mar 2009 23:33:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2009 16:33:13 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2009 23:33:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6A572234C003 for ; Tue, 10 Mar 2009 16:32:50 -0700 (PDT) Message-ID: <1272097799.1236727970421.JavaMail.jira@brutus> Date: Tue, 10 Mar 2009 16:32:50 -0700 (PDT) From: "Evgeny Ryabitskiy (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Commented: (HBASE-1253) Remove unnecessary, expensive column matcher lookup In-Reply-To: <2002509778.1236718370587.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680691#action_12680691 ] Evgeny Ryabitskiy commented on HBASE-1253: ------------------------------------------ Comment here have to be fixed according changes: // Holds matchers for each column family. Its keyed by the byte [] hashcode // which you can get by calling Bytes.mapKey. private Vector matchers = new Vector(); > Remove unnecessary, expensive column matcher lookup > --------------------------------------------------- > > Key: HBASE-1253 > URL: https://issues.apache.org/jira/browse/HBASE-1253 > Project: Hadoop HBase > Issue Type: Improvement > Reporter: stack > Fix For: 0.19.1 > > Attachments: 1253.patch > > > We do lots of matching on columns. We have different kinds of matchers dependent on how the scanner was configured. Down in HAS, we have a map of family name to its matchers. There is no need of the Map since column matching is done at the family/store context only. Removing should save on some unnecessary CPU (I saw up to 10% in simple seek+scan test -- so hopefully this comes down to 5 or 4%). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.