hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1262) Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
Date Wed, 18 Mar 2009 20:15:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683147#action_12683147
] 

stack commented on HBASE-1262:
------------------------------

(Review with Nitay and I sitting together):

Good one:

   public static StoreKeyComparator getRawComparator(final HRegionInfo hri) {
-    return hri.isRootRegion()? ROOT_COMPARATOR:
-      hri.isMetaRegion()? META_COMPARATOR: META_COMPARATOR;
+    return hri.isRootRegion() ? ROOT_COMPARATOR : META_COMPARATOR;


Should be PLAIN_COMPARATOR instead as the final result of the above mess

Yeah, the Serializable stuff doesn't add anything except maybe a little confusion as to whats
going on

(Nitay found this himself) in HTD equals, returning wrong side of a boolean

Don't add the @overrides?

Otherwise, looks great.



> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method.
Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1262
>                 URL: https://issues.apache.org/jira/browse/HBASE-1262
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.19.0
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Trivial
>             Fix For: 0.19.2
>
>         Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message