hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1264) Wrong return values of compareTo in org.apache.hadoop.hbase.filter.RegexStringComparator
Date Thu, 19 Mar 2009 09:13:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683377#action_12683377
] 

stack commented on HBASE-1264:
------------------------------

This is how it is in the file currently:

 71     return pattern.matcher(Bytes.toString(value)).find() ? 1 : 0;

Do you want the 0 and the 1 flipped?  So its:

<     return pattern.matcher(Bytes.toString(value)).find() ? 0 : 1;

Your patch is a bit odd in that it would seem to make the file into what it already has.

You might try 'diff -u FILENAME'.  Do the diff from $HBASE_HOME.  Thats how we apply them,
at that location.  Otherwise, checkout hbase and do svn diff FILENAME.

Thanks Thomas.

> Wrong return values of compareTo in org.apache.hadoop.hbase.filter.RegexStringComparator
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-1264
>                 URL: https://issues.apache.org/jira/browse/HBASE-1264
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: filters
>         Environment: Ubuntu 8.04 (64 Bit), JDK 1.6
>            Reporter: Thomas Schneider
>            Priority: Minor
>         Attachments: hbase-1264.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The return values of the compareTo() method have to be changed against each other. The
method has to return 0 if the regex matches and 1 if it does not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message