hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1274) TestMergeTable is broken in Hudson
Date Fri, 20 Mar 2009 08:40:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683795#action_12683795
] 

Nitay Joffe commented on HBASE-1274:
------------------------------------

I know what caused this, it's this part of r755878:

diff --git src/java/org/apache/hadoop/hbase/HMerge.java src/java/org/apache/hadoop/hbase/HMerge.java
index af0bc89..361d1d3 100644
--- src/java/org/apache/hadoop/hbase/HMerge.java
+++ src/java/org/apache/hadoop/hbase/HMerge.java
@@ -110,7 +110,7 @@ class HMerge implements HConstants {
 
       this.tabledir = new Path(
           fs.makeQualified(new Path(conf.get(HBASE_DIR))),
-          tableName.toString()
+          Bytes.toString(tableName)
       );
       Path logdir = new Path(tabledir, "merge_" + System.currentTimeMillis() +
           HREGION_LOGDIR_NAME);


If I undo this the test passes.

Stack and I thought that change was innocuous and only helpful (because calling toString on
an tableName, which is an array, yields garbage). Turns out some logic in the test/code actually
depends on it.

Will dig deeper to find out why.

> TestMergeTable is broken in Hudson
> ----------------------------------
>
>                 Key: HBASE-1274
>                 URL: https://issues.apache.org/jira/browse/HBASE-1274
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> http://hudson.zones.apache.org/hudson/job/HBase-Patch/539/testReport/org.apache.hadoop.hbase/TestMergeTable/testMergeTable/
> java.io.IOException: Files have same sequenceid
> 	at org.apache.hadoop.hbase.regionserver.HRegion.merge(HRegion.java:2500)
> 	at org.apache.hadoop.hbase.regionserver.HRegion.mergeAdjacent(HRegion.java:2412)
> 	at org.apache.hadoop.hbase.HMerge$Merger.merge(HMerge.java:167)
> 	at org.apache.hadoop.hbase.HMerge$Merger.process(HMerge.java:126)
> 	at org.apache.hadoop.hbase.HMerge.merge(HMerge.java:91)
> 	at org.apache.hadoop.hbase.TestMergeTable.testMergeTable(TestMergeTable.java:35)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message