hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1272) Unreadable log messages -- "... to the only server localhost_1237525439599_56094" <- You'd have to be perverse to recognize that as a hostname, startcode, and port number.
Date Fri, 20 Mar 2009 08:20:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683789#action_12683789
] 

stack commented on HBASE-1272:
------------------------------

This seems more reasonable to me:

{code}
Index: src/java/org/apache/hadoop/hbase/HServerInfo.java
===================================================================
--- src/java/org/apache/hadoop/hbase/HServerInfo.java   (revision 755875)
+++ src/java/org/apache/hadoop/hbase/HServerInfo.java   (working copy)
@@ -198,10 +198,10 @@
 
   private static String getServerName(String hostName, int port, long startCode) {
     StringBuilder name = new StringBuilder(hostName);
-    name.append("_");
+    name.append(":");
+    name.append(port);
+    name.append(",");
     name.append(startCode);
-    name.append("_");
-    name.append(port);
     return name.toString();
   }
 }
{code}

> Unreadable log messages -- "... to the only server localhost_1237525439599_56094" <-
You'd have to be perverse to recognize that as a hostname, startcode, and port number.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1272
>                 URL: https://issues.apache.org/jira/browse/HBASE-1272
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message