Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@locus.apache.org Received: (qmail 80220 invoked from network); 20 Jan 2009 21:23:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Jan 2009 21:23:24 -0000 Received: (qmail 6586 invoked by uid 500); 20 Jan 2009 21:23:24 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 6418 invoked by uid 500); 20 Jan 2009 21:23:23 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 6407 invoked by uid 99); 20 Jan 2009 21:23:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2009 13:23:23 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2009 21:23:22 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B9D35234C4B6 for ; Tue, 20 Jan 2009 13:23:02 -0800 (PST) Message-ID: <595922775.1232486582760.JavaMail.jira@brutus> Date: Tue, 20 Jan 2009 13:23:02 -0800 (PST) From: "Evgeny Ryabitskiy (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Updated: (HBASE-876) There are a large number of Java warnings in HBase In-Reply-To: <1120845051.1220775104413.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Ryabitskiy updated HBASE-876: ------------------------------------ Attachment: 876_7.patch 876_7.patch is for: org.apache.hadoop.hbase.master.metrics org.apache.hadoop.hbase.metrics.file org.apache.hadoop.hbase.regionserver org.apache.hadoop.hbase.regionserver.metrics org.apache.hadoop.hbase.regionserver.tableindexed org.apache.hadoop.hbase.regionserver.transactional org.apache.hadoop.hbase.rest > There are a large number of Java warnings in HBase > -------------------------------------------------- > > Key: HBASE-876 > URL: https://issues.apache.org/jira/browse/HBASE-876 > Project: Hadoop HBase > Issue Type: Bug > Affects Versions: 0.18.0 > Reporter: Jim Kellerman > Assignee: Evgeny Ryabitskiy > Priority: Minor > Fix For: 0.20.0 > > Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch, 876_7.patch > > > There are a large number of Java warnings in the current HBase code base including: > - exceptions that do not define serialVersionUID > - classes that use the raw type WritableComparable instead of WritableComparable > - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed > - methods that have unnecessary else clauses > - potential null pointer access > - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation) > - assignment to an input parameter -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.