Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@locus.apache.org Received: (qmail 53138 invoked from network); 23 Jan 2009 23:22:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Jan 2009 23:22:30 -0000 Received: (qmail 68588 invoked by uid 500); 23 Jan 2009 23:22:24 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 68567 invoked by uid 500); 23 Jan 2009 23:22:24 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 68556 invoked by uid 99); 23 Jan 2009 23:22:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2009 15:22:24 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [63.203.238.117] (HELO dns.duboce.net) (63.203.238.117) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2009 23:22:16 +0000 Received: by dns.duboce.net (Postfix, from userid 1008) id A4AB0C51D; Fri, 23 Jan 2009 13:53:58 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-26) on dns.duboce.net X-Spam-Level: Received: from durruti.local (unknown [192.168.1.143]) by dns.duboce.net (Postfix) with ESMTP id 14364C256 for ; Fri, 23 Jan 2009 13:53:57 -0800 (PST) Message-ID: <497A5112.5060202@duboce.net> Date: Fri, 23 Jan 2009 15:21:54 -0800 From: stack User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: hbase-dev@hadoop.apache.org Subject: Re: svn commit: r737241 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HLog.java src/java/org/apache/hadoop/hbase/regionserver/HRegion.java src/test/org/apache/hadoop/hbase/regionserver/TestHLog.java References: <20090123230938.3D13B2388892@eris.apache.org> In-Reply-To: <20090123230938.3D13B2388892@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-4.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.4 The below is committed without a chance of someone reviewing it. Its also committed and the issue closed with no comment on the performance issue raised in HBASE-1148. jimk@apache.org wrote: > + boolean sync = regionInfo.isMetaRegion() || regionInfo.isRootRegion(); > + doWrite(logKey, logEdit, sync); I thought isMetaRegion returned true whether .META. or -ROOT- region (so its javadoc says). > + (regionInfo.isMetaRegion() || regionInfo.isRootRegion())); > Same here. St.Ack