hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-876) There are a large number of Java warnings in HBase
Date Tue, 20 Jan 2009 06:34:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665348#action_12665348
] 

stack commented on HBASE-876:
-----------------------------

I applied parts 1, 2, and 3.  I left out changes to SequenceFile and MapFile from part 3 since
they are from hadoop itself and we don't want to change these since it'll make it harder going
forward ensuring we pick up changes that have happened in parent versions (these should be
going away soon in next version or so of hbase anyways).

Thanks Evgeny for the great cleanup.  Do you have more?  If not, I'll close the issue.

> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
>                 Key: HBASE-876
>                 URL: https://issues.apache.org/jira/browse/HBASE-876
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.18.0
>            Reporter: Jim Kellerman
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: 876_1.patch, 876_2.patch, 876_3.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public
API. In this case they should be moved to a place where their visibility needs not be public.
Additionally, there are a number of classes that declare public members that need not be.
Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message