hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgeny Ryabitskiy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-876) There are a large number of Java warnings in HBase
Date Sat, 10 Jan 2009 01:13:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662594#action_12662594
] 

Evgeny Ryabitskiy commented on HBASE-876:
-----------------------------------------

So now I am fighting with warnings.  There already more than 100 left. And my patch will affect
on almost every source java file :)

I am also fighting with warnings for Annotations like this: 
 - Unnecessary @SuppressWarnings("unused")

There still warnings like this:
- Access to enclosing method "myMethod" from the type "myClass" is emulated by a synthetic
accessor method. Increasing its visibility will improve your performance

> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
>                 Key: HBASE-876
>                 URL: https://issues.apache.org/jira/browse/HBASE-876
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.18.0
>            Reporter: Jim Kellerman
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public
API. In this case they should be moved to a place where their visibility needs not be public.
Additionally, there are a number of classes that declare public members that need not be.
Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message