Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@locus.apache.org Received: (qmail 85220 invoked from network); 22 Dec 2008 22:06:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Dec 2008 22:06:05 -0000 Received: (qmail 53662 invoked by uid 500); 22 Dec 2008 22:06:05 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 53644 invoked by uid 500); 22 Dec 2008 22:06:05 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 53632 invoked by uid 99); 22 Dec 2008 22:06:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2008 14:06:05 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2008 22:06:04 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 470AE234C463 for ; Mon, 22 Dec 2008 14:05:44 -0800 (PST) Message-ID: <1252921002.1229983544289.JavaMail.jira@brutus> Date: Mon, 22 Dec 2008 14:05:44 -0800 (PST) From: "Jim Kellerman (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Commented: (HBASE-543) A region's state is kept in several places in the master opening the possibility for race conditions In-Reply-To: <110325218.1206397644432.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658684#action_12658684 ] Jim Kellerman commented on HBASE-543: ------------------------------------- Oh, crud. I knew I forgot something. Need to add unsetRootRegion to HConnectionManager$TableServers and disallow setting rootRegionLocation to null). If it is ok with everyone, if the new patch passes muster, I will make the above changes just before commit. > A region's state is kept in several places in the master opening the possibility for race conditions > ---------------------------------------------------------------------------------------------------- > > Key: HBASE-543 > URL: https://issues.apache.org/jira/browse/HBASE-543 > Project: Hadoop HBase > Issue Type: Bug > Components: master > Affects Versions: 0.1.0, 0.1.1, 0.2.0 > Reporter: Jim Kellerman > Assignee: Jim Kellerman > Fix For: 0.19.0 > > Attachments: 543.patch, 543.patch, 543.patch, recent-changes.patch, regionstate.txt > > > A region's state exists in multiple maps in the RegionManager: unassignedRegions, pendingRegions, regionsToClose, closingRegions, regionsToDelete, etc. > One of these race conditions was found in HBASE-534. > For HBase-0.1.x, we should just patch the holes we find. > The ultimate solution (which requires a lot of changes in HMaster) should be applied to HBase trunk. > Proposed solution: > Create a class that encapsulates a region's state and provide synchronized access to the class that validates state changes. > There should be a single structure that holds regions in these transitional states and it should be a synchronized collection of some kind. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.