Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1073660312.1230071204311.JavaMail.jira@brutus>
Date: Tue, 23 Dec 2008 14:26:44 -0800 (PST)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-543) A region's state is kept in several
 places in the master opening the possibility for race conditions
In-Reply-To: <110325218.1206397644432.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658977#action_12658977 ] 

stack commented on HBASE-543:
-----------------------------

Patch is messy; some accesss to regionManager are synchronized whereas others are not.  Confusing.   Also still wary of many threads synchronizing on a single important master object afraid that someone in production is going to find a codepath that deadlocks -- and that it makes the master less 'live'.  That said, I ran it under duress and no noticable degradation and all unit tests pass.  Andrew Purtell's testimony in its favor sends me over to +1 on commit.  At a minimum, its a big improvement over what we had before.   Also, this stuff will be rewritten on ZK integration; we can do a better job then.

> A region's state is kept in several places in the master opening the possibility for race conditions
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-543
>                 URL: https://issues.apache.org/jira/browse/HBASE-543
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.1.0, 0.1.1, 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.19.0
>
>         Attachments: 543.patch, 543.patch, 543.patch, 543.patch-4, 543.patch-5, 543.patch-6, recent-changes.patch, regionstate.txt
>
>
> A region's state exists in multiple maps in the RegionManager: unassignedRegions, pendingRegions, regionsToClose, closingRegions, regionsToDelete, etc.
> One of these race conditions was found in HBASE-534.
> For HBase-0.1.x, we should just patch the holes we find.
> The ultimate solution (which requires a lot of changes in HMaster) should be applied to HBase trunk.
> Proposed solution:
> Create a class that encapsulates a region's state and provide synchronized access to the class that validates state changes.
> There should be a single structure that holds regions in these transitional states and it should be a synchronized collection of some kind.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.