hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-543) A region's state is kept in several places in the master opening the possibility for race conditions
Date Sun, 21 Dec 2008 23:33:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658425#action_12658425
] 

stack commented on HBASE-543:
-----------------------------

Andrew: Thats good news.

More comments on patch for Jim:

In RegionState, data members are named isUnassigned, isClosing, etc.  Usual javabean convention
is that data members are named unassigned, closing, etc. and that isClosing is one of the
names getters have.

Why dumpState and not toString?







> A region's state is kept in several places in the master opening the possibility for
race conditions
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-543
>                 URL: https://issues.apache.org/jira/browse/HBASE-543
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.1.0, 0.1.1, 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.19.0
>
>         Attachments: 543.patch, 543.patch, recent-changes.patch, regionstate.txt
>
>
> A region's state exists in multiple maps in the RegionManager: unassignedRegions, pendingRegions,
regionsToClose, closingRegions, regionsToDelete, etc.
> One of these race conditions was found in HBASE-534.
> For HBase-0.1.x, we should just patch the holes we find.
> The ultimate solution (which requires a lot of changes in HMaster) should be applied
to HBase trunk.
> Proposed solution:
> Create a class that encapsulates a region's state and provide synchronized access to
the class that validates state changes.
> There should be a single structure that holds regions in these transitional states and
it should be a synchronized collection of some kind.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message