hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Slava (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1014) commit(BatchUpdate) method should return timestamp
Date Sun, 23 Nov 2008 08:29:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649997#action_12649997

Slava commented on HBASE-1014:

Hi.I think it's better to put the timestamp in the server side, otherwise
it's requires client time synchronization.
BTW, in the transactional code, there not immediate commit, but the time
stamp is calculated during batchupdate insertion into transactional log:

 long commitTime = update.getTimestamp() == HConstants.LATEST_TIMESTAMP ?
        : update.getTimestamp();

    for (BatchOperation op : update) {
      HLogEdit logEdit = new HLogEdit(transactionId, op, commitTime);
      hlog.append(regionInfo, update.getRow(), logEdit);

I think also in the case of BU cache it should be the same.

Best Regards.

> commit(BatchUpdate)  method should return timestamp
> ---------------------------------------------------
>                 Key: HBASE-1014
>                 URL: https://issues.apache.org/jira/browse/HBASE-1014
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Slava
>             Fix For: 0.19.0
> The commit(BatchUpdate) and commit(list<BatchUpdate>) should return timestamp that
BatchUpdate was committed with (in the case of commit(list<BatchUpdate> should return
array of timestamps). 
> This should reduce number of round trips and improve performance in update operations.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message