hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-902) Add force major compaction and force split to UI
Date Tue, 14 Oct 2008 04:09:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639291#action_12639291

stack commented on HBASE-902:

Patch looks good to me Andrew.

Below doesn't need to be in an else:

+    } else {
+      synchronized (onlineMetaRegions) {
+        return onlineMetaRegions.get(
+          onlineMetaRegions.tailMap(key).firstKey());
+      }

...given as the clause above it ends in a return.

Only concern is what if a split is ongoing or if master gets a SPLIT message when it has one

Run 'ant javadoc'.  I think you should see warnings going by what you've added.   See if you
can clean them up.

Is this intended:

-        writeClassCode(out, c);
+        out.writeByte(code);

Should these be enums?  No biggie, just a suggestion:
+  /** modifyTable op for replacing the table descriptor */
+  public static final int SET_HTD = 1;
+  /** modifyTable op for forcing a split */
+  public static final int SPLIT = 2;
+  /** modifyTable op for forcing a compaction */
+  public static final int COMPACT = 3;

Otherwise, looks great.

> Add force major compaction and force split to UI
> ------------------------------------------------
>                 Key: HBASE-902
>                 URL: https://issues.apache.org/jira/browse/HBASE-902
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Andrew Purtell
>         Attachments: 902-1.patch, 902-2.patch, split.png, ui.1.png
> Would help debugging or at start of big upload or if we have a hot region we want to
distribute over the cluster if we could just manually force the splitting of regions.
> I thought it would be just a little messing in jsp but its a bit more than that.
> Actual decision to split is made down in guts of the Store.  Won't split if any references
still around and a file must be > maxsize.
> Chatting w/ Jon Gray, could set a flag on the region that we want to split.  Could do
this from UI (Can get to HRegion instance from HRS instance in HRS jsp).  Stores have references
to their hosting regions (I think).  When figuring if we're to split, check the force split
flag up in the hosting region.
> To get the flag checked, safest way is to just force a flush (Otherwise, have to mess
w/ locks in the compact/splitter thread).  Registering a flush request on a region is easy
enough to do.  Its a public method on HRS (or HR).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message