Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1279155585.1221078344255.JavaMail.jira@brutus>
Date: Wed, 10 Sep 2008 13:25:44 -0700 (PDT)
From: "Ryan Smith (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Issue Comment Edited: (HBASE-765) Adding basic Spring DI
 support to IndexConfiguration class.
In-Reply-To: <1186764590.1216830992317.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629944#action_12629944 ] 

osm edited comment on HBASE-765 at 9/10/08 1:24 PM:
-----------------------------------------------------------

(originally posted 24 July 2008)
After further review, there are 2 more classes that are using addFromXML()
IndexOutputFormat and IndexTableReduce use the xml string to configure the indexconfig object.
I will have to modify these 3 classes so I will be developing the patch over this week, maybe next week too.


      was (Author: osm):
    (originally posted July 24 2008)
EDIT: after further review, there are 2 more classes that are using addFromXML()
IndexOutputFormat and IndexTableReduce use the xml string to configure the indexconfig object.
I will have to modify these 3 classes so I will be developing the patch over this week, maybe next week too.

  
> Adding basic Spring DI support to IndexConfiguration class.
> -----------------------------------------------------------
>
>                 Key: HBASE-765
>                 URL: https://issues.apache.org/jira/browse/HBASE-765
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0, 0.1.0, 0.1.1, 0.1.2, 0.1.3
>         Environment: n/a
>            Reporter: Ryan Smith
>            Priority: Minor
>             Fix For: 0.19.0, 0.2.2
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> Spring can configure classes/object graphs via xml.  I am pretty much able to configure the entire MR object graph to launch MR jobs via spring except class IndexConfiguration.java. So instead of only using addFromXML() to configure IndexConfiguration, it would be nice to add support so Spring could set all class variables needed for initialization in IndexConfiguration without invoking addFromXML().  
> Since the class IndexConfiguration already has setters and getters for almost all its members, it's almost compliant for a spring configuration bean except one issue: no ability to configure columnMap outside of calling addFromXML().  The easiest way i can figure is to allow a setter for the column map and put any logic for checking the map integrity there.  By adding a few methods to IndexConfiguration.java , it should solve the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.