hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-885) TableMap and TableReduce should be interfaces
Date Mon, 15 Sep 2008 23:09:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631177#action_12631177
] 

stack commented on HBASE-885:
-----------------------------

+1 on this patch (TRUNK is currently frozen).  

The only small concern I have is that it will break extant code derived from TableMap.  Existing
code will have to change so it implements rather than extends TableMap.  IMO this is a small
inconvenience.

> TableMap and TableReduce should be interfaces
> ---------------------------------------------
>
>                 Key: HBASE-885
>                 URL: https://issues.apache.org/jira/browse/HBASE-885
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Doğacan Güney
>            Priority: Minor
>         Attachments: tablemr.patch
>
>
> TableMap and TableReduce are abstract classes which makes it impossible to write a class
that maps from and reduce to hbase. IMHO, they should be interfaces since they only define
a single and static method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message