Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@locus.apache.org Received: (qmail 89012 invoked from network); 22 Aug 2008 17:41:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Aug 2008 17:41:05 -0000 Received: (qmail 15375 invoked by uid 500); 22 Aug 2008 17:41:04 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 15366 invoked by uid 500); 22 Aug 2008 17:41:03 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 15355 invoked by uid 99); 22 Aug 2008 17:41:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2008 10:41:03 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2008 17:40:15 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DC4F9234C1CB for ; Fri, 22 Aug 2008 10:40:44 -0700 (PDT) Message-ID: <2123088508.1219426844901.JavaMail.jira@brutus> Date: Fri, 22 Aug 2008 10:40:44 -0700 (PDT) From: "Izaak Rubin (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Commented: (HBASE-841) Consolidate multiple overloaded methods in HRegionInterface, HRegionServer In-Reply-To: <1044958457.1219170344373.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624918#action_12624918 ] Izaak Rubin commented on HBASE-841: ----------------------------------- Thanks for the patch JD! > Consolidate multiple overloaded methods in HRegionInterface, HRegionServer > -------------------------------------------------------------------------- > > Key: HBASE-841 > URL: https://issues.apache.org/jira/browse/HBASE-841 > Project: Hadoop HBase > Issue Type: Improvement > Components: ipc, regionserver > Affects Versions: 0.2.0 > Reporter: Jim Kellerman > Assignee: Izaak Rubin > Priority: Blocker > Fix For: 0.18.0 > > Attachments: hbase-841.patch > > > There are too many overloaded methods in HRegionServerInterface and consequently HRegionServer. > These should be consolidated into one method per operation and the client should pass the appropriate parameters to the server. > On the server side, the single method should be able to handle parameters that are not supplied, e.g., > - long values that are not supplied should be -1 > - boolean values should be supplied appropriately > - objects that are not supplied should be passed as null > All these overloaded methods eventually call the same method on the server side eventually. Removing the overloads would make following control flow easier. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.