Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <228295929.1215636091812.JavaMail.jira@brutus>
Date: Wed, 9 Jul 2008 13:41:31 -0700 (PDT)
From: "Izaak Rubin (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Issue Comment Edited: (HBASE-732) shell formatting error
 with the describe command
In-Reply-To: <817365155.1215561871664.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612267#action_12612267 ] 

irubin edited comment on HBASE-732 at 7/9/08 1:41 PM:
-----------------------------------------------------------

I've attached a patch (see above hbase-732.patch).  It fixes the problem of repeating text in the output of the describe command.  The problem was not specific to the describe command, but rather to any long string that was passed through the split() method in bin/Formatter.rb.  The split() method uses Ruby's String.splice() method, which can take 2 arguments meant to signify a starting position and a length of the substring.  There was confusion as to whether the second argument should be the length of the substring or the ending position of the substring.

I've also added some additional tests to bin/Formatter.rb.

The tests in bin/Formatter.rb and bin/HBase.rb all passed.  Standard HBase tests were not run, as none of the actual Java code was modified.

      was (Author: irubin):
    Fixes the problem of repeating text in the output of the describe command.  The problem was not specific to the describe command, but rather to any long string that was passed through the split() method in bin/Formatter.rb.  The split() method uses Ruby's String.splice() method, which can take 2 arguments meant to signify a starting position and a length of the substring.  There was confusion as to whether the second argument should be the length of the substring or the ending position of the substring.

I've also added some additional tests to bin/Formatter.rb.

The tests in bin/Formatter.rb and bin/HBase.rb all passed.  Standard HBase tests were not run, as none of the actual Java code was modified.
  
> shell formatting error with the describe command
> ------------------------------------------------
>
>                 Key: HBASE-732
>                 URL: https://issues.apache.org/jira/browse/HBASE-732
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: documentation, scripts
>            Reporter: Izaak Rubin
>            Assignee: Izaak Rubin
>            Priority: Minor
>         Attachments: hbase-732.patch
>
>
> The formatting of the output of the shell command "describe" repeats some of the text.  The following is an example of the problem:
> {code}
> hbase(main):001:0> describe 'table2'
> NAME => 'table2', FAMILIES => [{NAME => 'fam3', VERSIONS => 3, COMPRESSION => 'NONE', IN_MEMORY => false, BLOC
> KCACHE => false, LENGTH => 2147483647, TTL => FOREVER, BLOOMFILTER => NONE}, {NAME => 'fam2', VERSIONS => 6, COMPRESSION => 'NONE', IN_MEMORY => false, BLOCKCACHE => false, LENGTH => 2147483647, TTL => FOREVER, BLOOMFILT
> OMPRESSION => 'NONE', IN_MEMORY => false, BLOCKCACHE => false, LENGTH => 2147483647, TTL => FOREVER, BLOOMFILTER => NONE}, {NAME => 'fam1', VERSIONS => 5, COMPRESSION => 'NONE', IN_MEMORY => false, BLOCKCACHE => false, LENGTH => 2147483647, TTL => FOREVER, BLOOMFILTER => NONE}]
> ER => NONE}, {NAME => 'fam1', VERSIONS => 5, COMPRESSION => 'NONE', IN_MEMORY => false, BLOCKCACHE => false, LENGTH => 2147483647, TTL => FOREVER, BLOOMFILTER => NONE}]
> ENGTH => 2147483647, TTL => FOREVER, BLOOMFILTER => NONE}]                                                    
> 1 row(s) in 0.2520 seconds
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.