hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-677) Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
Date Tue, 10 Jun 2008 21:51:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604053#action_12604053
] 

stack commented on HBASE-677:
-----------------------------

Whats this about Clint?

{code}
@@ -220,9 +222,10 @@
     out.writeBoolean(metaregion);
     Bytes.writeByteArray(out, name);
     out.writeInt(families.size());
+    Configuration conf = new HBaseConfiguration();
     for(Iterator<HColumnDescriptor> it = families.values().iterator();
         it.hasNext(); ) {
-      it.next().write(out);
+      ObjectWritable.writeObject(out, it.next(), HColumnDescriptor.class, conf);
     }
   }
{code}

I'm guessing this an unintentional addition?

Otherwise, rest of patch looks fine.  Let me know about above and I'll apply all but above
changes.

> Make HTable, HRegion, HRegionServer, HStore, and HColumnDescriptor subclassable
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-677
>                 URL: https://issues.apache.org/jira/browse/HBASE-677
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>         Attachments: hbase-677.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message