Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@locus.apache.org Received: (qmail 35593 invoked from network); 16 May 2008 18:18:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 May 2008 18:18:19 -0000 Received: (qmail 80821 invoked by uid 500); 16 May 2008 18:18:21 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 80729 invoked by uid 500); 16 May 2008 18:18:20 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 80693 invoked by uid 99); 16 May 2008 18:18:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2008 11:18:20 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2008 18:17:34 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B05E0234C11B for ; Fri, 16 May 2008 11:17:55 -0700 (PDT) Message-ID: <1636588775.1210961875721.JavaMail.jira@brutus> Date: Fri, 16 May 2008 11:17:55 -0700 (PDT) From: "stack (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Commented: (HBASE-629) Split reports incorrect elapsed time In-Reply-To: <954276104.1210958875930.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597563#action_12597563 ] stack commented on HBASE-629: ----------------------------- +1 on removing unused methods and exceptions. > Split reports incorrect elapsed time > ------------------------------------ > > Key: HBASE-629 > URL: https://issues.apache.org/jira/browse/HBASE-629 > Project: Hadoop HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.2.0 > Reporter: Jim Kellerman > > Split reports incorrect elapsed time. That is because the start time for the split is never set. (It used to be set in closing()). > Additionally, since CompactSplitThread doesn't do anything in closing or closed anymore, why keep them around? > We can just pass null for the RegionUnavailableListener and can then remove closing and closed from CompactSplitThread. > In fact, it turns out that RegionUnavailableListener is not used anywhere anymore so it should just be removed altogether. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.