Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1603272251.1210888255719.JavaMail.jira@brutus>
Date: Thu, 15 May 2008 14:50:55 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-626) Use Visitor pattern in MetaRegion to
 reduce code clones in HTable and HConnectionManager
In-Reply-To: <1612727624.1210709155629.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597286#action_12597286 ] 

stack commented on HBASE-626:
-----------------------------

Sorry.  Missing words.  Should have said: "This is a great patch..."

I took a look at HTable.  What if you took 'tableName' instead of a startRow and a scannerRow?


> Use Visitor pattern in MetaRegion to reduce code clones in HTable and HConnectionManager
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-626
>                 URL: https://issues.apache.org/jira/browse/HBASE-626
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: hbase-626-v1.patch
>
>
> HTable and HConnectionManager.TableServers both scan the meta region in the same way (but the later also retry one time if it fails). A Visitor pattern should be used in a new scanning method in MetaRegion to accept visitors that gather information such as region names for a table or the list of all tables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.