hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-626) Use Visitor pattern in MetaRegion to reduce code clones in HTable and HConnectionManager
Date Thu, 15 May 2008 20:50:55 GMT

    [ https://issues.apache.org/jira/browse/HBASE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597255#action_12597255
] 

Jean-Daniel Cryans commented on HBASE-626:
------------------------------------------

bq. This is patch for all the duplicated code it removes.

Is there a word missing or you mean that this patch is as good as leaving the code duplicated?

bq. Why pass in scannerRow and startRow? When would they ever differ?

See in HTable. Basically I keep the same behavior as the code before this patch.

On HCM, I think you`re right.

> Use Visitor pattern in MetaRegion to reduce code clones in HTable and HConnectionManager
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-626
>                 URL: https://issues.apache.org/jira/browse/HBASE-626
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: hbase-626-v1.patch
>
>
> HTable and HConnectionManager.TableServers both scan the meta region in the same way
(but the later also retry one time if it fails). A Visitor pattern should be used in a new
scanning method in MetaRegion to accept visitors that gather information such as region names
for a table or the list of all tables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message