hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-649) API polluted with default and protected access data members and methods
Date Thu, 29 May 2008 17:27:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600846#action_12600846
] 

stack commented on HBASE-649:
-----------------------------

For example, here is from head of the HTable javadoc:

{code}
protected  class 	HTable.ClientScanner
          Implements the scanner interface for the HBase client.
protected  class 	HTable.ServerCallable<T>
          Inherits from Callable, used to define the particular actions you would like to
take with retry logic.
 
Field Summary
protected  AtomicReference<BatchUpdate> 	batch
           
protected  boolean 	closed
           
protected  HConnection 	connection
           
protected  org.apache.commons.logging.Log 	LOG
           
protected  int 	numRetries
           
protected  long 	pause
           
protected  Random 	rand
           
protected  boolean 	tableDoesNotExist
           
protected  org.apache.hadoop.io.Text 	tableName
           
{code}

None of the above should be showing through in javadoc.

> API polluted with default and protected access data members and methods
> -----------------------------------------------------------------------
>
>                 Key: HBASE-649
>                 URL: https://issues.apache.org/jira/browse/HBASE-649
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>
> If you look at the API in javadoc, its polluted with data members and methods of protected
or default access.  It makes it difficult for users figuring how the API should be used. 
At least the user-facing classes -- HTable and HBaseAdmin -- need cleanup

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message