Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <922552096.1208884161747.JavaMail.jira@brutus>
Date: Tue, 22 Apr 2008 10:09:21 -0700 (PDT)
From: "Jim Kellerman (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-584) Names in the filter interface are
 confusing
In-Reply-To: <1132467699.1208366961840.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591367#action_12591367 ] 

Jim Kellerman commented on HBASE-584:
-------------------------------------

Clint,

I reviewed the patch and while it is fine in renaming filter methods, it does not include the old names as deprecated methods. Our policy is that an existing API must continue to exist for one release before the new API is the default and the deprecated APIs are removed.

Deprecated methods should include an @deprecated flag in javadoc and a @Deprecated annotation.


> Names in the filter interface are confusing
> -------------------------------------------
>
>                 Key: HBASE-584
>                 URL: https://issues.apache.org/jira/browse/HBASE-584
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>         Attachments: hbase-584.patch
>
>
> I don't like the names of the filter methods in RowFilterInterface. They don't really tell how the methods are being used in the implementation of scanners.
> I'd like to change:
>  - filter(Text) to filterRow(...)
>  - filter(Text, Text, byte[]) to filterColumn(...)
>   and the worst one is
>  - filterNotNull(SortedMap<Text, byte[]>). This should be filterRow(Text, SortedMap<Text, byte[]>) (so we add the row key/).
> It may be nice to have timestamps in the methods as well? 
> Also the java doc could be cleaned and improved to tell how the filtering is implemented (check rows keys first, then check each individual columns, finally check the assembled row)
> Upon positive feedback, and I'll create a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.