Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1774332112.1209014121580.JavaMail.jira@brutus>
Date: Wed, 23 Apr 2008 22:15:21 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-581) Allow adding filters to
 TableInputFormat (At same time, ensure TIF and TOF are subclassable)
In-Reply-To: <1246743980.1208275744877.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-581:
------------------------

    Attachment: tif-v2.patch

Your patch looks good David.  Here's a v2 with some mild formatting.  It also changes the data members back to private and adds accessors instead -- would this work for you?  Regards the getSplits, the way you've redone the method, if numSplits is < number of regions, then you do best effort at divvying up the regions so some splits will have more than one region?  It works in your testing?  Add javadoc explaining how numSplits now is actually acted on in getSplits and then upload a new patch and we'll get it committed.  Thanks.

> Allow adding filters to TableInputFormat (At same time, ensure TIF and TOF are subclassable)
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-581
>                 URL: https://issues.apache.org/jira/browse/HBASE-581
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Priority: Critical
>             Fix For: 0.2.0
>
>         Attachments: tif-0.patch, tif-v2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.