hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-469) Streamline HStore startup and compactions
Date Fri, 04 Apr 2008 19:37:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585718#action_12585718
] 

stack commented on HBASE-469:
-----------------------------

In review I suggested that we log events, not that events didn't happen.

You counter:

> I think this is useful at debug level.

Here is an example:

{code}
    [junit] 2008-04-04 12:15:01,686 INFO  [RegionServer:0.compactor] regionserver.HRegion(852):
starting compaction on region -ROOT-,,0
    [junit] 2008-04-04 12:15:01,687 DEBUG [RegionServer:0.compactor] regionserver.HStore(726):
Not compacting 70236052/info because only one store file and it is not a reference
    [junit] 2008-04-04 12:15:01,691 INFO  [RegionServer:0.compactor] regionserver.HRegion(862):
compaction completed on region -ROOT-,,0. Took 0sec
{code}

Thats 3 lines of logging to say compaction did NOT run.

Here are other examples:

{code}
    [junit] 2008-04-04 12:15:12,707 DEBUG [RegionServer:0.compactor] regionserver.HStore(719):
Not compacting 1578871709/text because no store files to compact.
    [junit] 2008-04-04 12:15:12,707 DEBUG [RegionServer:0.compactor] regionserver.HStore(719):
Not compacting 1578871709/contents because no store files to compact.
{code}

When compaction does run, it logs.  Absence of logging is sufficient for me to know that compaction
did not run (I can't think of a reason why I'd want to know why the compaction did not run)

I'd suggest that the less noise in the logs, the easier to decipher whats going on whether
we're logging at INFO or DEBUG level and that we only log events... not their NOT having happened

> Streamline HStore startup and compactions
> -----------------------------------------
>
>                 Key: HBASE-469
>                 URL: https://issues.apache.org/jira/browse/HBASE-469
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.2.0
>
>         Attachments: patch.txt, patch.txt, patch.txt
>
>
> Several useful patches that streamline HStore startup and compactions that were a part
of the abandoned changes in HBASE-69 should be incorporated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message