hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject [hbase] branch branch-2 updated: HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException) (#2181)
Date Mon, 03 Aug 2020 20:16:36 GMT
This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 8c4f8e2  HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore:
Can NOT create CleanerDelegate= ClassNotFoundException) (#2181)
8c4f8e2 is described below

commit 8c4f8e28e46599b636ff93e501917ad117be312b
Author: Michael Stack <saintstack@users.noreply.github.com>
AuthorDate: Mon Aug 3 13:15:19 2020 -0700

    HBASE-24808 skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore:
Can NOT create CleanerDelegate= ClassNotFoundException) (#2181)
    
    
    Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
    Signed-off-by: Viraj Jasani <vjasani@apache.org>
    Signed-off-by: Sean Busbey <busbey@apache.org>
---
 .../java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index 7bac2e1..4331d49 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -151,7 +151,11 @@ public abstract class CleanerChore<T extends FileCleanerDelegate>
extends Schedu
     this.cleanersChain = new LinkedList<>();
     String[] logCleaners = conf.getStrings(confKey);
     if (logCleaners != null) {
-      for (String className : logCleaners) {
+      for (String className: logCleaners) {
+        className = className.trim();
+        if (className.isEmpty()) {
+          continue;
+        }
         T logCleaner = newFileCleaner(className, conf);
         if (logCleaner != null) {
           LOG.info("Initialize cleaner={}", className);


Mime
View raw message