From commits-return-90369-archive-asf-public=cust-asf.ponee.io@hbase.apache.org  Mon Nov  4 17:18:23 2019
Return-Path: <commits-return-90369-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 152BE180658
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  4 Nov 2019 18:18:22 +0100 (CET)
Received: (qmail 2229 invoked by uid 500); 4 Nov 2019 17:18:22 -0000
Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@hbase.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@hbase.apache.org>
List-Post: <mailto:commits@hbase.apache.org>
List-Id: <commits.hbase.apache.org>
Reply-To: dev@hbase.apache.org
Delivered-To: mailing list commits@hbase.apache.org
Received: (qmail 2220 invoked by uid 99); 4 Nov 2019 17:18:22 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Nov 2019 17:18:22 +0000
Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33)
	id 24DC0805E6; Mon,  4 Nov 2019 17:18:22 +0000 (UTC)
Date: Mon, 04 Nov 2019 17:18:21 +0000
To: "commits@hbase.apache.org" <commits@hbase.apache.org>
Subject: [hbase] branch master updated: HBASE-23243 [pv2] Filter out SUCCESS
 procedures; on decent-sized cluster, plethora overwhelms problems (#790)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Message-ID: <157288790149.3924.15081218928071843111@gitbox.apache.org>
From: stack@apache.org
X-Git-Host: gitbox.apache.org
X-Git-Repo: hbase
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: bbfc73789fb51bac8638cb67fa3bb363fec369bd
X-Git-Newrev: 2f8860b1daa478642b22cbf6840e8bf6d4004c5e
X-Git-Rev: 2f8860b1daa478642b22cbf6840e8bf6d4004c5e
X-Git-NotificationType: ref_changed_plus_diff
X-Git-Multimail-Version: 1.5.dev
Auto-Submitted: auto-generated

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 2f8860b  HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
2f8860b is described below

commit 2f8860b1daa478642b22cbf6840e8bf6d4004c5e
Author: Michael Stack <saintstack@users.noreply.github.com>
AuthorDate: Mon Nov 4 09:15:06 2019 -0800

    HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
    
    Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
    Signed-off-by: Sean Busbey <busbey@apache.org>
---
 hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp     | 2 +-
 .../src/main/resources/hbase-webapps/master/procedures.jsp        | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp b/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
index 27cb121..0ac6678 100644
--- a/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
@@ -109,7 +109,7 @@
       <p>
         <span>
         There are three cases: 1. Master thought this region opened, but no regionserver reported it (Fix: use assigns
-        command; 2. Master thought this region opened on Server1, but regionserver reported Server2 (Fix:
+        command); 2. Master thought this region opened on Server1, but regionserver reported Server2 (Fix:
         need to check the server is still exist. If not, schedule SCP for it. If exist, restart Server2 and Server1):
         3. More than one regionservers reported opened this region (Fix: restart the RegionServers).
         Notice: the reported online regionservers may be not right when there are regions in transition.
diff --git a/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp b/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
index de3c7a2..c918b30 100644
--- a/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
@@ -68,6 +68,7 @@
           <h1>Procedures</h1>
       </div>
   </div>
+  <p>We do not list Procedures that have completed SUCCESSfully; their number makes it hard to spot the problematics.</p>
   <table class="table table-striped" width="90%" >
     <tr>
         <th>Id</th>
@@ -80,7 +81,12 @@
         <th>Errors</th>
         <th>Parameters</th>
     </tr>
-    <% for (Procedure<?> proc : procedures) { %>
+    <% for (Procedure<?> proc : procedures) { 
+      // Don't show SUCCESS procedures.
+      if (proc.isSuccess()) {
+        continue;
+      }
+    %>
       <tr>
         <td><%= proc.getProcId() %></td>
         <td><%= proc.hasParent() ? proc.getParentProcId() : "" %></td>