hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject [hbase] branch branch-2.1 updated: HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms problems (#790)
Date Mon, 04 Nov 2019 17:17:34 GMT
This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new fe9b3a7  HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster,
plethora overwhelms problems (#790)
fe9b3a7 is described below

commit fe9b3a78746dd77e0ed8f09f1aca9b414090c42a
Author: Michael Stack <saintstack@users.noreply.github.com>
AuthorDate: Mon Nov 4 09:15:06 2019 -0800

    HBASE-23243 [pv2] Filter out SUCCESS procedures; on decent-sized cluster, plethora overwhelms
problems (#790)
    
    Signed-off-by: GuangxuCheng  <guangxucheng@gmail.com>
    Signed-off-by: Sean Busbey <busbey@apache.org>
---
 hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp     | 2 +-
 .../src/main/resources/hbase-webapps/master/procedures.jsp        | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp b/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
index 7b4e164..eb72f45 100644
--- a/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp
@@ -109,7 +109,7 @@
       <p>
         <span>
         There are three cases: 1. Master thought this region opened, but no regionserver
reported it (Fix: use assigns
-        command; 2. Master thought this region opened on Server1, but regionserver reported
Server2 (Fix:
+        command); 2. Master thought this region opened on Server1, but regionserver reported
Server2 (Fix:
         need to check the server is still exist. If not, schedule SCP for it. If exist, restart
Server2 and Server1):
         3. More than one regionservers reported opened this region (Fix: restart the RegionServers).
         Notice: the reported online regionservers may be not right when there are regions
in transition.
diff --git a/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp b/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
index c4adcd3..44c05d5 100644
--- a/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp
@@ -69,6 +69,7 @@
           <h1>Procedures</h1>
       </div>
   </div>
+  <p>We do not list Procedures that have completed SUCCESSfully; their number makes
it hard to spot the problematics.</p>
   <table class="table table-striped" width="90%" >
     <tr>
         <th>Id</th>
@@ -81,7 +82,12 @@
         <th>Errors</th>
         <th>Parameters</th>
     </tr>
-    <% for (Procedure<?> proc : procedures) { %>
+    <% for (Procedure<?> proc : procedures) { 
+      // Don't show SUCCESS procedures.
+      if (proc.isSuccess()) {
+        continue;
+      }
+    %>
       <tr>
         <td><%= proc.getProcId() %></td>
         <td><%= proc.hasParent() ? proc.getParentProcId() : "" %></td>


Mime
View raw message