From commits-return-89677-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Sat Sep 28 01:37:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9D3B0180638 for ; Sat, 28 Sep 2019 03:37:36 +0200 (CEST) Received: (qmail 92502 invoked by uid 500); 28 Sep 2019 01:37:36 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 92493 invoked by uid 99); 28 Sep 2019 01:37:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Sep 2019 01:37:35 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 5B4FA81E73; Sat, 28 Sep 2019 01:37:35 +0000 (UTC) Date: Sat, 28 Sep 2019 01:37:35 +0000 To: "commits@hbase.apache.org" Subject: [hbase] branch branch-1 updated: HBASE-23038 Provide consistent and clear logging about disabling chores MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <156963465494.19921.10002298832862531634@gitbox.apache.org> From: busbey@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: hbase X-Git-Refname: refs/heads/branch-1 X-Git-Reftype: branch X-Git-Oldrev: f77c14d18150f55ee892f8d24a5ee231c1ae7e20 X-Git-Newrev: b96aefd07f6e9a3e31d1bf99bcf84560545cf19a X-Git-Rev: b96aefd07f6e9a3e31d1bf99bcf84560545cf19a X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. busbey pushed a commit to branch branch-1 in repository https://gitbox.apache.org/repos/asf/hbase.git The following commit(s) were added to refs/heads/branch-1 by this push: new b96aefd HBASE-23038 Provide consistent and clear logging about disabling chores b96aefd is described below commit b96aefd07f6e9a3e31d1bf99bcf84560545cf19a Author: Sanjeet Nishad AuthorDate: Thu Sep 26 09:38:37 2019 +0530 HBASE-23038 Provide consistent and clear logging about disabling chores Differs from master/branch-2 version due to commons-logging Co-authored-by: Sean Busbey Signed-off-by: Viraj Jasani Signed-off-by: Sean Busbey (cherry picked from commit b45c0d0efa261509ac101748587051ba1c9184bb) --- hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java index 1623c10..49ac907 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java @@ -151,6 +151,10 @@ public class ChoreService implements ChoreServicer { } try { + if (chore.getPeriod() <= 0) { + LOG.info("The period is " + chore.getPeriod() + " seconds, " + chore.getName() + " is disabled"); + return false; + } chore.setChoreServicer(this); ScheduledFuture future = scheduler.scheduleAtFixedRate(chore, chore.getInitialDelay(), chore.getPeriod(),