From commits-return-89490-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Wed Sep 18 14:59:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F046180652 for ; Wed, 18 Sep 2019 16:59:02 +0200 (CEST) Received: (qmail 9984 invoked by uid 500); 18 Sep 2019 14:59:02 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 9972 invoked by uid 99); 18 Sep 2019 14:59:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Sep 2019 14:59:02 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id E477681C7C; Wed, 18 Sep 2019 14:59:01 +0000 (UTC) Date: Wed, 18 Sep 2019 14:59:01 +0000 To: "commits@hbase.apache.org" Subject: [hbase] branch branch-2.2 updated: HBASE-23040 give friendly message about unknown server when running unload for RegionMover. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <156881874175.7567.6722676208421080956@gitbox.apache.org> From: busbey@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: hbase X-Git-Refname: refs/heads/branch-2.2 X-Git-Reftype: branch X-Git-Oldrev: 8869b8e4529fdea72794664f4f128323e60435cb X-Git-Newrev: b58116ed804876141124b450898686e5f7a0d251 X-Git-Rev: b58116ed804876141124b450898686e5f7a0d251 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. busbey pushed a commit to branch branch-2.2 in repository https://gitbox.apache.org/repos/asf/hbase.git The following commit(s) were added to refs/heads/branch-2.2 by this push: new b58116e HBASE-23040 give friendly message about unknown server when running unload for RegionMover. b58116e is described below commit b58116ed804876141124b450898686e5f7a0d251 Author: Sean Busbey AuthorDate: Tue Sep 17 22:47:17 2019 -0500 HBASE-23040 give friendly message about unknown server when running unload for RegionMover. closes #635 Signed-off-by: stack (cherry picked from commit ab076b07313fe7b86a010eca38ac8db7de405969) --- .../src/main/java/org/apache/hadoop/hbase/util/RegionMover.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java index fdd079e..0107196 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java @@ -421,6 +421,12 @@ public class RegionMover extends AbstractHBaseTool implements Closeable { .keySet()); // Remove the host Region server from target Region Servers list ServerName server = stripServer(regionServers, hostname, port); + if (server == null) { + LOG.info("Could not find server '{}:{}' in the set of region servers. giving up.", + hostname, port); + LOG.debug("List of region servers: {}", regionServers); + return false; + } // Remove RS present in the exclude file stripExcludes(regionServers); stripMaster(regionServers);