hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhang...@apache.org
Subject hbase git commit: Revert "HBASE-20973 ArrayIndexOutOfBoundsException when rolling back procedure"
Date Fri, 26 Oct 2018 13:34:14 GMT
Repository: hbase
Updated Branches:
  refs/heads/branch-2.0 5191f0593 -> fcb31ad5d


Revert "HBASE-20973 ArrayIndexOutOfBoundsException when rolling back procedure"

This reverts commit a31e71564fd5c276cef7b8381e5285b8703eef13.


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/fcb31ad5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/fcb31ad5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/fcb31ad5

Branch: refs/heads/branch-2.0
Commit: fcb31ad5db565da0701964435441586f9fcd7bf8
Parents: 5191f05
Author: zhangduo <zhangduo@apache.org>
Authored: Fri Oct 26 21:28:43 2018 +0800
Committer: zhangduo <zhangduo@apache.org>
Committed: Fri Oct 26 21:34:02 2018 +0800

----------------------------------------------------------------------
 .../procedure2/store/ProcedureStoreTracker.java   | 18 ------------------
 1 file changed, 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/fcb31ad5/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java
b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java
index a0978e1..1930f8a 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java
@@ -376,24 +376,6 @@ public class ProcedureStoreTracker {
   }
 
   private BitSetNode getOrCreateNode(long procId) {
-    // See HBASE-20973, grow or merge can lead to ArrayIndexOutOfBoundsException
-    // The root cause is not revealed yet, disable grow or merge for now
-    return getOrCreateNodeNoGrowOrMerge(procId);
-  }
-
-  private BitSetNode getOrCreateNodeNoGrowOrMerge(long procId) {
-    Map.Entry<Long, BitSetNode> entry = map.floorEntry(procId);
-    if (entry != null && entry.getValue().contains(procId)) {
-      return entry.getValue();
-    } else {
-      BitSetNode node = new BitSetNode(procId, partial);
-      assert !map.containsKey(node.getStart());
-      map.put(node.getStart(), node);
-      return node;
-    }
-  }
-
-  private BitSetNode getOrCreateNodeWithGrowOrMerge(long procId) {
     // If procId can fit in left node (directly or by growing it)
     BitSetNode leftNode = null;
     boolean leftCanGrow = false;


Mime
View raw message