hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From git-site-r...@apache.org
Subject [22/51] [partial] hbase-site git commit: Published site at 3afe9fb7e6ebfa71187cbe131558a83fae61cecd.
Date Tue, 28 Aug 2018 14:48:22 GMT
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/424d7e41/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HStore.StoreFlusherImpl.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HStore.StoreFlusherImpl.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HStore.StoreFlusherImpl.html
index bd7445a..3504442 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HStore.StoreFlusherImpl.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HStore.StoreFlusherImpl.html
@@ -1720,459 +1720,459 @@
 <span class="sourceLineNo">1712</span>      LOG.error("Error trying to determine if store has references, assuming references exists",<a name="line.1712"></a>
 <span class="sourceLineNo">1713</span>        ioe);<a name="line.1713"></a>
 <span class="sourceLineNo">1714</span>      return true;<a name="line.1714"></a>
-<span class="sourceLineNo">1715</span>    }<a name="line.1715"></a>
-<span class="sourceLineNo">1716</span>  }<a name="line.1716"></a>
-<span class="sourceLineNo">1717</span><a name="line.1717"></a>
-<span class="sourceLineNo">1718</span>  /**<a name="line.1718"></a>
-<span class="sourceLineNo">1719</span>   * getter for CompactionProgress object<a name="line.1719"></a>
-<span class="sourceLineNo">1720</span>   * @return CompactionProgress object; can be null<a name="line.1720"></a>
-<span class="sourceLineNo">1721</span>   */<a name="line.1721"></a>
-<span class="sourceLineNo">1722</span>  public CompactionProgress getCompactionProgress() {<a name="line.1722"></a>
-<span class="sourceLineNo">1723</span>    return this.storeEngine.getCompactor().getProgress();<a name="line.1723"></a>
-<span class="sourceLineNo">1724</span>  }<a name="line.1724"></a>
-<span class="sourceLineNo">1725</span><a name="line.1725"></a>
-<span class="sourceLineNo">1726</span>  @Override<a name="line.1726"></a>
-<span class="sourceLineNo">1727</span>  public boolean shouldPerformMajorCompaction() throws IOException {<a name="line.1727"></a>
-<span class="sourceLineNo">1728</span>    for (HStoreFile sf : this.storeEngine.getStoreFileManager().getStorefiles()) {<a name="line.1728"></a>
-<span class="sourceLineNo">1729</span>      // TODO: what are these reader checks all over the place?<a name="line.1729"></a>
-<span class="sourceLineNo">1730</span>      if (sf.getReader() == null) {<a name="line.1730"></a>
-<span class="sourceLineNo">1731</span>        LOG.debug("StoreFile {} has null Reader", sf);<a name="line.1731"></a>
-<span class="sourceLineNo">1732</span>        return false;<a name="line.1732"></a>
-<span class="sourceLineNo">1733</span>      }<a name="line.1733"></a>
-<span class="sourceLineNo">1734</span>    }<a name="line.1734"></a>
-<span class="sourceLineNo">1735</span>    return storeEngine.getCompactionPolicy().shouldPerformMajorCompaction(<a name="line.1735"></a>
-<span class="sourceLineNo">1736</span>        this.storeEngine.getStoreFileManager().getStorefiles());<a name="line.1736"></a>
-<span class="sourceLineNo">1737</span>  }<a name="line.1737"></a>
-<span class="sourceLineNo">1738</span><a name="line.1738"></a>
-<span class="sourceLineNo">1739</span>  public Optional&lt;CompactionContext&gt; requestCompaction() throws IOException {<a name="line.1739"></a>
-<span class="sourceLineNo">1740</span>    return requestCompaction(NO_PRIORITY, CompactionLifeCycleTracker.DUMMY, null);<a name="line.1740"></a>
-<span class="sourceLineNo">1741</span>  }<a name="line.1741"></a>
-<span class="sourceLineNo">1742</span><a name="line.1742"></a>
-<span class="sourceLineNo">1743</span>  public Optional&lt;CompactionContext&gt; requestCompaction(int priority,<a name="line.1743"></a>
-<span class="sourceLineNo">1744</span>      CompactionLifeCycleTracker tracker, User user) throws IOException {<a name="line.1744"></a>
-<span class="sourceLineNo">1745</span>    // don't even select for compaction if writes are disabled<a name="line.1745"></a>
-<span class="sourceLineNo">1746</span>    if (!this.areWritesEnabled()) {<a name="line.1746"></a>
-<span class="sourceLineNo">1747</span>      return Optional.empty();<a name="line.1747"></a>
-<span class="sourceLineNo">1748</span>    }<a name="line.1748"></a>
-<span class="sourceLineNo">1749</span>    // Before we do compaction, try to get rid of unneeded files to simplify things.<a name="line.1749"></a>
-<span class="sourceLineNo">1750</span>    removeUnneededFiles();<a name="line.1750"></a>
-<span class="sourceLineNo">1751</span><a name="line.1751"></a>
-<span class="sourceLineNo">1752</span>    final CompactionContext compaction = storeEngine.createCompaction();<a name="line.1752"></a>
-<span class="sourceLineNo">1753</span>    CompactionRequestImpl request = null;<a name="line.1753"></a>
-<span class="sourceLineNo">1754</span>    this.lock.readLock().lock();<a name="line.1754"></a>
-<span class="sourceLineNo">1755</span>    try {<a name="line.1755"></a>
-<span class="sourceLineNo">1756</span>      synchronized (filesCompacting) {<a name="line.1756"></a>
-<span class="sourceLineNo">1757</span>        // First, see if coprocessor would want to override selection.<a name="line.1757"></a>
-<span class="sourceLineNo">1758</span>        if (this.getCoprocessorHost() != null) {<a name="line.1758"></a>
-<span class="sourceLineNo">1759</span>          final List&lt;HStoreFile&gt; candidatesForCoproc = compaction.preSelect(this.filesCompacting);<a name="line.1759"></a>
-<span class="sourceLineNo">1760</span>          boolean override = getCoprocessorHost().preCompactSelection(this,<a name="line.1760"></a>
-<span class="sourceLineNo">1761</span>              candidatesForCoproc, tracker, user);<a name="line.1761"></a>
-<span class="sourceLineNo">1762</span>          if (override) {<a name="line.1762"></a>
-<span class="sourceLineNo">1763</span>            // Coprocessor is overriding normal file selection.<a name="line.1763"></a>
-<span class="sourceLineNo">1764</span>            compaction.forceSelect(new CompactionRequestImpl(candidatesForCoproc));<a name="line.1764"></a>
-<span class="sourceLineNo">1765</span>          }<a name="line.1765"></a>
-<span class="sourceLineNo">1766</span>        }<a name="line.1766"></a>
-<span class="sourceLineNo">1767</span><a name="line.1767"></a>
-<span class="sourceLineNo">1768</span>        // Normal case - coprocessor is not overriding file selection.<a name="line.1768"></a>
-<span class="sourceLineNo">1769</span>        if (!compaction.hasSelection()) {<a name="line.1769"></a>
-<span class="sourceLineNo">1770</span>          boolean isUserCompaction = priority == Store.PRIORITY_USER;<a name="line.1770"></a>
-<span class="sourceLineNo">1771</span>          boolean mayUseOffPeak = offPeakHours.isOffPeakHour() &amp;&amp;<a name="line.1771"></a>
-<span class="sourceLineNo">1772</span>              offPeakCompactionTracker.compareAndSet(false, true);<a name="line.1772"></a>
-<span class="sourceLineNo">1773</span>          try {<a name="line.1773"></a>
-<span class="sourceLineNo">1774</span>            compaction.select(this.filesCompacting, isUserCompaction,<a name="line.1774"></a>
-<span class="sourceLineNo">1775</span>              mayUseOffPeak, forceMajor &amp;&amp; filesCompacting.isEmpty());<a name="line.1775"></a>
-<span class="sourceLineNo">1776</span>          } catch (IOException e) {<a name="line.1776"></a>
-<span class="sourceLineNo">1777</span>            if (mayUseOffPeak) {<a name="line.1777"></a>
-<span class="sourceLineNo">1778</span>              offPeakCompactionTracker.set(false);<a name="line.1778"></a>
-<span class="sourceLineNo">1779</span>            }<a name="line.1779"></a>
-<span class="sourceLineNo">1780</span>            throw e;<a name="line.1780"></a>
-<span class="sourceLineNo">1781</span>          }<a name="line.1781"></a>
-<span class="sourceLineNo">1782</span>          assert compaction.hasSelection();<a name="line.1782"></a>
-<span class="sourceLineNo">1783</span>          if (mayUseOffPeak &amp;&amp; !compaction.getRequest().isOffPeak()) {<a name="line.1783"></a>
-<span class="sourceLineNo">1784</span>            // Compaction policy doesn't want to take advantage of off-peak.<a name="line.1784"></a>
-<span class="sourceLineNo">1785</span>            offPeakCompactionTracker.set(false);<a name="line.1785"></a>
-<span class="sourceLineNo">1786</span>          }<a name="line.1786"></a>
-<span class="sourceLineNo">1787</span>        }<a name="line.1787"></a>
-<span class="sourceLineNo">1788</span>        if (this.getCoprocessorHost() != null) {<a name="line.1788"></a>
-<span class="sourceLineNo">1789</span>          this.getCoprocessorHost().postCompactSelection(<a name="line.1789"></a>
-<span class="sourceLineNo">1790</span>              this, ImmutableList.copyOf(compaction.getRequest().getFiles()), tracker,<a name="line.1790"></a>
-<span class="sourceLineNo">1791</span>              compaction.getRequest(), user);<a name="line.1791"></a>
-<span class="sourceLineNo">1792</span>        }<a name="line.1792"></a>
-<span class="sourceLineNo">1793</span>        // Finally, we have the resulting files list. Check if we have any files at all.<a name="line.1793"></a>
-<span class="sourceLineNo">1794</span>        request = compaction.getRequest();<a name="line.1794"></a>
-<span class="sourceLineNo">1795</span>        Collection&lt;HStoreFile&gt; selectedFiles = request.getFiles();<a name="line.1795"></a>
-<span class="sourceLineNo">1796</span>        if (selectedFiles.isEmpty()) {<a name="line.1796"></a>
-<span class="sourceLineNo">1797</span>          return Optional.empty();<a name="line.1797"></a>
+<span class="sourceLineNo">1715</span>    } finally {<a name="line.1715"></a>
+<span class="sourceLineNo">1716</span>      if (reloadedStoreFiles != null) {<a name="line.1716"></a>
+<span class="sourceLineNo">1717</span>        for (HStoreFile storeFile : reloadedStoreFiles) {<a name="line.1717"></a>
+<span class="sourceLineNo">1718</span>          try {<a name="line.1718"></a>
+<span class="sourceLineNo">1719</span>            storeFile.closeStoreFile(false);<a name="line.1719"></a>
+<span class="sourceLineNo">1720</span>          } catch (IOException ioe) {<a name="line.1720"></a>
+<span class="sourceLineNo">1721</span>            LOG.warn("Encountered exception closing " + storeFile + ": " + ioe.getMessage());<a name="line.1721"></a>
+<span class="sourceLineNo">1722</span>            // continue with closing the remaining store files<a name="line.1722"></a>
+<span class="sourceLineNo">1723</span>          }<a name="line.1723"></a>
+<span class="sourceLineNo">1724</span>        }<a name="line.1724"></a>
+<span class="sourceLineNo">1725</span>      }<a name="line.1725"></a>
+<span class="sourceLineNo">1726</span>    }<a name="line.1726"></a>
+<span class="sourceLineNo">1727</span>  }<a name="line.1727"></a>
+<span class="sourceLineNo">1728</span><a name="line.1728"></a>
+<span class="sourceLineNo">1729</span>  /**<a name="line.1729"></a>
+<span class="sourceLineNo">1730</span>   * getter for CompactionProgress object<a name="line.1730"></a>
+<span class="sourceLineNo">1731</span>   * @return CompactionProgress object; can be null<a name="line.1731"></a>
+<span class="sourceLineNo">1732</span>   */<a name="line.1732"></a>
+<span class="sourceLineNo">1733</span>  public CompactionProgress getCompactionProgress() {<a name="line.1733"></a>
+<span class="sourceLineNo">1734</span>    return this.storeEngine.getCompactor().getProgress();<a name="line.1734"></a>
+<span class="sourceLineNo">1735</span>  }<a name="line.1735"></a>
+<span class="sourceLineNo">1736</span><a name="line.1736"></a>
+<span class="sourceLineNo">1737</span>  @Override<a name="line.1737"></a>
+<span class="sourceLineNo">1738</span>  public boolean shouldPerformMajorCompaction() throws IOException {<a name="line.1738"></a>
+<span class="sourceLineNo">1739</span>    for (HStoreFile sf : this.storeEngine.getStoreFileManager().getStorefiles()) {<a name="line.1739"></a>
+<span class="sourceLineNo">1740</span>      // TODO: what are these reader checks all over the place?<a name="line.1740"></a>
+<span class="sourceLineNo">1741</span>      if (sf.getReader() == null) {<a name="line.1741"></a>
+<span class="sourceLineNo">1742</span>        LOG.debug("StoreFile {} has null Reader", sf);<a name="line.1742"></a>
+<span class="sourceLineNo">1743</span>        return false;<a name="line.1743"></a>
+<span class="sourceLineNo">1744</span>      }<a name="line.1744"></a>
+<span class="sourceLineNo">1745</span>    }<a name="line.1745"></a>
+<span class="sourceLineNo">1746</span>    return storeEngine.getCompactionPolicy().shouldPerformMajorCompaction(<a name="line.1746"></a>
+<span class="sourceLineNo">1747</span>        this.storeEngine.getStoreFileManager().getStorefiles());<a name="line.1747"></a>
+<span class="sourceLineNo">1748</span>  }<a name="line.1748"></a>
+<span class="sourceLineNo">1749</span><a name="line.1749"></a>
+<span class="sourceLineNo">1750</span>  public Optional&lt;CompactionContext&gt; requestCompaction() throws IOException {<a name="line.1750"></a>
+<span class="sourceLineNo">1751</span>    return requestCompaction(NO_PRIORITY, CompactionLifeCycleTracker.DUMMY, null);<a name="line.1751"></a>
+<span class="sourceLineNo">1752</span>  }<a name="line.1752"></a>
+<span class="sourceLineNo">1753</span><a name="line.1753"></a>
+<span class="sourceLineNo">1754</span>  public Optional&lt;CompactionContext&gt; requestCompaction(int priority,<a name="line.1754"></a>
+<span class="sourceLineNo">1755</span>      CompactionLifeCycleTracker tracker, User user) throws IOException {<a name="line.1755"></a>
+<span class="sourceLineNo">1756</span>    // don't even select for compaction if writes are disabled<a name="line.1756"></a>
+<span class="sourceLineNo">1757</span>    if (!this.areWritesEnabled()) {<a name="line.1757"></a>
+<span class="sourceLineNo">1758</span>      return Optional.empty();<a name="line.1758"></a>
+<span class="sourceLineNo">1759</span>    }<a name="line.1759"></a>
+<span class="sourceLineNo">1760</span>    // Before we do compaction, try to get rid of unneeded files to simplify things.<a name="line.1760"></a>
+<span class="sourceLineNo">1761</span>    removeUnneededFiles();<a name="line.1761"></a>
+<span class="sourceLineNo">1762</span><a name="line.1762"></a>
+<span class="sourceLineNo">1763</span>    final CompactionContext compaction = storeEngine.createCompaction();<a name="line.1763"></a>
+<span class="sourceLineNo">1764</span>    CompactionRequestImpl request = null;<a name="line.1764"></a>
+<span class="sourceLineNo">1765</span>    this.lock.readLock().lock();<a name="line.1765"></a>
+<span class="sourceLineNo">1766</span>    try {<a name="line.1766"></a>
+<span class="sourceLineNo">1767</span>      synchronized (filesCompacting) {<a name="line.1767"></a>
+<span class="sourceLineNo">1768</span>        // First, see if coprocessor would want to override selection.<a name="line.1768"></a>
+<span class="sourceLineNo">1769</span>        if (this.getCoprocessorHost() != null) {<a name="line.1769"></a>
+<span class="sourceLineNo">1770</span>          final List&lt;HStoreFile&gt; candidatesForCoproc = compaction.preSelect(this.filesCompacting);<a name="line.1770"></a>
+<span class="sourceLineNo">1771</span>          boolean override = getCoprocessorHost().preCompactSelection(this,<a name="line.1771"></a>
+<span class="sourceLineNo">1772</span>              candidatesForCoproc, tracker, user);<a name="line.1772"></a>
+<span class="sourceLineNo">1773</span>          if (override) {<a name="line.1773"></a>
+<span class="sourceLineNo">1774</span>            // Coprocessor is overriding normal file selection.<a name="line.1774"></a>
+<span class="sourceLineNo">1775</span>            compaction.forceSelect(new CompactionRequestImpl(candidatesForCoproc));<a name="line.1775"></a>
+<span class="sourceLineNo">1776</span>          }<a name="line.1776"></a>
+<span class="sourceLineNo">1777</span>        }<a name="line.1777"></a>
+<span class="sourceLineNo">1778</span><a name="line.1778"></a>
+<span class="sourceLineNo">1779</span>        // Normal case - coprocessor is not overriding file selection.<a name="line.1779"></a>
+<span class="sourceLineNo">1780</span>        if (!compaction.hasSelection()) {<a name="line.1780"></a>
+<span class="sourceLineNo">1781</span>          boolean isUserCompaction = priority == Store.PRIORITY_USER;<a name="line.1781"></a>
+<span class="sourceLineNo">1782</span>          boolean mayUseOffPeak = offPeakHours.isOffPeakHour() &amp;&amp;<a name="line.1782"></a>
+<span class="sourceLineNo">1783</span>              offPeakCompactionTracker.compareAndSet(false, true);<a name="line.1783"></a>
+<span class="sourceLineNo">1784</span>          try {<a name="line.1784"></a>
+<span class="sourceLineNo">1785</span>            compaction.select(this.filesCompacting, isUserCompaction,<a name="line.1785"></a>
+<span class="sourceLineNo">1786</span>              mayUseOffPeak, forceMajor &amp;&amp; filesCompacting.isEmpty());<a name="line.1786"></a>
+<span class="sourceLineNo">1787</span>          } catch (IOException e) {<a name="line.1787"></a>
+<span class="sourceLineNo">1788</span>            if (mayUseOffPeak) {<a name="line.1788"></a>
+<span class="sourceLineNo">1789</span>              offPeakCompactionTracker.set(false);<a name="line.1789"></a>
+<span class="sourceLineNo">1790</span>            }<a name="line.1790"></a>
+<span class="sourceLineNo">1791</span>            throw e;<a name="line.1791"></a>
+<span class="sourceLineNo">1792</span>          }<a name="line.1792"></a>
+<span class="sourceLineNo">1793</span>          assert compaction.hasSelection();<a name="line.1793"></a>
+<span class="sourceLineNo">1794</span>          if (mayUseOffPeak &amp;&amp; !compaction.getRequest().isOffPeak()) {<a name="line.1794"></a>
+<span class="sourceLineNo">1795</span>            // Compaction policy doesn't want to take advantage of off-peak.<a name="line.1795"></a>
+<span class="sourceLineNo">1796</span>            offPeakCompactionTracker.set(false);<a name="line.1796"></a>
+<span class="sourceLineNo">1797</span>          }<a name="line.1797"></a>
 <span class="sourceLineNo">1798</span>        }<a name="line.1798"></a>
-<span class="sourceLineNo">1799</span><a name="line.1799"></a>
-<span class="sourceLineNo">1800</span>        addToCompactingFiles(selectedFiles);<a name="line.1800"></a>
-<span class="sourceLineNo">1801</span><a name="line.1801"></a>
-<span class="sourceLineNo">1802</span>        // If we're enqueuing a major, clear the force flag.<a name="line.1802"></a>
-<span class="sourceLineNo">1803</span>        this.forceMajor = this.forceMajor &amp;&amp; !request.isMajor();<a name="line.1803"></a>
-<span class="sourceLineNo">1804</span><a name="line.1804"></a>
-<span class="sourceLineNo">1805</span>        // Set common request properties.<a name="line.1805"></a>
-<span class="sourceLineNo">1806</span>        // Set priority, either override value supplied by caller or from store.<a name="line.1806"></a>
-<span class="sourceLineNo">1807</span>        request.setPriority((priority != Store.NO_PRIORITY) ? priority : getCompactPriority());<a name="line.1807"></a>
-<span class="sourceLineNo">1808</span>        request.setDescription(getRegionInfo().getRegionNameAsString(), getColumnFamilyName());<a name="line.1808"></a>
-<span class="sourceLineNo">1809</span>        request.setTracker(tracker);<a name="line.1809"></a>
-<span class="sourceLineNo">1810</span>      }<a name="line.1810"></a>
-<span class="sourceLineNo">1811</span>    } finally {<a name="line.1811"></a>
-<span class="sourceLineNo">1812</span>      this.lock.readLock().unlock();<a name="line.1812"></a>
-<span class="sourceLineNo">1813</span>    }<a name="line.1813"></a>
-<span class="sourceLineNo">1814</span><a name="line.1814"></a>
-<span class="sourceLineNo">1815</span>    if (LOG.isDebugEnabled()) {<a name="line.1815"></a>
-<span class="sourceLineNo">1816</span>      LOG.debug(getRegionInfo().getEncodedName() + " - " + getColumnFamilyName()<a name="line.1816"></a>
-<span class="sourceLineNo">1817</span>          + ": Initiating " + (request.isMajor() ? "major" : "minor") + " compaction"<a name="line.1817"></a>
-<span class="sourceLineNo">1818</span>          + (request.isAllFiles() ? " (all files)" : ""));<a name="line.1818"></a>
-<span class="sourceLineNo">1819</span>    }<a name="line.1819"></a>
-<span class="sourceLineNo">1820</span>    this.region.reportCompactionRequestStart(request.isMajor());<a name="line.1820"></a>
-<span class="sourceLineNo">1821</span>    return Optional.of(compaction);<a name="line.1821"></a>
-<span class="sourceLineNo">1822</span>  }<a name="line.1822"></a>
-<span class="sourceLineNo">1823</span><a name="line.1823"></a>
-<span class="sourceLineNo">1824</span>  /** Adds the files to compacting files. filesCompacting must be locked. */<a name="line.1824"></a>
-<span class="sourceLineNo">1825</span>  private void addToCompactingFiles(Collection&lt;HStoreFile&gt; filesToAdd) {<a name="line.1825"></a>
-<span class="sourceLineNo">1826</span>    if (CollectionUtils.isEmpty(filesToAdd)) {<a name="line.1826"></a>
-<span class="sourceLineNo">1827</span>      return;<a name="line.1827"></a>
-<span class="sourceLineNo">1828</span>    }<a name="line.1828"></a>
-<span class="sourceLineNo">1829</span>    // Check that we do not try to compact the same StoreFile twice.<a name="line.1829"></a>
-<span class="sourceLineNo">1830</span>    if (!Collections.disjoint(filesCompacting, filesToAdd)) {<a name="line.1830"></a>
-<span class="sourceLineNo">1831</span>      Preconditions.checkArgument(false, "%s overlaps with %s", filesToAdd, filesCompacting);<a name="line.1831"></a>
-<span class="sourceLineNo">1832</span>    }<a name="line.1832"></a>
-<span class="sourceLineNo">1833</span>    filesCompacting.addAll(filesToAdd);<a name="line.1833"></a>
-<span class="sourceLineNo">1834</span>    Collections.sort(filesCompacting, storeEngine.getStoreFileManager().getStoreFileComparator());<a name="line.1834"></a>
-<span class="sourceLineNo">1835</span>  }<a name="line.1835"></a>
-<span class="sourceLineNo">1836</span><a name="line.1836"></a>
-<span class="sourceLineNo">1837</span>  private void removeUnneededFiles() throws IOException {<a name="line.1837"></a>
-<span class="sourceLineNo">1838</span>    if (!conf.getBoolean("hbase.store.delete.expired.storefile", true)) return;<a name="line.1838"></a>
-<span class="sourceLineNo">1839</span>    if (getColumnFamilyDescriptor().getMinVersions() &gt; 0) {<a name="line.1839"></a>
-<span class="sourceLineNo">1840</span>      LOG.debug("Skipping expired store file removal due to min version being {}",<a name="line.1840"></a>
-<span class="sourceLineNo">1841</span>          getColumnFamilyDescriptor().getMinVersions());<a name="line.1841"></a>
-<span class="sourceLineNo">1842</span>      return;<a name="line.1842"></a>
+<span class="sourceLineNo">1799</span>        if (this.getCoprocessorHost() != null) {<a name="line.1799"></a>
+<span class="sourceLineNo">1800</span>          this.getCoprocessorHost().postCompactSelection(<a name="line.1800"></a>
+<span class="sourceLineNo">1801</span>              this, ImmutableList.copyOf(compaction.getRequest().getFiles()), tracker,<a name="line.1801"></a>
+<span class="sourceLineNo">1802</span>              compaction.getRequest(), user);<a name="line.1802"></a>
+<span class="sourceLineNo">1803</span>        }<a name="line.1803"></a>
+<span class="sourceLineNo">1804</span>        // Finally, we have the resulting files list. Check if we have any files at all.<a name="line.1804"></a>
+<span class="sourceLineNo">1805</span>        request = compaction.getRequest();<a name="line.1805"></a>
+<span class="sourceLineNo">1806</span>        Collection&lt;HStoreFile&gt; selectedFiles = request.getFiles();<a name="line.1806"></a>
+<span class="sourceLineNo">1807</span>        if (selectedFiles.isEmpty()) {<a name="line.1807"></a>
+<span class="sourceLineNo">1808</span>          return Optional.empty();<a name="line.1808"></a>
+<span class="sourceLineNo">1809</span>        }<a name="line.1809"></a>
+<span class="sourceLineNo">1810</span><a name="line.1810"></a>
+<span class="sourceLineNo">1811</span>        addToCompactingFiles(selectedFiles);<a name="line.1811"></a>
+<span class="sourceLineNo">1812</span><a name="line.1812"></a>
+<span class="sourceLineNo">1813</span>        // If we're enqueuing a major, clear the force flag.<a name="line.1813"></a>
+<span class="sourceLineNo">1814</span>        this.forceMajor = this.forceMajor &amp;&amp; !request.isMajor();<a name="line.1814"></a>
+<span class="sourceLineNo">1815</span><a name="line.1815"></a>
+<span class="sourceLineNo">1816</span>        // Set common request properties.<a name="line.1816"></a>
+<span class="sourceLineNo">1817</span>        // Set priority, either override value supplied by caller or from store.<a name="line.1817"></a>
+<span class="sourceLineNo">1818</span>        request.setPriority((priority != Store.NO_PRIORITY) ? priority : getCompactPriority());<a name="line.1818"></a>
+<span class="sourceLineNo">1819</span>        request.setDescription(getRegionInfo().getRegionNameAsString(), getColumnFamilyName());<a name="line.1819"></a>
+<span class="sourceLineNo">1820</span>        request.setTracker(tracker);<a name="line.1820"></a>
+<span class="sourceLineNo">1821</span>      }<a name="line.1821"></a>
+<span class="sourceLineNo">1822</span>    } finally {<a name="line.1822"></a>
+<span class="sourceLineNo">1823</span>      this.lock.readLock().unlock();<a name="line.1823"></a>
+<span class="sourceLineNo">1824</span>    }<a name="line.1824"></a>
+<span class="sourceLineNo">1825</span><a name="line.1825"></a>
+<span class="sourceLineNo">1826</span>    if (LOG.isDebugEnabled()) {<a name="line.1826"></a>
+<span class="sourceLineNo">1827</span>      LOG.debug(getRegionInfo().getEncodedName() + " - " + getColumnFamilyName()<a name="line.1827"></a>
+<span class="sourceLineNo">1828</span>          + ": Initiating " + (request.isMajor() ? "major" : "minor") + " compaction"<a name="line.1828"></a>
+<span class="sourceLineNo">1829</span>          + (request.isAllFiles() ? " (all files)" : ""));<a name="line.1829"></a>
+<span class="sourceLineNo">1830</span>    }<a name="line.1830"></a>
+<span class="sourceLineNo">1831</span>    this.region.reportCompactionRequestStart(request.isMajor());<a name="line.1831"></a>
+<span class="sourceLineNo">1832</span>    return Optional.of(compaction);<a name="line.1832"></a>
+<span class="sourceLineNo">1833</span>  }<a name="line.1833"></a>
+<span class="sourceLineNo">1834</span><a name="line.1834"></a>
+<span class="sourceLineNo">1835</span>  /** Adds the files to compacting files. filesCompacting must be locked. */<a name="line.1835"></a>
+<span class="sourceLineNo">1836</span>  private void addToCompactingFiles(Collection&lt;HStoreFile&gt; filesToAdd) {<a name="line.1836"></a>
+<span class="sourceLineNo">1837</span>    if (CollectionUtils.isEmpty(filesToAdd)) {<a name="line.1837"></a>
+<span class="sourceLineNo">1838</span>      return;<a name="line.1838"></a>
+<span class="sourceLineNo">1839</span>    }<a name="line.1839"></a>
+<span class="sourceLineNo">1840</span>    // Check that we do not try to compact the same StoreFile twice.<a name="line.1840"></a>
+<span class="sourceLineNo">1841</span>    if (!Collections.disjoint(filesCompacting, filesToAdd)) {<a name="line.1841"></a>
+<span class="sourceLineNo">1842</span>      Preconditions.checkArgument(false, "%s overlaps with %s", filesToAdd, filesCompacting);<a name="line.1842"></a>
 <span class="sourceLineNo">1843</span>    }<a name="line.1843"></a>
-<span class="sourceLineNo">1844</span>    this.lock.readLock().lock();<a name="line.1844"></a>
-<span class="sourceLineNo">1845</span>    Collection&lt;HStoreFile&gt; delSfs = null;<a name="line.1845"></a>
-<span class="sourceLineNo">1846</span>    try {<a name="line.1846"></a>
-<span class="sourceLineNo">1847</span>      synchronized (filesCompacting) {<a name="line.1847"></a>
-<span class="sourceLineNo">1848</span>        long cfTtl = getStoreFileTtl();<a name="line.1848"></a>
-<span class="sourceLineNo">1849</span>        if (cfTtl != Long.MAX_VALUE) {<a name="line.1849"></a>
-<span class="sourceLineNo">1850</span>          delSfs = storeEngine.getStoreFileManager().getUnneededFiles(<a name="line.1850"></a>
-<span class="sourceLineNo">1851</span>              EnvironmentEdgeManager.currentTime() - cfTtl, filesCompacting);<a name="line.1851"></a>
-<span class="sourceLineNo">1852</span>          addToCompactingFiles(delSfs);<a name="line.1852"></a>
-<span class="sourceLineNo">1853</span>        }<a name="line.1853"></a>
-<span class="sourceLineNo">1854</span>      }<a name="line.1854"></a>
-<span class="sourceLineNo">1855</span>    } finally {<a name="line.1855"></a>
-<span class="sourceLineNo">1856</span>      this.lock.readLock().unlock();<a name="line.1856"></a>
-<span class="sourceLineNo">1857</span>    }<a name="line.1857"></a>
-<span class="sourceLineNo">1858</span><a name="line.1858"></a>
-<span class="sourceLineNo">1859</span>    if (CollectionUtils.isEmpty(delSfs)) {<a name="line.1859"></a>
-<span class="sourceLineNo">1860</span>      return;<a name="line.1860"></a>
-<span class="sourceLineNo">1861</span>    }<a name="line.1861"></a>
-<span class="sourceLineNo">1862</span><a name="line.1862"></a>
-<span class="sourceLineNo">1863</span>    Collection&lt;HStoreFile&gt; newFiles = Collections.emptyList(); // No new files.<a name="line.1863"></a>
-<span class="sourceLineNo">1864</span>    writeCompactionWalRecord(delSfs, newFiles);<a name="line.1864"></a>
-<span class="sourceLineNo">1865</span>    replaceStoreFiles(delSfs, newFiles);<a name="line.1865"></a>
-<span class="sourceLineNo">1866</span>    completeCompaction(delSfs);<a name="line.1866"></a>
-<span class="sourceLineNo">1867</span>    LOG.info("Completed removal of " + delSfs.size() + " unnecessary (expired) file(s) in "<a name="line.1867"></a>
-<span class="sourceLineNo">1868</span>        + this + " of " + this.getRegionInfo().getRegionNameAsString()<a name="line.1868"></a>
-<span class="sourceLineNo">1869</span>        + "; total size for store is "<a name="line.1869"></a>
-<span class="sourceLineNo">1870</span>        + TraditionalBinaryPrefix.long2String(storeSize.get(), "", 1));<a name="line.1870"></a>
-<span class="sourceLineNo">1871</span>  }<a name="line.1871"></a>
-<span class="sourceLineNo">1872</span><a name="line.1872"></a>
-<span class="sourceLineNo">1873</span>  public void cancelRequestedCompaction(CompactionContext compaction) {<a name="line.1873"></a>
-<span class="sourceLineNo">1874</span>    finishCompactionRequest(compaction.getRequest());<a name="line.1874"></a>
-<span class="sourceLineNo">1875</span>  }<a name="line.1875"></a>
-<span class="sourceLineNo">1876</span><a name="line.1876"></a>
-<span class="sourceLineNo">1877</span>  private void finishCompactionRequest(CompactionRequestImpl cr) {<a name="line.1877"></a>
-<span class="sourceLineNo">1878</span>    this.region.reportCompactionRequestEnd(cr.isMajor(), cr.getFiles().size(), cr.getSize());<a name="line.1878"></a>
-<span class="sourceLineNo">1879</span>    if (cr.isOffPeak()) {<a name="line.1879"></a>
-<span class="sourceLineNo">1880</span>      offPeakCompactionTracker.set(false);<a name="line.1880"></a>
-<span class="sourceLineNo">1881</span>      cr.setOffPeak(false);<a name="line.1881"></a>
-<span class="sourceLineNo">1882</span>    }<a name="line.1882"></a>
-<span class="sourceLineNo">1883</span>    synchronized (filesCompacting) {<a name="line.1883"></a>
-<span class="sourceLineNo">1884</span>      filesCompacting.removeAll(cr.getFiles());<a name="line.1884"></a>
-<span class="sourceLineNo">1885</span>    }<a name="line.1885"></a>
+<span class="sourceLineNo">1844</span>    filesCompacting.addAll(filesToAdd);<a name="line.1844"></a>
+<span class="sourceLineNo">1845</span>    Collections.sort(filesCompacting, storeEngine.getStoreFileManager().getStoreFileComparator());<a name="line.1845"></a>
+<span class="sourceLineNo">1846</span>  }<a name="line.1846"></a>
+<span class="sourceLineNo">1847</span><a name="line.1847"></a>
+<span class="sourceLineNo">1848</span>  private void removeUnneededFiles() throws IOException {<a name="line.1848"></a>
+<span class="sourceLineNo">1849</span>    if (!conf.getBoolean("hbase.store.delete.expired.storefile", true)) return;<a name="line.1849"></a>
+<span class="sourceLineNo">1850</span>    if (getColumnFamilyDescriptor().getMinVersions() &gt; 0) {<a name="line.1850"></a>
+<span class="sourceLineNo">1851</span>      LOG.debug("Skipping expired store file removal due to min version being {}",<a name="line.1851"></a>
+<span class="sourceLineNo">1852</span>          getColumnFamilyDescriptor().getMinVersions());<a name="line.1852"></a>
+<span class="sourceLineNo">1853</span>      return;<a name="line.1853"></a>
+<span class="sourceLineNo">1854</span>    }<a name="line.1854"></a>
+<span class="sourceLineNo">1855</span>    this.lock.readLock().lock();<a name="line.1855"></a>
+<span class="sourceLineNo">1856</span>    Collection&lt;HStoreFile&gt; delSfs = null;<a name="line.1856"></a>
+<span class="sourceLineNo">1857</span>    try {<a name="line.1857"></a>
+<span class="sourceLineNo">1858</span>      synchronized (filesCompacting) {<a name="line.1858"></a>
+<span class="sourceLineNo">1859</span>        long cfTtl = getStoreFileTtl();<a name="line.1859"></a>
+<span class="sourceLineNo">1860</span>        if (cfTtl != Long.MAX_VALUE) {<a name="line.1860"></a>
+<span class="sourceLineNo">1861</span>          delSfs = storeEngine.getStoreFileManager().getUnneededFiles(<a name="line.1861"></a>
+<span class="sourceLineNo">1862</span>              EnvironmentEdgeManager.currentTime() - cfTtl, filesCompacting);<a name="line.1862"></a>
+<span class="sourceLineNo">1863</span>          addToCompactingFiles(delSfs);<a name="line.1863"></a>
+<span class="sourceLineNo">1864</span>        }<a name="line.1864"></a>
+<span class="sourceLineNo">1865</span>      }<a name="line.1865"></a>
+<span class="sourceLineNo">1866</span>    } finally {<a name="line.1866"></a>
+<span class="sourceLineNo">1867</span>      this.lock.readLock().unlock();<a name="line.1867"></a>
+<span class="sourceLineNo">1868</span>    }<a name="line.1868"></a>
+<span class="sourceLineNo">1869</span><a name="line.1869"></a>
+<span class="sourceLineNo">1870</span>    if (CollectionUtils.isEmpty(delSfs)) {<a name="line.1870"></a>
+<span class="sourceLineNo">1871</span>      return;<a name="line.1871"></a>
+<span class="sourceLineNo">1872</span>    }<a name="line.1872"></a>
+<span class="sourceLineNo">1873</span><a name="line.1873"></a>
+<span class="sourceLineNo">1874</span>    Collection&lt;HStoreFile&gt; newFiles = Collections.emptyList(); // No new files.<a name="line.1874"></a>
+<span class="sourceLineNo">1875</span>    writeCompactionWalRecord(delSfs, newFiles);<a name="line.1875"></a>
+<span class="sourceLineNo">1876</span>    replaceStoreFiles(delSfs, newFiles);<a name="line.1876"></a>
+<span class="sourceLineNo">1877</span>    completeCompaction(delSfs);<a name="line.1877"></a>
+<span class="sourceLineNo">1878</span>    LOG.info("Completed removal of " + delSfs.size() + " unnecessary (expired) file(s) in "<a name="line.1878"></a>
+<span class="sourceLineNo">1879</span>        + this + " of " + this.getRegionInfo().getRegionNameAsString()<a name="line.1879"></a>
+<span class="sourceLineNo">1880</span>        + "; total size for store is "<a name="line.1880"></a>
+<span class="sourceLineNo">1881</span>        + TraditionalBinaryPrefix.long2String(storeSize.get(), "", 1));<a name="line.1881"></a>
+<span class="sourceLineNo">1882</span>  }<a name="line.1882"></a>
+<span class="sourceLineNo">1883</span><a name="line.1883"></a>
+<span class="sourceLineNo">1884</span>  public void cancelRequestedCompaction(CompactionContext compaction) {<a name="line.1884"></a>
+<span class="sourceLineNo">1885</span>    finishCompactionRequest(compaction.getRequest());<a name="line.1885"></a>
 <span class="sourceLineNo">1886</span>  }<a name="line.1886"></a>
 <span class="sourceLineNo">1887</span><a name="line.1887"></a>
-<span class="sourceLineNo">1888</span>  /**<a name="line.1888"></a>
-<span class="sourceLineNo">1889</span>   * Validates a store file by opening and closing it. In HFileV2 this should not be an expensive<a name="line.1889"></a>
-<span class="sourceLineNo">1890</span>   * operation.<a name="line.1890"></a>
-<span class="sourceLineNo">1891</span>   * @param path the path to the store file<a name="line.1891"></a>
-<span class="sourceLineNo">1892</span>   */<a name="line.1892"></a>
-<span class="sourceLineNo">1893</span>  private void validateStoreFile(Path path) throws IOException {<a name="line.1893"></a>
-<span class="sourceLineNo">1894</span>    HStoreFile storeFile = null;<a name="line.1894"></a>
-<span class="sourceLineNo">1895</span>    try {<a name="line.1895"></a>
-<span class="sourceLineNo">1896</span>      storeFile = createStoreFileAndReader(path);<a name="line.1896"></a>
-<span class="sourceLineNo">1897</span>    } catch (IOException e) {<a name="line.1897"></a>
-<span class="sourceLineNo">1898</span>      LOG.error("Failed to open store file : {}, keeping it in tmp location", path, e);<a name="line.1898"></a>
-<span class="sourceLineNo">1899</span>      throw e;<a name="line.1899"></a>
-<span class="sourceLineNo">1900</span>    } finally {<a name="line.1900"></a>
-<span class="sourceLineNo">1901</span>      if (storeFile != null) {<a name="line.1901"></a>
-<span class="sourceLineNo">1902</span>        storeFile.closeStoreFile(false);<a name="line.1902"></a>
-<span class="sourceLineNo">1903</span>      }<a name="line.1903"></a>
-<span class="sourceLineNo">1904</span>    }<a name="line.1904"></a>
-<span class="sourceLineNo">1905</span>  }<a name="line.1905"></a>
-<span class="sourceLineNo">1906</span><a name="line.1906"></a>
-<span class="sourceLineNo">1907</span>  /**<a name="line.1907"></a>
-<span class="sourceLineNo">1908</span>   * &lt;p&gt;It works by processing a compaction that's been written to disk.<a name="line.1908"></a>
-<span class="sourceLineNo">1909</span>   *<a name="line.1909"></a>
-<span class="sourceLineNo">1910</span>   * &lt;p&gt;It is usually invoked at the end of a compaction, but might also be<a name="line.1910"></a>
-<span class="sourceLineNo">1911</span>   * invoked at HStore startup, if the prior execution died midway through.<a name="line.1911"></a>
-<span class="sourceLineNo">1912</span>   *<a name="line.1912"></a>
-<span class="sourceLineNo">1913</span>   * &lt;p&gt;Moving the compacted TreeMap into place means:<a name="line.1913"></a>
-<span class="sourceLineNo">1914</span>   * &lt;pre&gt;<a name="line.1914"></a>
-<span class="sourceLineNo">1915</span>   * 1) Unload all replaced StoreFile, close and collect list to delete.<a name="line.1915"></a>
-<span class="sourceLineNo">1916</span>   * 2) Compute new store size<a name="line.1916"></a>
-<span class="sourceLineNo">1917</span>   * &lt;/pre&gt;<a name="line.1917"></a>
-<span class="sourceLineNo">1918</span>   *<a name="line.1918"></a>
-<span class="sourceLineNo">1919</span>   * @param compactedFiles list of files that were compacted<a name="line.1919"></a>
-<span class="sourceLineNo">1920</span>   */<a name="line.1920"></a>
-<span class="sourceLineNo">1921</span>  @VisibleForTesting<a name="line.1921"></a>
-<span class="sourceLineNo">1922</span>  protected void completeCompaction(Collection&lt;HStoreFile&gt; compactedFiles)<a name="line.1922"></a>
-<span class="sourceLineNo">1923</span>    throws IOException {<a name="line.1923"></a>
-<span class="sourceLineNo">1924</span>    this.storeSize.set(0L);<a name="line.1924"></a>
-<span class="sourceLineNo">1925</span>    this.totalUncompressedBytes.set(0L);<a name="line.1925"></a>
-<span class="sourceLineNo">1926</span>    for (HStoreFile hsf : this.storeEngine.getStoreFileManager().getStorefiles()) {<a name="line.1926"></a>
-<span class="sourceLineNo">1927</span>      StoreFileReader r = hsf.getReader();<a name="line.1927"></a>
-<span class="sourceLineNo">1928</span>      if (r == null) {<a name="line.1928"></a>
-<span class="sourceLineNo">1929</span>        LOG.warn("StoreFile {} has a null Reader", hsf);<a name="line.1929"></a>
-<span class="sourceLineNo">1930</span>        continue;<a name="line.1930"></a>
-<span class="sourceLineNo">1931</span>      }<a name="line.1931"></a>
-<span class="sourceLineNo">1932</span>      this.storeSize.addAndGet(r.length());<a name="line.1932"></a>
-<span class="sourceLineNo">1933</span>      this.totalUncompressedBytes.addAndGet(r.getTotalUncompressedBytes());<a name="line.1933"></a>
-<span class="sourceLineNo">1934</span>    }<a name="line.1934"></a>
-<span class="sourceLineNo">1935</span>  }<a name="line.1935"></a>
-<span class="sourceLineNo">1936</span><a name="line.1936"></a>
-<span class="sourceLineNo">1937</span>  /*<a name="line.1937"></a>
-<span class="sourceLineNo">1938</span>   * @param wantedVersions How many versions were asked for.<a name="line.1938"></a>
-<span class="sourceLineNo">1939</span>   * @return wantedVersions or this families' {@link HConstants#VERSIONS}.<a name="line.1939"></a>
-<span class="sourceLineNo">1940</span>   */<a name="line.1940"></a>
-<span class="sourceLineNo">1941</span>  int versionsToReturn(final int wantedVersions) {<a name="line.1941"></a>
-<span class="sourceLineNo">1942</span>    if (wantedVersions &lt;= 0) {<a name="line.1942"></a>
-<span class="sourceLineNo">1943</span>      throw new IllegalArgumentException("Number of versions must be &gt; 0");<a name="line.1943"></a>
-<span class="sourceLineNo">1944</span>    }<a name="line.1944"></a>
-<span class="sourceLineNo">1945</span>    // Make sure we do not return more than maximum versions for this store.<a name="line.1945"></a>
-<span class="sourceLineNo">1946</span>    int maxVersions = this.family.getMaxVersions();<a name="line.1946"></a>
-<span class="sourceLineNo">1947</span>    return wantedVersions &gt; maxVersions ? maxVersions: wantedVersions;<a name="line.1947"></a>
-<span class="sourceLineNo">1948</span>  }<a name="line.1948"></a>
-<span class="sourceLineNo">1949</span><a name="line.1949"></a>
-<span class="sourceLineNo">1950</span>  @Override<a name="line.1950"></a>
-<span class="sourceLineNo">1951</span>  public boolean canSplit() {<a name="line.1951"></a>
-<span class="sourceLineNo">1952</span>    this.lock.readLock().lock();<a name="line.1952"></a>
-<span class="sourceLineNo">1953</span>    try {<a name="line.1953"></a>
-<span class="sourceLineNo">1954</span>      // Not split-able if we find a reference store file present in the store.<a name="line.1954"></a>
-<span class="sourceLineNo">1955</span>      boolean result = !hasReferences();<a name="line.1955"></a>
-<span class="sourceLineNo">1956</span>      if (!result) {<a name="line.1956"></a>
-<span class="sourceLineNo">1957</span>        LOG.trace("Not splittable; has references: {}", this);<a name="line.1957"></a>
-<span class="sourceLineNo">1958</span>      }<a name="line.1958"></a>
-<span class="sourceLineNo">1959</span>      return result;<a name="line.1959"></a>
-<span class="sourceLineNo">1960</span>    } finally {<a name="line.1960"></a>
-<span class="sourceLineNo">1961</span>      this.lock.readLock().unlock();<a name="line.1961"></a>
-<span class="sourceLineNo">1962</span>    }<a name="line.1962"></a>
-<span class="sourceLineNo">1963</span>  }<a name="line.1963"></a>
-<span class="sourceLineNo">1964</span><a name="line.1964"></a>
-<span class="sourceLineNo">1965</span>  /**<a name="line.1965"></a>
-<span class="sourceLineNo">1966</span>   * Determines if Store should be split.<a name="line.1966"></a>
-<span class="sourceLineNo">1967</span>   */<a name="line.1967"></a>
-<span class="sourceLineNo">1968</span>  public Optional&lt;byte[]&gt; getSplitPoint() {<a name="line.1968"></a>
-<span class="sourceLineNo">1969</span>    this.lock.readLock().lock();<a name="line.1969"></a>
-<span class="sourceLineNo">1970</span>    try {<a name="line.1970"></a>
-<span class="sourceLineNo">1971</span>      // Should already be enforced by the split policy!<a name="line.1971"></a>
-<span class="sourceLineNo">1972</span>      assert !this.getRegionInfo().isMetaRegion();<a name="line.1972"></a>
-<span class="sourceLineNo">1973</span>      // Not split-able if we find a reference store file present in the store.<a name="line.1973"></a>
-<span class="sourceLineNo">1974</span>      if (hasReferences()) {<a name="line.1974"></a>
-<span class="sourceLineNo">1975</span>        LOG.trace("Not splittable; has references: {}", this);<a name="line.1975"></a>
-<span class="sourceLineNo">1976</span>        return Optional.empty();<a name="line.1976"></a>
-<span class="sourceLineNo">1977</span>      }<a name="line.1977"></a>
-<span class="sourceLineNo">1978</span>      return this.storeEngine.getStoreFileManager().getSplitPoint();<a name="line.1978"></a>
-<span class="sourceLineNo">1979</span>    } catch(IOException e) {<a name="line.1979"></a>
-<span class="sourceLineNo">1980</span>      LOG.warn("Failed getting store size for {}", this, e);<a name="line.1980"></a>
-<span class="sourceLineNo">1981</span>    } finally {<a name="line.1981"></a>
-<span class="sourceLineNo">1982</span>      this.lock.readLock().unlock();<a name="line.1982"></a>
-<span class="sourceLineNo">1983</span>    }<a name="line.1983"></a>
-<span class="sourceLineNo">1984</span>    return Optional.empty();<a name="line.1984"></a>
-<span class="sourceLineNo">1985</span>  }<a name="line.1985"></a>
-<span class="sourceLineNo">1986</span><a name="line.1986"></a>
-<span class="sourceLineNo">1987</span>  @Override<a name="line.1987"></a>
-<span class="sourceLineNo">1988</span>  public long getLastCompactSize() {<a name="line.1988"></a>
-<span class="sourceLineNo">1989</span>    return this.lastCompactSize;<a name="line.1989"></a>
-<span class="sourceLineNo">1990</span>  }<a name="line.1990"></a>
-<span class="sourceLineNo">1991</span><a name="line.1991"></a>
-<span class="sourceLineNo">1992</span>  @Override<a name="line.1992"></a>
-<span class="sourceLineNo">1993</span>  public long getSize() {<a name="line.1993"></a>
-<span class="sourceLineNo">1994</span>    return storeSize.get();<a name="line.1994"></a>
-<span class="sourceLineNo">1995</span>  }<a name="line.1995"></a>
-<span class="sourceLineNo">1996</span><a name="line.1996"></a>
-<span class="sourceLineNo">1997</span>  public void triggerMajorCompaction() {<a name="line.1997"></a>
-<span class="sourceLineNo">1998</span>    this.forceMajor = true;<a name="line.1998"></a>
-<span class="sourceLineNo">1999</span>  }<a name="line.1999"></a>
-<span class="sourceLineNo">2000</span><a name="line.2000"></a>
-<span class="sourceLineNo">2001</span>  //////////////////////////////////////////////////////////////////////////////<a name="line.2001"></a>
-<span class="sourceLineNo">2002</span>  // File administration<a name="line.2002"></a>
-<span class="sourceLineNo">2003</span>  //////////////////////////////////////////////////////////////////////////////<a name="line.2003"></a>
-<span class="sourceLineNo">2004</span><a name="line.2004"></a>
-<span class="sourceLineNo">2005</span>  /**<a name="line.2005"></a>
-<span class="sourceLineNo">2006</span>   * Return a scanner for both the memstore and the HStore files. Assumes we are not in a<a name="line.2006"></a>
-<span class="sourceLineNo">2007</span>   * compaction.<a name="line.2007"></a>
-<span class="sourceLineNo">2008</span>   * @param scan Scan to apply when scanning the stores<a name="line.2008"></a>
-<span class="sourceLineNo">2009</span>   * @param targetCols columns to scan<a name="line.2009"></a>
-<span class="sourceLineNo">2010</span>   * @return a scanner over the current key values<a name="line.2010"></a>
-<span class="sourceLineNo">2011</span>   * @throws IOException on failure<a name="line.2011"></a>
-<span class="sourceLineNo">2012</span>   */<a name="line.2012"></a>
-<span class="sourceLineNo">2013</span>  public KeyValueScanner getScanner(Scan scan, final NavigableSet&lt;byte[]&gt; targetCols, long readPt)<a name="line.2013"></a>
-<span class="sourceLineNo">2014</span>      throws IOException {<a name="line.2014"></a>
-<span class="sourceLineNo">2015</span>    lock.readLock().lock();<a name="line.2015"></a>
-<span class="sourceLineNo">2016</span>    try {<a name="line.2016"></a>
-<span class="sourceLineNo">2017</span>      ScanInfo scanInfo;<a name="line.2017"></a>
-<span class="sourceLineNo">2018</span>      if (this.getCoprocessorHost() != null) {<a name="line.2018"></a>
-<span class="sourceLineNo">2019</span>        scanInfo = this.getCoprocessorHost().preStoreScannerOpen(this);<a name="line.2019"></a>
-<span class="sourceLineNo">2020</span>      } else {<a name="line.2020"></a>
-<span class="sourceLineNo">2021</span>        scanInfo = getScanInfo();<a name="line.2021"></a>
-<span class="sourceLineNo">2022</span>      }<a name="line.2022"></a>
-<span class="sourceLineNo">2023</span>      return createScanner(scan, scanInfo, targetCols, readPt);<a name="line.2023"></a>
-<span class="sourceLineNo">2024</span>    } finally {<a name="line.2024"></a>
-<span class="sourceLineNo">2025</span>      lock.readLock().unlock();<a name="line.2025"></a>
-<span class="sourceLineNo">2026</span>    }<a name="line.2026"></a>
-<span class="sourceLineNo">2027</span>  }<a name="line.2027"></a>
-<span class="sourceLineNo">2028</span><a name="line.2028"></a>
-<span class="sourceLineNo">2029</span>  // HMobStore will override this method to return its own implementation.<a name="line.2029"></a>
-<span class="sourceLineNo">2030</span>  protected KeyValueScanner createScanner(Scan scan, ScanInfo scanInfo,<a name="line.2030"></a>
-<span class="sourceLineNo">2031</span>      NavigableSet&lt;byte[]&gt; targetCols, long readPt) throws IOException {<a name="line.2031"></a>
-<span class="sourceLineNo">2032</span>    return scan.isReversed() ? new ReversedStoreScanner(this, scanInfo, scan, targetCols, readPt)<a name="line.2032"></a>
-<span class="sourceLineNo">2033</span>        : new StoreScanner(this, scanInfo, scan, targetCols, readPt);<a name="line.2033"></a>
-<span class="sourceLineNo">2034</span>  }<a name="line.2034"></a>
-<span class="sourceLineNo">2035</span><a name="line.2035"></a>
-<span class="sourceLineNo">2036</span>  /**<a name="line.2036"></a>
-<span class="sourceLineNo">2037</span>   * Recreates the scanners on the current list of active store file scanners<a name="line.2037"></a>
-<span class="sourceLineNo">2038</span>   * @param currentFileScanners the current set of active store file scanners<a name="line.2038"></a>
-<span class="sourceLineNo">2039</span>   * @param cacheBlocks cache the blocks or not<a name="line.2039"></a>
-<span class="sourceLineNo">2040</span>   * @param usePread use pread or not<a name="line.2040"></a>
-<span class="sourceLineNo">2041</span>   * @param isCompaction is the scanner for compaction<a name="line.2041"></a>
-<span class="sourceLineNo">2042</span>   * @param matcher the scan query matcher<a name="line.2042"></a>
-<span class="sourceLineNo">2043</span>   * @param startRow the scan's start row<a name="line.2043"></a>
-<span class="sourceLineNo">2044</span>   * @param includeStartRow should the scan include the start row<a name="line.2044"></a>
-<span class="sourceLineNo">2045</span>   * @param stopRow the scan's stop row<a name="line.2045"></a>
-<span class="sourceLineNo">2046</span>   * @param includeStopRow should the scan include the stop row<a name="line.2046"></a>
-<span class="sourceLineNo">2047</span>   * @param readPt the read point of the current scane<a name="line.2047"></a>
-<span class="sourceLineNo">2048</span>   * @param includeMemstoreScanner whether the current scanner should include memstorescanner<a name="line.2048"></a>
-<span class="sourceLineNo">2049</span>   * @return list of scanners recreated on the current Scanners<a name="line.2049"></a>
-<span class="sourceLineNo">2050</span>   * @throws IOException<a name="line.2050"></a>
-<span class="sourceLineNo">2051</span>   */<a name="line.2051"></a>
-<span class="sourceLineNo">2052</span>  public List&lt;KeyValueScanner&gt; recreateScanners(List&lt;KeyValueScanner&gt; currentFileScanners,<a name="line.2052"></a>
-<span class="sourceLineNo">2053</span>      boolean cacheBlocks, boolean usePread, boolean isCompaction, ScanQueryMatcher matcher,<a name="line.2053"></a>
-<span class="sourceLineNo">2054</span>      byte[] startRow, boolean includeStartRow, byte[] stopRow, boolean includeStopRow, long readPt,<a name="line.2054"></a>
-<span class="sourceLineNo">2055</span>      boolean includeMemstoreScanner) throws IOException {<a name="line.2055"></a>
-<span class="sourceLineNo">2056</span>    this.lock.readLock().lock();<a name="line.2056"></a>
-<span class="sourceLineNo">2057</span>    try {<a name="line.2057"></a>
-<span class="sourceLineNo">2058</span>      Map&lt;String, HStoreFile&gt; name2File =<a name="line.2058"></a>
-<span class="sourceLineNo">2059</span>          new HashMap&lt;&gt;(getStorefilesCount() + getCompactedFilesCount());<a name="line.2059"></a>
-<span class="sourceLineNo">2060</span>      for (HStoreFile file : getStorefiles()) {<a name="line.2060"></a>
-<span class="sourceLineNo">2061</span>        name2File.put(file.getFileInfo().getActiveFileName(), file);<a name="line.2061"></a>
-<span class="sourceLineNo">2062</span>      }<a name="line.2062"></a>
-<span class="sourceLineNo">2063</span>      Collection&lt;HStoreFile&gt; compactedFiles = getCompactedFiles();<a name="line.2063"></a>
-<span class="sourceLineNo">2064</span>      for (HStoreFile file : IterableUtils.emptyIfNull(compactedFiles)) {<a name="line.2064"></a>
-<span class="sourceLineNo">2065</span>        name2File.put(file.getFileInfo().getActiveFileName(), file);<a name="line.2065"></a>
-<span class="sourceLineNo">2066</span>      }<a name="line.2066"></a>
-<span class="sourceLineNo">2067</span>      List&lt;HStoreFile&gt; filesToReopen = new ArrayList&lt;&gt;();<a name="line.2067"></a>
-<span class="sourceLineNo">2068</span>      for (KeyValueScanner kvs : currentFileScanners) {<a name="line.2068"></a>
-<span class="sourceLineNo">2069</span>        assert kvs.isFileScanner();<a name="line.2069"></a>
-<span class="sourceLineNo">2070</span>        if (kvs.peek() == null) {<a name="line.2070"></a>
-<span class="sourceLineNo">2071</span>          continue;<a name="line.2071"></a>
-<span class="sourceLineNo">2072</span>        }<a name="line.2072"></a>
-<span class="sourceLineNo">2073</span>        filesToReopen.add(name2File.get(kvs.getFilePath().getName()));<a name="line.2073"></a>
-<span class="sourceLineNo">2074</span>      }<a name="line.2074"></a>
-<span class="sourceLineNo">2075</span>      if (filesToReopen.isEmpty()) {<a name="line.2075"></a>
-<span class="sourceLineNo">2076</span>        return null;<a name="line.2076"></a>
+<span class="sourceLineNo">1888</span>  private void finishCompactionRequest(CompactionRequestImpl cr) {<a name="line.1888"></a>
+<span class="sourceLineNo">1889</span>    this.region.reportCompactionRequestEnd(cr.isMajor(), cr.getFiles().size(), cr.getSize());<a name="line.1889"></a>
+<span class="sourceLineNo">1890</span>    if (cr.isOffPeak()) {<a name="line.1890"></a>
+<span class="sourceLineNo">1891</span>      offPeakCompactionTracker.set(false);<a name="line.1891"></a>
+<span class="sourceLineNo">1892</span>      cr.setOffPeak(false);<a name="line.1892"></a>
+<span class="sourceLineNo">1893</span>    }<a name="line.1893"></a>
+<span class="sourceLineNo">1894</span>    synchronized (filesCompacting) {<a name="line.1894"></a>
+<span class="sourceLineNo">1895</span>      filesCompacting.removeAll(cr.getFiles());<a name="line.1895"></a>
+<span class="sourceLineNo">1896</span>    }<a name="line.1896"></a>
+<span class="sourceLineNo">1897</span>  }<a name="line.1897"></a>
+<span class="sourceLineNo">1898</span><a name="line.1898"></a>
+<span class="sourceLineNo">1899</span>  /**<a name="line.1899"></a>
+<span class="sourceLineNo">1900</span>   * Validates a store file by opening and closing it. In HFileV2 this should not be an expensive<a name="line.1900"></a>
+<span class="sourceLineNo">1901</span>   * operation.<a name="line.1901"></a>
+<span class="sourceLineNo">1902</span>   * @param path the path to the store file<a name="line.1902"></a>
+<span class="sourceLineNo">1903</span>   */<a name="line.1903"></a>
+<span class="sourceLineNo">1904</span>  private void validateStoreFile(Path path) throws IOException {<a name="line.1904"></a>
+<span class="sourceLineNo">1905</span>    HStoreFile storeFile = null;<a name="line.1905"></a>
+<span class="sourceLineNo">1906</span>    try {<a name="line.1906"></a>
+<span class="sourceLineNo">1907</span>      storeFile = createStoreFileAndReader(path);<a name="line.1907"></a>
+<span class="sourceLineNo">1908</span>    } catch (IOException e) {<a name="line.1908"></a>
+<span class="sourceLineNo">1909</span>      LOG.error("Failed to open store file : {}, keeping it in tmp location", path, e);<a name="line.1909"></a>
+<span class="sourceLineNo">1910</span>      throw e;<a name="line.1910"></a>
+<span class="sourceLineNo">1911</span>    } finally {<a name="line.1911"></a>
+<span class="sourceLineNo">1912</span>      if (storeFile != null) {<a name="line.1912"></a>
+<span class="sourceLineNo">1913</span>        storeFile.closeStoreFile(false);<a name="line.1913"></a>
+<span class="sourceLineNo">1914</span>      }<a name="line.1914"></a>
+<span class="sourceLineNo">1915</span>    }<a name="line.1915"></a>
+<span class="sourceLineNo">1916</span>  }<a name="line.1916"></a>
+<span class="sourceLineNo">1917</span><a name="line.1917"></a>
+<span class="sourceLineNo">1918</span>  /**<a name="line.1918"></a>
+<span class="sourceLineNo">1919</span>   * &lt;p&gt;It works by processing a compaction that's been written to disk.<a name="line.1919"></a>
+<span class="sourceLineNo">1920</span>   *<a name="line.1920"></a>
+<span class="sourceLineNo">1921</span>   * &lt;p&gt;It is usually invoked at the end of a compaction, but might also be<a name="line.1921"></a>
+<span class="sourceLineNo">1922</span>   * invoked at HStore startup, if the prior execution died midway through.<a name="line.1922"></a>
+<span class="sourceLineNo">1923</span>   *<a name="line.1923"></a>
+<span class="sourceLineNo">1924</span>   * &lt;p&gt;Moving the compacted TreeMap into place means:<a name="line.1924"></a>
+<span class="sourceLineNo">1925</span>   * &lt;pre&gt;<a name="line.1925"></a>
+<span class="sourceLineNo">1926</span>   * 1) Unload all replaced StoreFile, close and collect list to delete.<a name="line.1926"></a>
+<span class="sourceLineNo">1927</span>   * 2) Compute new store size<a name="line.1927"></a>
+<span class="sourceLineNo">1928</span>   * &lt;/pre&gt;<a name="line.1928"></a>
+<span class="sourceLineNo">1929</span>   *<a name="line.1929"></a>
+<span class="sourceLineNo">1930</span>   * @param compactedFiles list of files that were compacted<a name="line.1930"></a>
+<span class="sourceLineNo">1931</span>   */<a name="line.1931"></a>
+<span class="sourceLineNo">1932</span>  @VisibleForTesting<a name="line.1932"></a>
+<span class="sourceLineNo">1933</span>  protected void completeCompaction(Collection&lt;HStoreFile&gt; compactedFiles)<a name="line.1933"></a>
+<span class="sourceLineNo">1934</span>    throws IOException {<a name="line.1934"></a>
+<span class="sourceLineNo">1935</span>    this.storeSize.set(0L);<a name="line.1935"></a>
+<span class="sourceLineNo">1936</span>    this.totalUncompressedBytes.set(0L);<a name="line.1936"></a>
+<span class="sourceLineNo">1937</span>    for (HStoreFile hsf : this.storeEngine.getStoreFileManager().getStorefiles()) {<a name="line.1937"></a>
+<span class="sourceLineNo">1938</span>      StoreFileReader r = hsf.getReader();<a name="line.1938"></a>
+<span class="sourceLineNo">1939</span>      if (r == null) {<a name="line.1939"></a>
+<span class="sourceLineNo">1940</span>        LOG.warn("StoreFile {} has a null Reader", hsf);<a name="line.1940"></a>
+<span class="sourceLineNo">1941</span>        continue;<a name="line.1941"></a>
+<span class="sourceLineNo">1942</span>      }<a name="line.1942"></a>
+<span class="sourceLineNo">1943</span>      this.storeSize.addAndGet(r.length());<a name="line.1943"></a>
+<span class="sourceLineNo">1944</span>      this.totalUncompressedBytes.addAndGet(r.getTotalUncompressedBytes());<a name="line.1944"></a>
+<span class="sourceLineNo">1945</span>    }<a name="line.1945"></a>
+<span class="sourceLineNo">1946</span>  }<a name="line.1946"></a>
+<span class="sourceLineNo">1947</span><a name="line.1947"></a>
+<span class="sourceLineNo">1948</span>  /*<a name="line.1948"></a>
+<span class="sourceLineNo">1949</span>   * @param wantedVersions How many versions were asked for.<a name="line.1949"></a>
+<span class="sourceLineNo">1950</span>   * @return wantedVersions or this families' {@link HConstants#VERSIONS}.<a name="line.1950"></a>
+<span class="sourceLineNo">1951</span>   */<a name="line.1951"></a>
+<span class="sourceLineNo">1952</span>  int versionsToReturn(final int wantedVersions) {<a name="line.1952"></a>
+<span class="sourceLineNo">1953</span>    if (wantedVersions &lt;= 0) {<a name="line.1953"></a>
+<span class="sourceLineNo">1954</span>      throw new IllegalArgumentException("Number of versions must be &gt; 0");<a name="line.1954"></a>
+<span class="sourceLineNo">1955</span>    }<a name="line.1955"></a>
+<span class="sourceLineNo">1956</span>    // Make sure we do not return more than maximum versions for this store.<a name="line.1956"></a>
+<span class="sourceLineNo">1957</span>    int maxVersions = this.family.getMaxVersions();<a name="line.1957"></a>
+<span class="sourceLineNo">1958</span>    return wantedVersions &gt; maxVersions ? maxVersions: wantedVersions;<a name="line.1958"></a>
+<span class="sourceLineNo">1959</span>  }<a name="line.1959"></a>
+<span class="sourceLineNo">1960</span><a name="line.1960"></a>
+<span class="sourceLineNo">1961</span>  @Override<a name="line.1961"></a>
+<span class="sourceLineNo">1962</span>  public boolean canSplit() {<a name="line.1962"></a>
+<span class="sourceLineNo">1963</span>    this.lock.readLock().lock();<a name="line.1963"></a>
+<span class="sourceLineNo">1964</span>    try {<a name="line.1964"></a>
+<span class="sourceLineNo">1965</span>      // Not split-able if we find a reference store file present in the store.<a name="line.1965"></a>
+<span class="sourceLineNo">1966</span>      boolean result = !hasReferences();<a name="line.1966"></a>
+<span class="sourceLineNo">1967</span>      if (!result) {<a name="line.1967"></a>
+<span class="sourceLineNo">1968</span>        LOG.trace("Not splittable; has references: {}", this);<a name="line.1968"></a>
+<span class="sourceLineNo">1969</span>      }<a name="line.1969"></a>
+<span class="sourceLineNo">1970</span>      return result;<a name="line.1970"></a>
+<span class="sourceLineNo">1971</span>    } finally {<a name="line.1971"></a>
+<span class="sourceLineNo">1972</span>      this.lock.readLock().unlock();<a name="line.1972"></a>
+<span class="sourceLineNo">1973</span>    }<a name="line.1973"></a>
+<span class="sourceLineNo">1974</span>  }<a name="line.1974"></a>
+<span class="sourceLineNo">1975</span><a name="line.1975"></a>
+<span class="sourceLineNo">1976</span>  /**<a name="line.1976"></a>
+<span class="sourceLineNo">1977</span>   * Determines if Store should be split.<a name="line.1977"></a>
+<span class="sourceLineNo">1978</span>   */<a name="line.1978"></a>
+<span class="sourceLineNo">1979</span>  public Optional&lt;byte[]&gt; getSplitPoint() {<a name="line.1979"></a>
+<span class="sourceLineNo">1980</span>    this.lock.readLock().lock();<a name="line.1980"></a>
+<span class="sourceLineNo">1981</span>    try {<a name="line.1981"></a>
+<span class="sourceLineNo">1982</span>      // Should already be enforced by the split policy!<a name="line.1982"></a>
+<span class="sourceLineNo">1983</span>      assert !this.getRegionInfo().isMetaRegion();<a name="line.1983"></a>
+<span class="sourceLineNo">1984</span>      // Not split-able if we find a reference store file present in the store.<a name="line.1984"></a>
+<span class="sourceLineNo">1985</span>      if (hasReferences()) {<a name="line.1985"></a>
+<span class="sourceLineNo">1986</span>        LOG.trace("Not splittable; has references: {}", this);<a name="line.1986"></a>
+<span class="sourceLineNo">1987</span>        return Optional.empty();<a name="line.1987"></a>
+<span class="sourceLineNo">1988</span>      }<a name="line.1988"></a>
+<span class="sourceLineNo">1989</span>      return this.storeEngine.getStoreFileManager().getSplitPoint();<a name="line.1989"></a>
+<span class="sourceLineNo">1990</span>    } catch(IOException e) {<a name="line.1990"></a>
+<span class="sourceLineNo">1991</span>      LOG.warn("Failed getting store size for {}", this, e);<a name="line.1991"></a>
+<span class="sourceLineNo">1992</span>    } finally {<a name="line.1992"></a>
+<span class="sourceLineNo">1993</span>      this.lock.readLock().unlock();<a name="line.1993"></a>
+<span class="sourceLineNo">1994</span>    }<a name="line.1994"></a>
+<span class="sourceLineNo">1995</span>    return Optional.empty();<a name="line.1995"></a>
+<span class="sourceLineNo">1996</span>  }<a name="line.1996"></a>
+<span class="sourceLineNo">1997</span><a name="line.1997"></a>
+<span class="sourceLineNo">1998</span>  @Override<a name="line.1998"></a>
+<span class="sourceLineNo">1999</span>  public long getLastCompactSize() {<a name="line.1999"></a>
+<span class="sourceLineNo">2000</span>    return this.lastCompactSize;<a name="line.2000"></a>
+<span class="sourceLineNo">2001</span>  }<a name="line.2001"></a>
+<span class="sourceLineNo">2002</span><a name="line.2002"></a>
+<span class="sourceLineNo">2003</span>  @Override<a name="line.2003"></a>
+<span class="sourceLineNo">2004</span>  public long getSize() {<a name="line.2004"></a>
+<span class="sourceLineNo">2005</span>    return storeSize.get();<a name="line.2005"></a>
+<span class="sourceLineNo">2006</span>  }<a name="line.2006"></a>
+<span class="sourceLineNo">2007</span><a name="line.2007"></a>
+<span class="sourceLineNo">2008</span>  public void triggerMajorCompaction() {<a name="line.2008"></a>
+<span class="sourceLineNo">2009</span>    this.forceMajor = true;<a name="line.2009"></a>
+<span class="sourceLineNo">2010</span>  }<a name="line.2010"></a>
+<span class="sourceLineNo">2011</span><a name="line.2011"></a>
+<span class="sourceLineNo">2012</span>  //////////////////////////////////////////////////////////////////////////////<a name="line.2012"></a>
+<span class="sourceLineNo">2013</span>  // File administration<a name="line.2013"></a>
+<span class="sourceLineNo">2014</span>  //////////////////////////////////////////////////////////////////////////////<a name="line.2014"></a>
+<span class="sourceLineNo">2015</span><a name="line.2015"></a>
+<span class="sourceLineNo">2016</span>  /**<a name="line.2016"></a>
+<span class="sourceLineNo">2017</span>   * Return a scanner for both the memstore and the HStore files. Assumes we are not in a<a name="line.2017"></a>
+<span class="sourceLineNo">2018</span>   * compaction.<a name="line.2018"></a>
+<span class="sourceLineNo">2019</span>   * @param scan Scan to apply when scanning the stores<a name="line.2019"></a>
+<span class="sourceLineNo">2020</span>   * @param targetCols columns to scan<a name="line.2020"></a>
+<span class="sourceLineNo">2021</span>   * @return a scanner over the current key values<a name="line.2021"></a>
+<span class="sourceLineNo">2022</span>   * @throws IOException on failure<a name="line.2022"></a>
+<span class="sourceLineNo">2023</span>   */<a name="line.2023"></a>
+<span class="sourceLineNo">2024</span>  public KeyValueScanner getScanner(Scan scan, final NavigableSet&lt;byte[]&gt; targetCols, long readPt)<a name="line.2024"></a>
+<span class="sourceLineNo">2025</span>      throws IOException {<a name="line.2025"></a>
+<span class="sourceLineNo">2026</span>    lock.readLock().lock();<a name="line.2026"></a>
+<span class="sourceLineNo">2027</span>    try {<a name="line.2027"></a>
+<span class="sourceLineNo">2028</span>      ScanInfo scanInfo;<a name="line.2028"></a>
+<span class="sourceLineNo">2029</span>      if (this.getCoprocessorHost() != null) {<a name="line.2029"></a>
+<span class="sourceLineNo">2030</span>        scanInfo = this.getCoprocessorHost().preStoreScannerOpen(this);<a name="line.2030"></a>
+<span class="sourceLineNo">2031</span>      } else {<a name="line.2031"></a>
+<span class="sourceLineNo">2032</span>        scanInfo = getScanInfo();<a name="line.2032"></a>
+<span class="sourceLineNo">2033</span>      }<a name="line.2033"></a>
+<span class="sourceLineNo">2034</span>      return createScanner(scan, scanInfo, targetCols, readPt);<a name="line.2034"></a>
+<span class="sourceLineNo">2035</span>    } finally {<a name="line.2035"></a>
+<span class="sourceLineNo">2036</span>      lock.readLock().unlock();<a name="line.2036"></a>
+<span class="sourceLineNo">2037</span>    }<a name="line.2037"></a>
+<span class="sourceLineNo">2038</span>  }<a name="line.2038"></a>
+<span class="sourceLineNo">2039</span><a name="line.2039"></a>
+<span class="sourceLineNo">2040</span>  // HMobStore will override this method to return its own implementation.<a name="line.2040"></a>
+<span class="sourceLineNo">2041</span>  protected KeyValueScanner createScanner(Scan scan, ScanInfo scanInfo,<a name="line.2041"></a>
+<span class="sourceLineNo">2042</span>      NavigableSet&lt;byte[]&gt; targetCols, long readPt) throws IOException {<a name="line.2042"></a>
+<span class="sourceLineNo">2043</span>    return scan.isReversed() ? new ReversedStoreScanner(this, scanInfo, scan, targetCols, readPt)<a name="line.2043"></a>
+<span class="sourceLineNo">2044</span>        : new StoreScanner(this, scanInfo, scan, targetCols, readPt);<a name="line.2044"></a>
+<span class="sourceLineNo">2045</span>  }<a name="line.2045"></a>
+<span class="sourceLineNo">2046</span><a name="line.2046"></a>
+<span class="sourceLineNo">2047</span>  /**<a name="line.2047"></a>
+<span class="sourceLineNo">2048</span>   * Recreates the scanners on the current list of active store file scanners<a name="line.2048"></a>
+<span class="sourceLineNo">2049</span>   * @param currentFileScanners the current set of active store file scanners<a name="line.2049"></a>
+<span class="sourceLineNo">2050</span>   * @param cacheBlocks cache the blocks or not<a name="line.2050"></a>
+<span class="sourceLineNo">2051</span>   * @param usePread use pread or not<a name="line.2051"></a>
+<span class="sourceLineNo">2052</span>   * @param isCompaction is the scanner for compaction<a name="line.2052"></a>
+<span class="sourceLineNo">2053</span>   * @param matcher the scan query matcher<a name="line.2053"></a>
+<span class="sourceLineNo">2054</span>   * @param startRow the scan's start row<a name="line.2054"></a>
+<span class="sourceLineNo">2055</span>   * @param includeStartRow should the scan include the start row<a name="line.2055"></a>
+<span class="sourceLineNo">2056</span>   * @param stopRow the scan's stop row<a name="line.2056"></a>
+<span class="sourceLineNo">2057</span>   * @param includeStopRow should the scan include the stop row<a name="line.2057"></a>
+<span class="sourceLineNo">2058</span>   * @param readPt the read point of the current scane<a name="line.2058"></a>
+<span class="sourceLineNo">2059</span>   * @param includeMemstoreScanner whether the current scanner should include memstorescanner<a name="line.2059"></a>
+<span class="sourceLineNo">2060</span>   * @return list of scanners recreated on the current Scanners<a name="line.2060"></a>
+<span class="sourceLineNo">2061</span>   * @throws IOException<a name="line.2061"></a>
+<span class="sourceLineNo">2062</span>   */<a name="line.2062"></a>
+<span class="sourceLineNo">2063</span>  public List&lt;KeyValueScanner&gt; recreateScanners(List&lt;KeyValueScanner&gt; currentFileScanners,<a name="line.2063"></a>
+<span class="sourceLineNo">2064</span>      boolean cacheBlocks, boolean usePread, boolean isCompaction, ScanQueryMatcher matcher,<a name="line.2064"></a>
+<span class="sourceLineNo">2065</span>      byte[] startRow, boolean includeStartRow, byte[] stopRow, boolean includeStopRow, long readPt,<a name="line.2065"></a>
+<span class="sourceLineNo">2066</span>      boolean includeMemstoreScanner) throws IOException {<a name="line.2066"></a>
+<span class="sourceLineNo">2067</span>    this.lock.readLock().lock();<a name="line.2067"></a>
+<span class="sourceLineNo">2068</span>    try {<a name="line.2068"></a>
+<span class="sourceLineNo">2069</span>      Map&lt;String, HStoreFile&gt; name2File =<a name="line.2069"></a>
+<span class="sourceLineNo">2070</span>          new HashMap&lt;&gt;(getStorefilesCount() + getCompactedFilesCount());<a name="line.2070"></a>
+<span class="sourceLineNo">2071</span>      for (HStoreFile file : getStorefiles()) {<a name="line.2071"></a>
+<span class="sourceLineNo">2072</span>        name2File.put(file.getFileInfo().getActiveFileName(), file);<a name="line.2072"></a>
+<span class="sourceLineNo">2073</span>      }<a name="line.2073"></a>
+<span class="sourceLineNo">2074</span>      Collection&lt;HStoreFile&gt; compactedFiles = getCompactedFiles();<a name="line.2074"></a>
+<span class="sourceLineNo">2075</span>      for (HStoreFile file : IterableUtils.emptyIfNull(compactedFiles)) {<a name="line.2075"></a>
+<span class="sourceLineNo">2076</span>        name2File.put(file.getFileInfo().getActiveFileName(), file);<a name="line.2076"></a>
 <span class="sourceLineNo">2077</span>      }<a name="line.2077"></a>
-<span class="sourceLineNo">2078</span>      return getScanners(filesToReopen, cacheBlocks, false, false, matcher, startRow,<a name="line.2078"></a>
-<span class="sourceLineNo">2079</span>        includeStartRow, stopRow, includeStopRow, readPt, false);<a name="line.2079"></a>
-<span class="sourceLineNo">2080</span>    } finally {<a name="line.2080"></a>
-<span class="sourceLineNo">2081</span>      this.lock.readLock().unlock();<a name="line.2081"></a>
-<span class="sourceLineNo">2082</span>    }<a name="line.2082"></a>
-<span class="sourceLineNo">2083</span>  }<a name="line.2083"></a>
-<span class="sourceLineNo">2084</span><a name="line.2084"></a>
-<span class="sourceLineNo">2085</span>  @Override<a name="line.2085"></a>
-<span class="sourceLineNo">2086</span>  public String toString() {<a name="line.2086"></a>
-<span class="sourceLineNo">2087</span>    return this.getColumnFamilyName();<a name="line.2087"></a>
-<span class="sourceLineNo">2088</span>  }<a name="line.2088"></a>
-<span class="sourceLineNo">2089</span><a name="line.2089"></a>
-<span class="sourceLineNo">2090</span>  @Override<a name="line.2090"></a>
-<span class="sourceLineNo">2091</span>  public int getStorefilesCount() {<a name="line.2091"></a>
-<span class="sourceLineNo">2092</span>    return this.storeEngine.getStoreFileManager().getStorefileCount();<a name="line.2092"></a>
-<span class="sourceLineNo">2093</span>  }<a name="line.2093"></a>
-<span class="sourceLineNo">2094</span><a name="line.2094"></a>
-<span class="sourceLineNo">2095</span>  @Override<a name="line.2095"></a>
-<span class="sourceLineNo">2096</span>  public int getCompactedFilesCount() {<a name="line.2096"></a>
-<span class="sourceLineNo">2097</span>    return this.storeEngine.getStoreFileManager().getCompactedFilesCount();<a name="line.2097"></a>
-<span class="sourceLineNo">2098</span>  }<a name="line.2098"></a>
-<span class="sourceLineNo">2099</span><a name="line.2099"></a>
-<span class="sourceLineNo">2100</span>  private LongStream getStoreFileAgeStream() {<a name="line.2100"></a>
-<span class="sourceLineNo">2101</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream().filter(sf -&gt; {<a name="line.2101"></a>
-<span class="sourceLineNo">2102</span>      if (sf.getReader() == null) {<a name="line.2102"></a>
-<span class="sourceLineNo">2103</span>        LOG.warn("StoreFile {} has a null Reader", sf);<a name="line.2103"></a>
-<span class="sourceLineNo">2104</span>        return false;<a name="line.2104"></a>
-<span class="sourceLineNo">2105</span>      } else {<a name="line.2105"></a>
-<span class="sourceLineNo">2106</span>        return true;<a name="line.2106"></a>
-<span class="sourceLineNo">2107</span>      }<a name="line.2107"></a>
-<span class="sourceLineNo">2108</span>    }).filter(HStoreFile::isHFile).mapToLong(sf -&gt; sf.getFileInfo().getCreatedTimestamp())<a name="line.2108"></a>
-<span class="sourceLineNo">2109</span>        .map(t -&gt; EnvironmentEdgeManager.currentTime() - t);<a name="line.2109"></a>
-<span class="sourceLineNo">2110</span>  }<a name="line.2110"></a>
-<span class="sourceLineNo">2111</span><a name="line.2111"></a>
-<span class="sourceLineNo">2112</span>  @Override<a name="line.2112"></a>
-<span class="sourceLineNo">2113</span>  public OptionalLong getMaxStoreFileAge() {<a name="line.2113"></a>
-<span class="sourceLineNo">2114</span>    return getStoreFileAgeStream().max();<a name="line.2114"></a>
-<span class="sourceLineNo">2115</span>  }<a name="line.2115"></a>
-<span class="sourceLineNo">2116</span><a name="line.2116"></a>
-<span class="sourceLineNo">2117</span>  @Override<a name="line.2117"></a>
-<span class="sourceLineNo">2118</span>  public OptionalLong getMinStoreFileAge() {<a name="line.2118"></a>
-<span class="sourceLineNo">2119</span>    return getStoreFileAgeStream().min();<a name="line.2119"></a>
-<span class="sourceLineNo">2120</span>  }<a name="line.2120"></a>
-<span class="sourceLineNo">2121</span><a name="line.2121"></a>
-<span class="sourceLineNo">2122</span>  @Override<a name="line.2122"></a>
-<span class="sourceLineNo">2123</span>  public OptionalDouble getAvgStoreFileAge() {<a name="line.2123"></a>
-<span class="sourceLineNo">2124</span>    return getStoreFileAgeStream().average();<a name="line.2124"></a>
-<span class="sourceLineNo">2125</span>  }<a name="line.2125"></a>
-<span class="sourceLineNo">2126</span><a name="line.2126"></a>
-<span class="sourceLineNo">2127</span>  @Override<a name="line.2127"></a>
-<span class="sourceLineNo">2128</span>  public long getNumReferenceFiles() {<a name="line.2128"></a>
-<span class="sourceLineNo">2129</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream()<a name="line.2129"></a>
-<span class="sourceLineNo">2130</span>        .filter(HStoreFile::isReference).count();<a name="line.2130"></a>
+<span class="sourceLineNo">2078</span>      List&lt;HStoreFile&gt; filesToReopen = new ArrayList&lt;&gt;();<a name="line.2078"></a>
+<span class="sourceLineNo">2079</span>      for (KeyValueScanner kvs : currentFileScanners) {<a name="line.2079"></a>
+<span class="sourceLineNo">2080</span>        assert kvs.isFileScanner();<a name="line.2080"></a>
+<span class="sourceLineNo">2081</span>        if (kvs.peek() == null) {<a name="line.2081"></a>
+<span class="sourceLineNo">2082</span>          continue;<a name="line.2082"></a>
+<span class="sourceLineNo">2083</span>        }<a name="line.2083"></a>
+<span class="sourceLineNo">2084</span>        filesToReopen.add(name2File.get(kvs.getFilePath().getName()));<a name="line.2084"></a>
+<span class="sourceLineNo">2085</span>      }<a name="line.2085"></a>
+<span class="sourceLineNo">2086</span>      if (filesToReopen.isEmpty()) {<a name="line.2086"></a>
+<span class="sourceLineNo">2087</span>        return null;<a name="line.2087"></a>
+<span class="sourceLineNo">2088</span>      }<a name="line.2088"></a>
+<span class="sourceLineNo">2089</span>      return getScanners(filesToReopen, cacheBlocks, false, false, matcher, startRow,<a name="line.2089"></a>
+<span class="sourceLineNo">2090</span>        includeStartRow, stopRow, includeStopRow, readPt, false);<a name="line.2090"></a>
+<span class="sourceLineNo">2091</span>    } finally {<a name="line.2091"></a>
+<span class="sourceLineNo">2092</span>      this.lock.readLock().unlock();<a name="line.2092"></a>
+<span class="sourceLineNo">2093</span>    }<a name="line.2093"></a>
+<span class="sourceLineNo">2094</span>  }<a name="line.2094"></a>
+<span class="sourceLineNo">2095</span><a name="line.2095"></a>
+<span class="sourceLineNo">2096</span>  @Override<a name="line.2096"></a>
+<span class="sourceLineNo">2097</span>  public String toString() {<a name="line.2097"></a>
+<span class="sourceLineNo">2098</span>    return this.getColumnFamilyName();<a name="line.2098"></a>
+<span class="sourceLineNo">2099</span>  }<a name="line.2099"></a>
+<span class="sourceLineNo">2100</span><a name="line.2100"></a>
+<span class="sourceLineNo">2101</span>  @Override<a name="line.2101"></a>
+<span class="sourceLineNo">2102</span>  public int getStorefilesCount() {<a name="line.2102"></a>
+<span class="sourceLineNo">2103</span>    return this.storeEngine.getStoreFileManager().getStorefileCount();<a name="line.2103"></a>
+<span class="sourceLineNo">2104</span>  }<a name="line.2104"></a>
+<span class="sourceLineNo">2105</span><a name="line.2105"></a>
+<span class="sourceLineNo">2106</span>  @Override<a name="line.2106"></a>
+<span class="sourceLineNo">2107</span>  public int getCompactedFilesCount() {<a name="line.2107"></a>
+<span class="sourceLineNo">2108</span>    return this.storeEngine.getStoreFileManager().getCompactedFilesCount();<a name="line.2108"></a>
+<span class="sourceLineNo">2109</span>  }<a name="line.2109"></a>
+<span class="sourceLineNo">2110</span><a name="line.2110"></a>
+<span class="sourceLineNo">2111</span>  private LongStream getStoreFileAgeStream() {<a name="line.2111"></a>
+<span class="sourceLineNo">2112</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream().filter(sf -&gt; {<a name="line.2112"></a>
+<span class="sourceLineNo">2113</span>      if (sf.getReader() == null) {<a name="line.2113"></a>
+<span class="sourceLineNo">2114</span>        LOG.warn("StoreFile {} has a null Reader", sf);<a name="line.2114"></a>
+<span class="sourceLineNo">2115</span>        return false;<a name="line.2115"></a>
+<span class="sourceLineNo">2116</span>      } else {<a name="line.2116"></a>
+<span class="sourceLineNo">2117</span>        return true;<a name="line.2117"></a>
+<span class="sourceLineNo">2118</span>      }<a name="line.2118"></a>
+<span class="sourceLineNo">2119</span>    }).filter(HStoreFile::isHFile).mapToLong(sf -&gt; sf.getFileInfo().getCreatedTimestamp())<a name="line.2119"></a>
+<span class="sourceLineNo">2120</span>        .map(t -&gt; EnvironmentEdgeManager.currentTime() - t);<a name="line.2120"></a>
+<span class="sourceLineNo">2121</span>  }<a name="line.2121"></a>
+<span class="sourceLineNo">2122</span><a name="line.2122"></a>
+<span class="sourceLineNo">2123</span>  @Override<a name="line.2123"></a>
+<span class="sourceLineNo">2124</span>  public OptionalLong getMaxStoreFileAge() {<a name="line.2124"></a>
+<span class="sourceLineNo">2125</span>    return getStoreFileAgeStream().max();<a name="line.2125"></a>
+<span class="sourceLineNo">2126</span>  }<a name="line.2126"></a>
+<span class="sourceLineNo">2127</span><a name="line.2127"></a>
+<span class="sourceLineNo">2128</span>  @Override<a name="line.2128"></a>
+<span class="sourceLineNo">2129</span>  public OptionalLong getMinStoreFileAge() {<a name="line.2129"></a>
+<span class="sourceLineNo">2130</span>    return getStoreFileAgeStream().min();<a name="line.2130"></a>
 <span class="sourceLineNo">2131</span>  }<a name="line.2131"></a>
 <span class="sourceLineNo">2132</span><a name="line.2132"></a>
 <span class="sourceLineNo">2133</span>  @Override<a name="line.2133"></a>
-<span class="sourceLineNo">2134</span>  public long getNumHFiles() {<a name="line.2134"></a>
-<span class="sourceLineNo">2135</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream()<a name="line.2135"></a>
-<span class="sourceLineNo">2136</span>        .filter(HStoreFile::isHFile).count();<a name="line.2136"></a>
-<span class="sourceLineNo">2137</span>  }<a name="line.2137"></a>
-<span class="sourceLineNo">2138</span><a name="line.2138"></a>
-<span class="sourceLineNo">2139</span>  @Override<a name="line.2139"></a>
-<span class="sourceLineNo">2140</span>  public long getStoreSizeUncompressed() {<a name="line.2140"></a>
-<span class="sourceLineNo">2141</span>    return this.totalUncompressedBytes.get();<a name="line.2141"></a>
+<span class="sourceLineNo">2134</span>  public OptionalDouble getAvgStoreFileAge() {<a name="line.2134"></a>
+<span class="sourceLineNo">2135</span>    return getStoreFileAgeStream().average();<a name="line.2135"></a>
+<span class="sourceLineNo">2136</span>  }<a name="line.2136"></a>
+<span class="sourceLineNo">2137</span><a name="line.2137"></a>
+<span class="sourceLineNo">2138</span>  @Override<a name="line.2138"></a>
+<span class="sourceLineNo">2139</span>  public long getNumReferenceFiles() {<a name="line.2139"></a>
+<span class="sourceLineNo">2140</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream()<a name="line.2140"></a>
+<span class="sourceLineNo">2141</span>        .filter(HStoreFile::isReference).count();<a name="line.2141"></a>
 <span class="sourceLineNo">2142</span>  }<a name="line.2142"></a>
 <span class="sourceLineNo">2143</span><a name="line.2143"></a>
 <span class="sourceLineNo">2144</span>  @Override<a name="line.2144"></a>
-<span class="sourceLineNo">2145</span>  public long getStorefilesSize() {<a name="line.2145"></a>
-<span class="sourceLineNo">2146</span>    // Include all StoreFiles<a name="line.2146"></a>
-<span class="sourceLineNo">2147</span>    return getStorefilesSize(storeFile -&gt; true);<a name="line.2147"></a>
+<span class="sourceLineNo">2145</span>  public long getNumHFiles() {<a name="line.2145"></a>
+<span class="sourceLineNo">2146</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream()<a name="line.2146"></a>
+<span class="sourceLineNo">2147</span>        .filter(HStoreFile::isHFile).count();<a name="line.2147"></a>
 <span class="sourceLineNo">2148</span>  }<a name="line.2148"></a>
 <span class="sourceLineNo">2149</span><a name="line.2149"></a>
 <span class="sourceLineNo">2150</span>  @Override<a name="line.2150"></a>
-<span class="sourceLineNo">2151</span>  public long getHFilesSize() {<a name="line.2151"></a>
-<span class="sourceLineNo">2152</span>    // Include only StoreFiles which are HFiles<a name="line.2152"></a>
-<span class="sourceLineNo">2153</span>    return getStorefilesSize(storeFile -&gt; storeFile.isHFile());<a name="line.2153"></a>
-<span class="sourceLineNo">2154</span>  }<a name="line.2154"></a>
-<span class="sourceLineNo">2155</span><a name="line.2155"></a>
-<span class="sourceLineNo">2156</span>  private long getStorefilesSize(Predicate&lt;HStoreFile&gt; predicate) {<a name="line.2156"></a>
-<span class="sourceLineNo">2157</span>    return this.storeEngine.getStoreFileManager().getStorefiles().stream().filter(sf -&gt; {<a name="line.2157"></a>
-<span class="sourceLineNo">2158</span>      if (sf.getReader() == null) {<a name="line.2158"></a>
-<span class="sourceLineNo">2159</span>        LOG.warn("StoreFile {} has a null Reader", sf);<a name="line.2159"></a>
-<span class="sourceLineNo">2160</span>        return false;<a name="line.2160"></a>
-<span class="sourceLineNo">2161</span>      } else {<a name="line.2161"></a>
-<span class="sourceLineNo">2162</span>        return true;<a name="line.2162"></a>
-<span class="sourceLineNo">2163</span>      }<a name="line.2163"></a>
-<span class="sourceLineNo">2164</span>    }).filter(predicate).mapToLong(sf -&gt; sf.getReader().length()).sum();<a name="line.2164"></a>
+<span class="sourceLineNo">2151</span>  public long getStoreSizeUncompressed() {<a name="line.2151"></a>
+<span class="sourceLineNo">2152</span>    return this.totalUncompressedBytes.get();<a name="line.2152"></a>
+<span class="sourceLineNo">2153</span>  }<a name="line.2153"></a>
+<span class="sourceLineNo">2154</span><a name="line.2154"></a>
+<span class="sourceLineNo">2155</span>  @Override<a name="line.2155"></a>
+<span class="sourceLineNo">2156</span>  public long getStorefilesSize() {<a name="line.2156"></a>
+<span class="sourceLineNo">2157</span>    // Include all StoreFiles<a name="line.2157"></a>
+<span class="sourceLineNo">2158</span>    return getStorefilesSize(storeFile -&gt; true);<a name="line.2158"></a>
+<span class="sourceLineNo">2159</span>  }<a name="line.2159"></a>
+<span class="sourceLineNo">2160</span><a name="line.2160"></a>
+<span class="sourceLineNo">2161</span>  @Override<a name="line.2161"></a>
+<span class="sourceLineNo">2162</span>  public long getHFilesSize() {<a name="line.2162"></a>
+<span class="sourceLineNo">2163</span>    // Include only StoreFiles which are HFiles<a name="line.2163"></a>
+<span class="sourceLineNo">2164</span>    return getStorefilesSize(storeFile -&gt; storeFile.isHFile());<a name="lin

<TRUNCATED>

Mime
View raw message