hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bus...@apache.org
Subject [11/12] hbase git commit: HBASE-20068 personality tests for Apache Yetus should use the maven plugin to exec maven.
Date Wed, 11 Apr 2018 06:32:39 GMT
HBASE-20068 personality tests for Apache Yetus should use the maven plugin to exec maven.

Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Reid Chan <reidddchan@outlook.com>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a69e879c
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a69e879c
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a69e879c

Branch: refs/heads/branch-1.2
Commit: a69e879c6972ef7a955835a7951e422345034292
Parents: c202144
Author: Sean Busbey <busbey@apache.org>
Authored: Sun Apr 8 21:27:58 2018 -0500
Committer: Sean Busbey <busbey@apache.org>
Committed: Wed Apr 11 01:31:25 2018 -0500

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/a69e879c/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 23a834c..19e7e97 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -273,8 +273,10 @@ function refguide_rebuild
 
   start_clock
 
+  # disabled because "maven_executor" needs to return both command and args
+  # shellcheck disable=2046
   echo_and_redirect "${logfile}" \
-    "${MAVEN}" "${MAVEN_ARGS[@]}" clean site --batch-mode \
+    $(maven_executor) clean site --batch-mode \
       -pl . \
       -Dtest=NoUnitTests -DHBasePatchProcess -Prelease \
       -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true
@@ -348,8 +350,10 @@ function shadedjars_rebuild
 
   start_clock
 
+  # disabled because "maven_executor" needs to return both command and args
+  # shellcheck disable=2046
   echo_and_redirect "${logfile}" \
-    "${MAVEN}" "${MAVEN_ARGS[@]}" clean verify -fae --batch-mode \
+    $(maven_executor) clean verify -fae --batch-mode \
       -pl hbase-shaded/hbase-shaded-check-invariants -am \
       -Dtest=NoUnitTests -DHBasePatchProcess -Prelease \
       -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true
@@ -455,8 +459,10 @@ function hadoopcheck_rebuild
   export MAVEN_OPTS="${MAVEN_OPTS}"
   for hadoopver in ${hbase_hadoop2_versions}; do
     logfile="${PATCH_DIR}/patch-javac-${hadoopver}.txt"
+    # disabled because "maven_executor" needs to return both command and args
+    # shellcheck disable=2046
     echo_and_redirect "${logfile}" \
-      "${MAVEN}" clean install \
+      $(maven_executor) clean install \
         -DskipTests -DHBasePatchProcess \
         -Dhadoop-two.version="${hadoopver}"
     count=$(${GREP} -c '\[ERROR\]' "${logfile}")
@@ -469,8 +475,10 @@ function hadoopcheck_rebuild
 
   for hadoopver in ${hbase_hadoop3_versions}; do
     logfile="${PATCH_DIR}/patch-javac-${hadoopver}.txt"
+    # disabled because "maven_executor" needs to return both command and args
+    # shellcheck disable=2046
     echo_and_redirect "${logfile}" \
-      "${MAVEN}" clean install \
+      $(maven_executor) clean install \
         -DskipTests -DHBasePatchProcess \
         -Dhadoop-three.version="${hadoopver}" \
         -Dhadoop.profile=3.0


Mime
View raw message