From commits-return-67124-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Mon Feb 5 05:09:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3591D18064A for ; Mon, 5 Feb 2018 05:09:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 252BF160C5D; Mon, 5 Feb 2018 04:09:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6D59E160C5B for ; Mon, 5 Feb 2018 05:09:02 +0100 (CET) Received: (qmail 14857 invoked by uid 500); 5 Feb 2018 04:09:01 -0000 Mailing-List: contact commits-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list commits@hbase.apache.org Received: (qmail 14266 invoked by uid 99); 5 Feb 2018 04:09:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 04:09:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2F614F2188; Mon, 5 Feb 2018 04:09:00 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: zhangduo@apache.org To: commits@hbase.apache.org Date: Mon, 05 Feb 2018 04:09:04 -0000 Message-Id: In-Reply-To: <4232331453054485a2f3d7ec576cb6f2@git.apache.org> References: <4232331453054485a2f3d7ec576cb6f2@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [05/42] hbase git commit: HBASE-19917 Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient HBASE-19917 Improve RSGroupBasedLoadBalancer#filterServers() to be more efficient Signed-off-by: tedyu Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c2e3d520 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c2e3d520 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c2e3d520 Branch: refs/heads/HBASE-19397-branch-2 Commit: c2e3d52080ed28dbffbb83314dff4a75f072f400 Parents: 30a7e4a Author: Xiang Li Authored: Sat Feb 3 04:46:55 2018 +0000 Committer: tedyu Committed: Sun Feb 4 17:23:06 2018 -0800 ---------------------------------------------------------------------- .../hbase/rsgroup/RSGroupBasedLoadBalancer.java | 22 ++++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/c2e3d520/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ---------------------------------------------------------------------- diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java index 550f734..c47972d 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java @@ -20,7 +20,6 @@ package org.apache.hadoop.hbase.rsgroup; import java.io.IOException; import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.HashMap; import java.util.HashSet; @@ -29,6 +28,7 @@ import java.util.List; import java.util.Map; import java.util.Set; import java.util.TreeMap; + import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.hbase.ClusterMetrics; import org.apache.hadoop.hbase.HBaseIOException; @@ -288,16 +288,20 @@ public class RSGroupBasedLoadBalancer implements RSGroupableBalancer { * List of servers which are online. * @return the list */ - private List filterServers(Collection
servers, - Collection onlineServers) { - ArrayList finalList = new ArrayList(); - for (Address server : servers) { - for(ServerName curr: onlineServers) { - if(curr.getAddress().equals(server)) { - finalList.add(curr); - } + private List filterServers(Set
servers, + List onlineServers) { + /** + * servers is actually a TreeSet (see {@link org.apache.hadoop.hbase.rsgroup.RSGroupInfo}), + * having its contains()'s time complexity as O(logn), which is good enough. + * TODO: consider using HashSet to pursue O(1) for contains() throughout the calling chain + * if needed. */ + ArrayList finalList = new ArrayList<>(); + for (ServerName onlineServer : onlineServers) { + if (servers.contains(onlineServer.getAddress())) { + finalList.add(onlineServer); } } + return finalList; }