hbase-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From git-site-r...@apache.org
Subject [01/42] hbase-site git commit: Published site at .
Date Wed, 07 Feb 2018 15:13:55 GMT
Repository: hbase-site
Updated Branches:
  refs/heads/asf-site 6288fbb1a -> 6bdadd97d


http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6bdadd97/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsWithACL.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsWithACL.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsWithACL.html
index 4e0b33e..c65cbe8 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsWithACL.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsWithACL.html
@@ -46,303 +46,304 @@
 <span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.security.access.Permission;<a name="line.38"></a>
 <span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.security.access.SecureTestUtil;<a name="line.39"></a>
 <span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.security.access.TableAuthManager;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.testclassification.SecurityTests;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.junit.AfterClass;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.junit.BeforeClass;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.junit.ClassRule;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.junit.Test;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.junit.experimental.categories.Category;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.slf4j.Logger;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.slf4j.LoggerFactory;<a name="line.49"></a>
-<span class="sourceLineNo">050</span><a name="line.50"></a>
-<span class="sourceLineNo">051</span>/**<a name="line.51"></a>
-<span class="sourceLineNo">052</span> * Performs authorization checks for rsgroup operations, according to different<a name="line.52"></a>
-<span class="sourceLineNo">053</span> * levels of authorized users.<a name="line.53"></a>
-<span class="sourceLineNo">054</span> */<a name="line.54"></a>
-<span class="sourceLineNo">055</span>@Category({SecurityTests.class})<a name="line.55"></a>
-<span class="sourceLineNo">056</span>public class TestRSGroupsWithACL extends SecureTestUtil{<a name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>  @ClassRule<a name="line.58"></a>
-<span class="sourceLineNo">059</span>  public static final HBaseClassTestRule CLASS_RULE =<a name="line.59"></a>
-<span class="sourceLineNo">060</span>      HBaseClassTestRule.forClass(TestRSGroupsWithACL.class);<a name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span>  private static final Logger LOG = LoggerFactory.getLogger(TestRSGroupsWithACL.class);<a name="line.62"></a>
-<span class="sourceLineNo">063</span>  private static TableName TEST_TABLE = TableName.valueOf("testtable1");<a name="line.63"></a>
-<span class="sourceLineNo">064</span>  private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.64"></a>
-<span class="sourceLineNo">065</span>  private static Configuration conf;<a name="line.65"></a>
-<span class="sourceLineNo">066</span><a name="line.66"></a>
-<span class="sourceLineNo">067</span>  private static Connection systemUserConnection;<a name="line.67"></a>
-<span class="sourceLineNo">068</span>  // user with all permissions<a name="line.68"></a>
-<span class="sourceLineNo">069</span>  private static User SUPERUSER;<a name="line.69"></a>
-<span class="sourceLineNo">070</span>  // user granted with all global permission<a name="line.70"></a>
-<span class="sourceLineNo">071</span>  private static User USER_ADMIN;<a name="line.71"></a>
-<span class="sourceLineNo">072</span>  // user with rw permissions on column family.<a name="line.72"></a>
-<span class="sourceLineNo">073</span>  private static User USER_RW;<a name="line.73"></a>
-<span class="sourceLineNo">074</span>  // user with read-only permissions<a name="line.74"></a>
-<span class="sourceLineNo">075</span>  private static User USER_RO;<a name="line.75"></a>
-<span class="sourceLineNo">076</span>  // user is table owner. will have all permissions on table<a name="line.76"></a>
-<span class="sourceLineNo">077</span>  private static User USER_OWNER;<a name="line.77"></a>
-<span class="sourceLineNo">078</span>  // user with create table permissions alone<a name="line.78"></a>
-<span class="sourceLineNo">079</span>  private static User USER_CREATE;<a name="line.79"></a>
-<span class="sourceLineNo">080</span>  // user with no permissions<a name="line.80"></a>
-<span class="sourceLineNo">081</span>  private static User USER_NONE;<a name="line.81"></a>
-<span class="sourceLineNo">082</span><a name="line.82"></a>
-<span class="sourceLineNo">083</span>  private static final String GROUP_ADMIN = "group_admin";<a name="line.83"></a>
-<span class="sourceLineNo">084</span>  private static final String GROUP_CREATE = "group_create";<a name="line.84"></a>
-<span class="sourceLineNo">085</span>  private static final String GROUP_READ = "group_read";<a name="line.85"></a>
-<span class="sourceLineNo">086</span>  private static final String GROUP_WRITE = "group_write";<a name="line.86"></a>
-<span class="sourceLineNo">087</span><a name="line.87"></a>
-<span class="sourceLineNo">088</span>  private static User USER_GROUP_ADMIN;<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  private static User USER_GROUP_CREATE;<a name="line.89"></a>
-<span class="sourceLineNo">090</span>  private static User USER_GROUP_READ;<a name="line.90"></a>
-<span class="sourceLineNo">091</span>  private static User USER_GROUP_WRITE;<a name="line.91"></a>
-<span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span>  private static byte[] TEST_FAMILY = Bytes.toBytes("f1");<a name="line.93"></a>
-<span class="sourceLineNo">094</span><a name="line.94"></a>
-<span class="sourceLineNo">095</span>  private static RSGroupAdminEndpoint rsGroupAdminEndpoint;<a name="line.95"></a>
-<span class="sourceLineNo">096</span><a name="line.96"></a>
-<span class="sourceLineNo">097</span>  @BeforeClass<a name="line.97"></a>
-<span class="sourceLineNo">098</span>  public static void setupBeforeClass() throws Exception {<a name="line.98"></a>
-<span class="sourceLineNo">099</span>    // setup configuration<a name="line.99"></a>
-<span class="sourceLineNo">100</span>    conf = TEST_UTIL.getConfiguration();<a name="line.100"></a>
-<span class="sourceLineNo">101</span>    conf.set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,<a name="line.101"></a>
-<span class="sourceLineNo">102</span>        RSGroupBasedLoadBalancer.class.getName());<a name="line.102"></a>
-<span class="sourceLineNo">103</span>    // Enable security<a name="line.103"></a>
-<span class="sourceLineNo">104</span>    enableSecurity(conf);<a name="line.104"></a>
-<span class="sourceLineNo">105</span>    // Verify enableSecurity sets up what we require<a name="line.105"></a>
-<span class="sourceLineNo">106</span>    verifyConfiguration(conf);<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    // Enable rsgroup<a name="line.107"></a>
-<span class="sourceLineNo">108</span>    configureRSGroupAdminEndpoint(conf);<a name="line.108"></a>
-<span class="sourceLineNo">109</span><a name="line.109"></a>
-<span class="sourceLineNo">110</span>    TEST_UTIL.startMiniCluster();<a name="line.110"></a>
-<span class="sourceLineNo">111</span>    rsGroupAdminEndpoint = (RSGroupAdminEndpoint) TEST_UTIL.getMiniHBaseCluster().getMaster().<a name="line.111"></a>
-<span class="sourceLineNo">112</span>        getMasterCoprocessorHost().findCoprocessor(RSGroupAdminEndpoint.class.getName());<a name="line.112"></a>
-<span class="sourceLineNo">113</span>    // Wait for the ACL table to become available<a name="line.113"></a>
-<span class="sourceLineNo">114</span>    TEST_UTIL.waitUntilAllRegionsAssigned(AccessControlLists.ACL_TABLE_NAME);<a name="line.114"></a>
-<span class="sourceLineNo">115</span><a name="line.115"></a>
-<span class="sourceLineNo">116</span>    // create a set of test users<a name="line.116"></a>
-<span class="sourceLineNo">117</span>    SUPERUSER = User.createUserForTesting(conf, "admin", new String[] { "supergroup" });<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    USER_ADMIN = User.createUserForTesting(conf, "admin2", new String[0]);<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    USER_RW = User.createUserForTesting(conf, "rwuser", new String[0]);<a name="line.119"></a>
-<span class="sourceLineNo">120</span>    USER_RO = User.createUserForTesting(conf, "rouser", new String[0]);<a name="line.120"></a>
-<span class="sourceLineNo">121</span>    USER_OWNER = User.createUserForTesting(conf, "owner", new String[0]);<a name="line.121"></a>
-<span class="sourceLineNo">122</span>    USER_CREATE = User.createUserForTesting(conf, "tbl_create", new String[0]);<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    USER_NONE = User.createUserForTesting(conf, "nouser", new String[0]);<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span>    USER_GROUP_ADMIN =<a name="line.125"></a>
-<span class="sourceLineNo">126</span>        User.createUserForTesting(conf, "user_group_admin", new String[] { GROUP_ADMIN });<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    USER_GROUP_CREATE =<a name="line.127"></a>
-<span class="sourceLineNo">128</span>        User.createUserForTesting(conf, "user_group_create", new String[] { GROUP_CREATE });<a name="line.128"></a>
-<span class="sourceLineNo">129</span>    USER_GROUP_READ =<a name="line.129"></a>
-<span class="sourceLineNo">130</span>        User.createUserForTesting(conf, "user_group_read", new String[] { GROUP_READ });<a name="line.130"></a>
-<span class="sourceLineNo">131</span>    USER_GROUP_WRITE =<a name="line.131"></a>
-<span class="sourceLineNo">132</span>        User.createUserForTesting(conf, "user_group_write", new String[] { GROUP_WRITE });<a name="line.132"></a>
-<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span>    systemUserConnection = TEST_UTIL.getConnection();<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    setUpTableAndUserPermissions();<a name="line.135"></a>
-<span class="sourceLineNo">136</span>  }<a name="line.136"></a>
-<span class="sourceLineNo">137</span><a name="line.137"></a>
-<span class="sourceLineNo">138</span>  private static void setUpTableAndUserPermissions() throws Exception {<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    TableDescriptorBuilder tableBuilder = TableDescriptorBuilder.newBuilder(TEST_TABLE);<a name="line.139"></a>
-<span class="sourceLineNo">140</span>    ColumnFamilyDescriptorBuilder cfd = ColumnFamilyDescriptorBuilder.newBuilder(TEST_FAMILY);<a name="line.140"></a>
-<span class="sourceLineNo">141</span>    cfd.setMaxVersions(100);<a name="line.141"></a>
-<span class="sourceLineNo">142</span>    tableBuilder.addColumnFamily(cfd.build());<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    tableBuilder.setValue(TableDescriptorBuilder.OWNER, USER_OWNER.getShortName());<a name="line.143"></a>
-<span class="sourceLineNo">144</span>    createTable(TEST_UTIL, tableBuilder.build(),<a name="line.144"></a>
-<span class="sourceLineNo">145</span>        new byte[][] { Bytes.toBytes("s") });<a name="line.145"></a>
-<span class="sourceLineNo">146</span><a name="line.146"></a>
-<span class="sourceLineNo">147</span>    // Set up initial grants<a name="line.147"></a>
-<span class="sourceLineNo">148</span>    grantGlobal(TEST_UTIL, USER_ADMIN.getShortName(),<a name="line.148"></a>
-<span class="sourceLineNo">149</span>        Permission.Action.ADMIN,<a name="line.149"></a>
-<span class="sourceLineNo">150</span>        Permission.Action.CREATE,<a name="line.150"></a>
-<span class="sourceLineNo">151</span>        Permission.Action.READ,<a name="line.151"></a>
-<span class="sourceLineNo">152</span>        Permission.Action.WRITE);<a name="line.152"></a>
-<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span>    grantOnTable(TEST_UTIL, USER_RW.getShortName(),<a name="line.154"></a>
-<span class="sourceLineNo">155</span>        TEST_TABLE, TEST_FAMILY, null,<a name="line.155"></a>
-<span class="sourceLineNo">156</span>        Permission.Action.READ,<a name="line.156"></a>
-<span class="sourceLineNo">157</span>        Permission.Action.WRITE);<a name="line.157"></a>
-<span class="sourceLineNo">158</span><a name="line.158"></a>
-<span class="sourceLineNo">159</span>    // USER_CREATE is USER_RW plus CREATE permissions<a name="line.159"></a>
-<span class="sourceLineNo">160</span>    grantOnTable(TEST_UTIL, USER_CREATE.getShortName(),<a name="line.160"></a>
-<span class="sourceLineNo">161</span>        TEST_TABLE, null, null,<a name="line.161"></a>
-<span class="sourceLineNo">162</span>        Permission.Action.CREATE,<a name="line.162"></a>
-<span class="sourceLineNo">163</span>        Permission.Action.READ,<a name="line.163"></a>
-<span class="sourceLineNo">164</span>        Permission.Action.WRITE);<a name="line.164"></a>
-<span class="sourceLineNo">165</span><a name="line.165"></a>
-<span class="sourceLineNo">166</span>    grantOnTable(TEST_UTIL, USER_RO.getShortName(),<a name="line.166"></a>
-<span class="sourceLineNo">167</span>        TEST_TABLE, TEST_FAMILY, null,<a name="line.167"></a>
-<span class="sourceLineNo">168</span>        Permission.Action.READ);<a name="line.168"></a>
-<span class="sourceLineNo">169</span><a name="line.169"></a>
-<span class="sourceLineNo">170</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_ADMIN), Permission.Action.ADMIN);<a name="line.170"></a>
-<span class="sourceLineNo">171</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_CREATE), Permission.Action.CREATE);<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_READ), Permission.Action.READ);<a name="line.172"></a>
-<span class="sourceLineNo">173</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_WRITE), Permission.Action.WRITE);<a name="line.173"></a>
-<span class="sourceLineNo">174</span><a name="line.174"></a>
-<span class="sourceLineNo">175</span>    assertEquals(4, AccessControlLists.getTablePermissions(conf, TEST_TABLE).size());<a name="line.175"></a>
-<span class="sourceLineNo">176</span>    try {<a name="line.176"></a>
-<span class="sourceLineNo">177</span>      assertEquals(4, AccessControlClient.getUserPermissions(systemUserConnection,<a name="line.177"></a>
-<span class="sourceLineNo">178</span>          TEST_TABLE.toString()).size());<a name="line.178"></a>
-<span class="sourceLineNo">179</span>    } catch (Throwable e) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span>      LOG.error("error during call of AccessControlClient.getUserPermissions. ", e);<a name="line.180"></a>
-<span class="sourceLineNo">181</span>      fail("error during call of AccessControlClient.getUserPermissions.");<a name="line.181"></a>
-<span class="sourceLineNo">182</span>    }<a name="line.182"></a>
-<span class="sourceLineNo">183</span>  }<a name="line.183"></a>
-<span class="sourceLineNo">184</span><a name="line.184"></a>
-<span class="sourceLineNo">185</span>  private static void cleanUp() throws Exception {<a name="line.185"></a>
-<span class="sourceLineNo">186</span>    // Clean the _acl_ table<a name="line.186"></a>
-<span class="sourceLineNo">187</span>    try {<a name="line.187"></a>
-<span class="sourceLineNo">188</span>      deleteTable(TEST_UTIL, TEST_TABLE);<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    } catch (TableNotFoundException ex) {<a name="line.189"></a>
-<span class="sourceLineNo">190</span>      // Test deleted the table, no problem<a name="line.190"></a>
-<span class="sourceLineNo">191</span>      LOG.info("Test deleted table " + TEST_TABLE);<a name="line.191"></a>
-<span class="sourceLineNo">192</span>    }<a name="line.192"></a>
-<span class="sourceLineNo">193</span>    // Verify all table/namespace permissions are erased<a name="line.193"></a>
-<span class="sourceLineNo">194</span>    assertEquals(0, AccessControlLists.getTablePermissions(conf, TEST_TABLE).size());<a name="line.194"></a>
-<span class="sourceLineNo">195</span>    assertEquals(0, AccessControlLists.getNamespacePermissions(conf,<a name="line.195"></a>
-<span class="sourceLineNo">196</span>            TEST_TABLE.getNamespaceAsString()).size());<a name="line.196"></a>
-<span class="sourceLineNo">197</span>  }<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span>  @AfterClass<a name="line.199"></a>
-<span class="sourceLineNo">200</span>  public static void tearDownAfterClass() throws Exception {<a name="line.200"></a>
-<span class="sourceLineNo">201</span>    cleanUp();<a name="line.201"></a>
-<span class="sourceLineNo">202</span>    TEST_UTIL.shutdownMiniCluster();<a name="line.202"></a>
-<span class="sourceLineNo">203</span>    int total = TableAuthManager.getTotalRefCount();<a name="line.203"></a>
-<span class="sourceLineNo">204</span>    assertTrue("Unexpected reference count: " + total, total == 0);<a name="line.204"></a>
-<span class="sourceLineNo">205</span>  }<a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span>  private static void configureRSGroupAdminEndpoint(Configuration conf) {<a name="line.207"></a>
-<span class="sourceLineNo">208</span>    String currentCoprocessors = conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY);<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    String coprocessors = RSGroupAdminEndpoint.class.getName();<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    if (currentCoprocessors != null) {<a name="line.210"></a>
-<span class="sourceLineNo">211</span>      coprocessors += "," + currentCoprocessors;<a name="line.211"></a>
-<span class="sourceLineNo">212</span>    }<a name="line.212"></a>
-<span class="sourceLineNo">213</span>    conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, coprocessors);<a name="line.213"></a>
-<span class="sourceLineNo">214</span>    conf.set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,<a name="line.214"></a>
-<span class="sourceLineNo">215</span>        RSGroupBasedLoadBalancer.class.getName());<a name="line.215"></a>
-<span class="sourceLineNo">216</span>  }<a name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span>  @Test<a name="line.218"></a>
-<span class="sourceLineNo">219</span>  public void testGetRSGroupInfo() throws Exception {<a name="line.219"></a>
-<span class="sourceLineNo">220</span>    AccessTestAction action = () -&gt; {<a name="line.220"></a>
-<span class="sourceLineNo">221</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfo");<a name="line.221"></a>
-<span class="sourceLineNo">222</span>      return null;<a name="line.222"></a>
-<span class="sourceLineNo">223</span>    };<a name="line.223"></a>
-<span class="sourceLineNo">224</span><a name="line.224"></a>
-<span class="sourceLineNo">225</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.225"></a>
-<span class="sourceLineNo">226</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.226"></a>
-<span class="sourceLineNo">227</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.227"></a>
-<span class="sourceLineNo">228</span>  }<a name="line.228"></a>
-<span class="sourceLineNo">229</span><a name="line.229"></a>
-<span class="sourceLineNo">230</span>  @Test<a name="line.230"></a>
-<span class="sourceLineNo">231</span>  public void testGetRSGroupInfoOfTable() throws Exception {<a name="line.231"></a>
-<span class="sourceLineNo">232</span>    AccessTestAction action = () -&gt; {<a name="line.232"></a>
-<span class="sourceLineNo">233</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfoOfTable");<a name="line.233"></a>
-<span class="sourceLineNo">234</span>      return null;<a name="line.234"></a>
-<span class="sourceLineNo">235</span>    };<a name="line.235"></a>
-<span class="sourceLineNo">236</span><a name="line.236"></a>
-<span class="sourceLineNo">237</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.237"></a>
-<span class="sourceLineNo">238</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.238"></a>
-<span class="sourceLineNo">239</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.239"></a>
-<span class="sourceLineNo">240</span>  }<a name="line.240"></a>
-<span class="sourceLineNo">241</span><a name="line.241"></a>
-<span class="sourceLineNo">242</span>  @Test<a name="line.242"></a>
-<span class="sourceLineNo">243</span>  public void testMoveServers() throws Exception {<a name="line.243"></a>
-<span class="sourceLineNo">244</span>    AccessTestAction action = () -&gt; {<a name="line.244"></a>
-<span class="sourceLineNo">245</span>      rsGroupAdminEndpoint.checkPermission("moveServers");<a name="line.245"></a>
-<span class="sourceLineNo">246</span>      return null;<a name="line.246"></a>
-<span class="sourceLineNo">247</span>    };<a name="line.247"></a>
-<span class="sourceLineNo">248</span><a name="line.248"></a>
-<span class="sourceLineNo">249</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.249"></a>
-<span class="sourceLineNo">250</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.250"></a>
-<span class="sourceLineNo">251</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.251"></a>
-<span class="sourceLineNo">252</span>  }<a name="line.252"></a>
-<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span>  @Test<a name="line.254"></a>
-<span class="sourceLineNo">255</span>  public void testMoveTables() throws Exception {<a name="line.255"></a>
-<span class="sourceLineNo">256</span>    AccessTestAction action = () -&gt; {<a name="line.256"></a>
-<span class="sourceLineNo">257</span>      rsGroupAdminEndpoint.checkPermission("moveTables");<a name="line.257"></a>
-<span class="sourceLineNo">258</span>      return null;<a name="line.258"></a>
-<span class="sourceLineNo">259</span>    };<a name="line.259"></a>
-<span class="sourceLineNo">260</span><a name="line.260"></a>
-<span class="sourceLineNo">261</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.261"></a>
-<span class="sourceLineNo">262</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.262"></a>
-<span class="sourceLineNo">263</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.263"></a>
-<span class="sourceLineNo">264</span>  }<a name="line.264"></a>
-<span class="sourceLineNo">265</span><a name="line.265"></a>
-<span class="sourceLineNo">266</span>  @Test<a name="line.266"></a>
-<span class="sourceLineNo">267</span>  public void testAddRSGroup() throws Exception {<a name="line.267"></a>
-<span class="sourceLineNo">268</span>    AccessTestAction action = () -&gt; {<a name="line.268"></a>
-<span class="sourceLineNo">269</span>      rsGroupAdminEndpoint.checkPermission("addRSGroup");<a name="line.269"></a>
-<span class="sourceLineNo">270</span>      return null;<a name="line.270"></a>
-<span class="sourceLineNo">271</span>    };<a name="line.271"></a>
-<span class="sourceLineNo">272</span><a name="line.272"></a>
-<span class="sourceLineNo">273</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.273"></a>
-<span class="sourceLineNo">274</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.274"></a>
-<span class="sourceLineNo">275</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.275"></a>
-<span class="sourceLineNo">276</span>  }<a name="line.276"></a>
-<span class="sourceLineNo">277</span><a name="line.277"></a>
-<span class="sourceLineNo">278</span>  @Test<a name="line.278"></a>
-<span class="sourceLineNo">279</span>  public void testRemoveRSGroup() throws Exception {<a name="line.279"></a>
-<span class="sourceLineNo">280</span>    AccessTestAction action = () -&gt; {<a name="line.280"></a>
-<span class="sourceLineNo">281</span>      rsGroupAdminEndpoint.checkPermission("removeRSGroup");<a name="line.281"></a>
-<span class="sourceLineNo">282</span>      return null;<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    };<a name="line.283"></a>
-<span class="sourceLineNo">284</span><a name="line.284"></a>
-<span class="sourceLineNo">285</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.285"></a>
-<span class="sourceLineNo">286</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.286"></a>
-<span class="sourceLineNo">287</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.287"></a>
-<span class="sourceLineNo">288</span>  }<a name="line.288"></a>
-<span class="sourceLineNo">289</span><a name="line.289"></a>
-<span class="sourceLineNo">290</span>  @Test<a name="line.290"></a>
-<span class="sourceLineNo">291</span>  public void testBalanceRSGroup() throws Exception {<a name="line.291"></a>
-<span class="sourceLineNo">292</span>    AccessTestAction action = () -&gt; {<a name="line.292"></a>
-<span class="sourceLineNo">293</span>      rsGroupAdminEndpoint.checkPermission("balanceRSGroup");<a name="line.293"></a>
-<span class="sourceLineNo">294</span>      return null;<a name="line.294"></a>
-<span class="sourceLineNo">295</span>    };<a name="line.295"></a>
-<span class="sourceLineNo">296</span><a name="line.296"></a>
-<span class="sourceLineNo">297</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.297"></a>
-<span class="sourceLineNo">298</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.298"></a>
-<span class="sourceLineNo">299</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.299"></a>
-<span class="sourceLineNo">300</span>  }<a name="line.300"></a>
-<span class="sourceLineNo">301</span><a name="line.301"></a>
-<span class="sourceLineNo">302</span>  @Test<a name="line.302"></a>
-<span class="sourceLineNo">303</span>  public void testListRSGroup() throws Exception {<a name="line.303"></a>
-<span class="sourceLineNo">304</span>    AccessTestAction action = () -&gt; {<a name="line.304"></a>
-<span class="sourceLineNo">305</span>      rsGroupAdminEndpoint.checkPermission("listRSGroup");<a name="line.305"></a>
-<span class="sourceLineNo">306</span>      return null;<a name="line.306"></a>
-<span class="sourceLineNo">307</span>    };<a name="line.307"></a>
-<span class="sourceLineNo">308</span><a name="line.308"></a>
-<span class="sourceLineNo">309</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.309"></a>
-<span class="sourceLineNo">310</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.310"></a>
-<span class="sourceLineNo">311</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.311"></a>
-<span class="sourceLineNo">312</span>  }<a name="line.312"></a>
-<span class="sourceLineNo">313</span><a name="line.313"></a>
-<span class="sourceLineNo">314</span>  @Test<a name="line.314"></a>
-<span class="sourceLineNo">315</span>  public void testGetRSGroupInfoOfServer() throws Exception {<a name="line.315"></a>
-<span class="sourceLineNo">316</span>    AccessTestAction action = () -&gt; {<a name="line.316"></a>
-<span class="sourceLineNo">317</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfoOfServer");<a name="line.317"></a>
-<span class="sourceLineNo">318</span>      return null;<a name="line.318"></a>
-<span class="sourceLineNo">319</span>    };<a name="line.319"></a>
-<span class="sourceLineNo">320</span><a name="line.320"></a>
-<span class="sourceLineNo">321</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.321"></a>
-<span class="sourceLineNo">322</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.322"></a>
-<span class="sourceLineNo">323</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.323"></a>
-<span class="sourceLineNo">324</span>  }<a name="line.324"></a>
-<span class="sourceLineNo">325</span><a name="line.325"></a>
-<span class="sourceLineNo">326</span>  @Test<a name="line.326"></a>
-<span class="sourceLineNo">327</span>  public void testMoveServersAndTables() throws Exception {<a name="line.327"></a>
-<span class="sourceLineNo">328</span>    AccessTestAction action = () -&gt; {<a name="line.328"></a>
-<span class="sourceLineNo">329</span>      rsGroupAdminEndpoint.checkPermission("moveServersAndTables");<a name="line.329"></a>
-<span class="sourceLineNo">330</span>      return null;<a name="line.330"></a>
-<span class="sourceLineNo">331</span>    };<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.333"></a>
-<span class="sourceLineNo">334</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.334"></a>
-<span class="sourceLineNo">335</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.335"></a>
-<span class="sourceLineNo">336</span>  }<a name="line.336"></a>
-<span class="sourceLineNo">337</span>}<a name="line.337"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.testclassification.SecurityTests;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.junit.AfterClass;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.junit.BeforeClass;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.junit.ClassRule;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.junit.Test;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.experimental.categories.Category;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.slf4j.Logger;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.slf4j.LoggerFactory;<a name="line.50"></a>
+<span class="sourceLineNo">051</span><a name="line.51"></a>
+<span class="sourceLineNo">052</span>/**<a name="line.52"></a>
+<span class="sourceLineNo">053</span> * Performs authorization checks for rsgroup operations, according to different<a name="line.53"></a>
+<span class="sourceLineNo">054</span> * levels of authorized users.<a name="line.54"></a>
+<span class="sourceLineNo">055</span> */<a name="line.55"></a>
+<span class="sourceLineNo">056</span>@Category({SecurityTests.class, MediumTests.class})<a name="line.56"></a>
+<span class="sourceLineNo">057</span>public class TestRSGroupsWithACL extends SecureTestUtil{<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span>  @ClassRule<a name="line.59"></a>
+<span class="sourceLineNo">060</span>  public static final HBaseClassTestRule CLASS_RULE =<a name="line.60"></a>
+<span class="sourceLineNo">061</span>      HBaseClassTestRule.forClass(TestRSGroupsWithACL.class);<a name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span>  private static final Logger LOG = LoggerFactory.getLogger(TestRSGroupsWithACL.class);<a name="line.63"></a>
+<span class="sourceLineNo">064</span>  private static TableName TEST_TABLE = TableName.valueOf("testtable1");<a name="line.64"></a>
+<span class="sourceLineNo">065</span>  private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.65"></a>
+<span class="sourceLineNo">066</span>  private static Configuration conf;<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span>  private static Connection systemUserConnection;<a name="line.68"></a>
+<span class="sourceLineNo">069</span>  // user with all permissions<a name="line.69"></a>
+<span class="sourceLineNo">070</span>  private static User SUPERUSER;<a name="line.70"></a>
+<span class="sourceLineNo">071</span>  // user granted with all global permission<a name="line.71"></a>
+<span class="sourceLineNo">072</span>  private static User USER_ADMIN;<a name="line.72"></a>
+<span class="sourceLineNo">073</span>  // user with rw permissions on column family.<a name="line.73"></a>
+<span class="sourceLineNo">074</span>  private static User USER_RW;<a name="line.74"></a>
+<span class="sourceLineNo">075</span>  // user with read-only permissions<a name="line.75"></a>
+<span class="sourceLineNo">076</span>  private static User USER_RO;<a name="line.76"></a>
+<span class="sourceLineNo">077</span>  // user is table owner. will have all permissions on table<a name="line.77"></a>
+<span class="sourceLineNo">078</span>  private static User USER_OWNER;<a name="line.78"></a>
+<span class="sourceLineNo">079</span>  // user with create table permissions alone<a name="line.79"></a>
+<span class="sourceLineNo">080</span>  private static User USER_CREATE;<a name="line.80"></a>
+<span class="sourceLineNo">081</span>  // user with no permissions<a name="line.81"></a>
+<span class="sourceLineNo">082</span>  private static User USER_NONE;<a name="line.82"></a>
+<span class="sourceLineNo">083</span><a name="line.83"></a>
+<span class="sourceLineNo">084</span>  private static final String GROUP_ADMIN = "group_admin";<a name="line.84"></a>
+<span class="sourceLineNo">085</span>  private static final String GROUP_CREATE = "group_create";<a name="line.85"></a>
+<span class="sourceLineNo">086</span>  private static final String GROUP_READ = "group_read";<a name="line.86"></a>
+<span class="sourceLineNo">087</span>  private static final String GROUP_WRITE = "group_write";<a name="line.87"></a>
+<span class="sourceLineNo">088</span><a name="line.88"></a>
+<span class="sourceLineNo">089</span>  private static User USER_GROUP_ADMIN;<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  private static User USER_GROUP_CREATE;<a name="line.90"></a>
+<span class="sourceLineNo">091</span>  private static User USER_GROUP_READ;<a name="line.91"></a>
+<span class="sourceLineNo">092</span>  private static User USER_GROUP_WRITE;<a name="line.92"></a>
+<span class="sourceLineNo">093</span><a name="line.93"></a>
+<span class="sourceLineNo">094</span>  private static byte[] TEST_FAMILY = Bytes.toBytes("f1");<a name="line.94"></a>
+<span class="sourceLineNo">095</span><a name="line.95"></a>
+<span class="sourceLineNo">096</span>  private static RSGroupAdminEndpoint rsGroupAdminEndpoint;<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span>  @BeforeClass<a name="line.98"></a>
+<span class="sourceLineNo">099</span>  public static void setupBeforeClass() throws Exception {<a name="line.99"></a>
+<span class="sourceLineNo">100</span>    // setup configuration<a name="line.100"></a>
+<span class="sourceLineNo">101</span>    conf = TEST_UTIL.getConfiguration();<a name="line.101"></a>
+<span class="sourceLineNo">102</span>    conf.set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,<a name="line.102"></a>
+<span class="sourceLineNo">103</span>        RSGroupBasedLoadBalancer.class.getName());<a name="line.103"></a>
+<span class="sourceLineNo">104</span>    // Enable security<a name="line.104"></a>
+<span class="sourceLineNo">105</span>    enableSecurity(conf);<a name="line.105"></a>
+<span class="sourceLineNo">106</span>    // Verify enableSecurity sets up what we require<a name="line.106"></a>
+<span class="sourceLineNo">107</span>    verifyConfiguration(conf);<a name="line.107"></a>
+<span class="sourceLineNo">108</span>    // Enable rsgroup<a name="line.108"></a>
+<span class="sourceLineNo">109</span>    configureRSGroupAdminEndpoint(conf);<a name="line.109"></a>
+<span class="sourceLineNo">110</span><a name="line.110"></a>
+<span class="sourceLineNo">111</span>    TEST_UTIL.startMiniCluster();<a name="line.111"></a>
+<span class="sourceLineNo">112</span>    rsGroupAdminEndpoint = (RSGroupAdminEndpoint) TEST_UTIL.getMiniHBaseCluster().getMaster().<a name="line.112"></a>
+<span class="sourceLineNo">113</span>        getMasterCoprocessorHost().findCoprocessor(RSGroupAdminEndpoint.class.getName());<a name="line.113"></a>
+<span class="sourceLineNo">114</span>    // Wait for the ACL table to become available<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    TEST_UTIL.waitUntilAllRegionsAssigned(AccessControlLists.ACL_TABLE_NAME);<a name="line.115"></a>
+<span class="sourceLineNo">116</span><a name="line.116"></a>
+<span class="sourceLineNo">117</span>    // create a set of test users<a name="line.117"></a>
+<span class="sourceLineNo">118</span>    SUPERUSER = User.createUserForTesting(conf, "admin", new String[] { "supergroup" });<a name="line.118"></a>
+<span class="sourceLineNo">119</span>    USER_ADMIN = User.createUserForTesting(conf, "admin2", new String[0]);<a name="line.119"></a>
+<span class="sourceLineNo">120</span>    USER_RW = User.createUserForTesting(conf, "rwuser", new String[0]);<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    USER_RO = User.createUserForTesting(conf, "rouser", new String[0]);<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    USER_OWNER = User.createUserForTesting(conf, "owner", new String[0]);<a name="line.122"></a>
+<span class="sourceLineNo">123</span>    USER_CREATE = User.createUserForTesting(conf, "tbl_create", new String[0]);<a name="line.123"></a>
+<span class="sourceLineNo">124</span>    USER_NONE = User.createUserForTesting(conf, "nouser", new String[0]);<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>    USER_GROUP_ADMIN =<a name="line.126"></a>
+<span class="sourceLineNo">127</span>        User.createUserForTesting(conf, "user_group_admin", new String[] { GROUP_ADMIN });<a name="line.127"></a>
+<span class="sourceLineNo">128</span>    USER_GROUP_CREATE =<a name="line.128"></a>
+<span class="sourceLineNo">129</span>        User.createUserForTesting(conf, "user_group_create", new String[] { GROUP_CREATE });<a name="line.129"></a>
+<span class="sourceLineNo">130</span>    USER_GROUP_READ =<a name="line.130"></a>
+<span class="sourceLineNo">131</span>        User.createUserForTesting(conf, "user_group_read", new String[] { GROUP_READ });<a name="line.131"></a>
+<span class="sourceLineNo">132</span>    USER_GROUP_WRITE =<a name="line.132"></a>
+<span class="sourceLineNo">133</span>        User.createUserForTesting(conf, "user_group_write", new String[] { GROUP_WRITE });<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span>    systemUserConnection = TEST_UTIL.getConnection();<a name="line.135"></a>
+<span class="sourceLineNo">136</span>    setUpTableAndUserPermissions();<a name="line.136"></a>
+<span class="sourceLineNo">137</span>  }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span>  private static void setUpTableAndUserPermissions() throws Exception {<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    TableDescriptorBuilder tableBuilder = TableDescriptorBuilder.newBuilder(TEST_TABLE);<a name="line.140"></a>
+<span class="sourceLineNo">141</span>    ColumnFamilyDescriptorBuilder cfd = ColumnFamilyDescriptorBuilder.newBuilder(TEST_FAMILY);<a name="line.141"></a>
+<span class="sourceLineNo">142</span>    cfd.setMaxVersions(100);<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    tableBuilder.addColumnFamily(cfd.build());<a name="line.143"></a>
+<span class="sourceLineNo">144</span>    tableBuilder.setValue(TableDescriptorBuilder.OWNER, USER_OWNER.getShortName());<a name="line.144"></a>
+<span class="sourceLineNo">145</span>    createTable(TEST_UTIL, tableBuilder.build(),<a name="line.145"></a>
+<span class="sourceLineNo">146</span>        new byte[][] { Bytes.toBytes("s") });<a name="line.146"></a>
+<span class="sourceLineNo">147</span><a name="line.147"></a>
+<span class="sourceLineNo">148</span>    // Set up initial grants<a name="line.148"></a>
+<span class="sourceLineNo">149</span>    grantGlobal(TEST_UTIL, USER_ADMIN.getShortName(),<a name="line.149"></a>
+<span class="sourceLineNo">150</span>        Permission.Action.ADMIN,<a name="line.150"></a>
+<span class="sourceLineNo">151</span>        Permission.Action.CREATE,<a name="line.151"></a>
+<span class="sourceLineNo">152</span>        Permission.Action.READ,<a name="line.152"></a>
+<span class="sourceLineNo">153</span>        Permission.Action.WRITE);<a name="line.153"></a>
+<span class="sourceLineNo">154</span><a name="line.154"></a>
+<span class="sourceLineNo">155</span>    grantOnTable(TEST_UTIL, USER_RW.getShortName(),<a name="line.155"></a>
+<span class="sourceLineNo">156</span>        TEST_TABLE, TEST_FAMILY, null,<a name="line.156"></a>
+<span class="sourceLineNo">157</span>        Permission.Action.READ,<a name="line.157"></a>
+<span class="sourceLineNo">158</span>        Permission.Action.WRITE);<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span>    // USER_CREATE is USER_RW plus CREATE permissions<a name="line.160"></a>
+<span class="sourceLineNo">161</span>    grantOnTable(TEST_UTIL, USER_CREATE.getShortName(),<a name="line.161"></a>
+<span class="sourceLineNo">162</span>        TEST_TABLE, null, null,<a name="line.162"></a>
+<span class="sourceLineNo">163</span>        Permission.Action.CREATE,<a name="line.163"></a>
+<span class="sourceLineNo">164</span>        Permission.Action.READ,<a name="line.164"></a>
+<span class="sourceLineNo">165</span>        Permission.Action.WRITE);<a name="line.165"></a>
+<span class="sourceLineNo">166</span><a name="line.166"></a>
+<span class="sourceLineNo">167</span>    grantOnTable(TEST_UTIL, USER_RO.getShortName(),<a name="line.167"></a>
+<span class="sourceLineNo">168</span>        TEST_TABLE, TEST_FAMILY, null,<a name="line.168"></a>
+<span class="sourceLineNo">169</span>        Permission.Action.READ);<a name="line.169"></a>
+<span class="sourceLineNo">170</span><a name="line.170"></a>
+<span class="sourceLineNo">171</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_ADMIN), Permission.Action.ADMIN);<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_CREATE), Permission.Action.CREATE);<a name="line.172"></a>
+<span class="sourceLineNo">173</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_READ), Permission.Action.READ);<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    grantGlobal(TEST_UTIL, toGroupEntry(GROUP_WRITE), Permission.Action.WRITE);<a name="line.174"></a>
+<span class="sourceLineNo">175</span><a name="line.175"></a>
+<span class="sourceLineNo">176</span>    assertEquals(4, AccessControlLists.getTablePermissions(conf, TEST_TABLE).size());<a name="line.176"></a>
+<span class="sourceLineNo">177</span>    try {<a name="line.177"></a>
+<span class="sourceLineNo">178</span>      assertEquals(4, AccessControlClient.getUserPermissions(systemUserConnection,<a name="line.178"></a>
+<span class="sourceLineNo">179</span>          TEST_TABLE.toString()).size());<a name="line.179"></a>
+<span class="sourceLineNo">180</span>    } catch (Throwable e) {<a name="line.180"></a>
+<span class="sourceLineNo">181</span>      LOG.error("error during call of AccessControlClient.getUserPermissions. ", e);<a name="line.181"></a>
+<span class="sourceLineNo">182</span>      fail("error during call of AccessControlClient.getUserPermissions.");<a name="line.182"></a>
+<span class="sourceLineNo">183</span>    }<a name="line.183"></a>
+<span class="sourceLineNo">184</span>  }<a name="line.184"></a>
+<span class="sourceLineNo">185</span><a name="line.185"></a>
+<span class="sourceLineNo">186</span>  private static void cleanUp() throws Exception {<a name="line.186"></a>
+<span class="sourceLineNo">187</span>    // Clean the _acl_ table<a name="line.187"></a>
+<span class="sourceLineNo">188</span>    try {<a name="line.188"></a>
+<span class="sourceLineNo">189</span>      deleteTable(TEST_UTIL, TEST_TABLE);<a name="line.189"></a>
+<span class="sourceLineNo">190</span>    } catch (TableNotFoundException ex) {<a name="line.190"></a>
+<span class="sourceLineNo">191</span>      // Test deleted the table, no problem<a name="line.191"></a>
+<span class="sourceLineNo">192</span>      LOG.info("Test deleted table " + TEST_TABLE);<a name="line.192"></a>
+<span class="sourceLineNo">193</span>    }<a name="line.193"></a>
+<span class="sourceLineNo">194</span>    // Verify all table/namespace permissions are erased<a name="line.194"></a>
+<span class="sourceLineNo">195</span>    assertEquals(0, AccessControlLists.getTablePermissions(conf, TEST_TABLE).size());<a name="line.195"></a>
+<span class="sourceLineNo">196</span>    assertEquals(0, AccessControlLists.getNamespacePermissions(conf,<a name="line.196"></a>
+<span class="sourceLineNo">197</span>            TEST_TABLE.getNamespaceAsString()).size());<a name="line.197"></a>
+<span class="sourceLineNo">198</span>  }<a name="line.198"></a>
+<span class="sourceLineNo">199</span><a name="line.199"></a>
+<span class="sourceLineNo">200</span>  @AfterClass<a name="line.200"></a>
+<span class="sourceLineNo">201</span>  public static void tearDownAfterClass() throws Exception {<a name="line.201"></a>
+<span class="sourceLineNo">202</span>    cleanUp();<a name="line.202"></a>
+<span class="sourceLineNo">203</span>    TEST_UTIL.shutdownMiniCluster();<a name="line.203"></a>
+<span class="sourceLineNo">204</span>    int total = TableAuthManager.getTotalRefCount();<a name="line.204"></a>
+<span class="sourceLineNo">205</span>    assertTrue("Unexpected reference count: " + total, total == 0);<a name="line.205"></a>
+<span class="sourceLineNo">206</span>  }<a name="line.206"></a>
+<span class="sourceLineNo">207</span><a name="line.207"></a>
+<span class="sourceLineNo">208</span>  private static void configureRSGroupAdminEndpoint(Configuration conf) {<a name="line.208"></a>
+<span class="sourceLineNo">209</span>    String currentCoprocessors = conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY);<a name="line.209"></a>
+<span class="sourceLineNo">210</span>    String coprocessors = RSGroupAdminEndpoint.class.getName();<a name="line.210"></a>
+<span class="sourceLineNo">211</span>    if (currentCoprocessors != null) {<a name="line.211"></a>
+<span class="sourceLineNo">212</span>      coprocessors += "," + currentCoprocessors;<a name="line.212"></a>
+<span class="sourceLineNo">213</span>    }<a name="line.213"></a>
+<span class="sourceLineNo">214</span>    conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, coprocessors);<a name="line.214"></a>
+<span class="sourceLineNo">215</span>    conf.set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,<a name="line.215"></a>
+<span class="sourceLineNo">216</span>        RSGroupBasedLoadBalancer.class.getName());<a name="line.216"></a>
+<span class="sourceLineNo">217</span>  }<a name="line.217"></a>
+<span class="sourceLineNo">218</span><a name="line.218"></a>
+<span class="sourceLineNo">219</span>  @Test<a name="line.219"></a>
+<span class="sourceLineNo">220</span>  public void testGetRSGroupInfo() throws Exception {<a name="line.220"></a>
+<span class="sourceLineNo">221</span>    AccessTestAction action = () -&gt; {<a name="line.221"></a>
+<span class="sourceLineNo">222</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfo");<a name="line.222"></a>
+<span class="sourceLineNo">223</span>      return null;<a name="line.223"></a>
+<span class="sourceLineNo">224</span>    };<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.226"></a>
+<span class="sourceLineNo">227</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.227"></a>
+<span class="sourceLineNo">228</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.228"></a>
+<span class="sourceLineNo">229</span>  }<a name="line.229"></a>
+<span class="sourceLineNo">230</span><a name="line.230"></a>
+<span class="sourceLineNo">231</span>  @Test<a name="line.231"></a>
+<span class="sourceLineNo">232</span>  public void testGetRSGroupInfoOfTable() throws Exception {<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    AccessTestAction action = () -&gt; {<a name="line.233"></a>
+<span class="sourceLineNo">234</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfoOfTable");<a name="line.234"></a>
+<span class="sourceLineNo">235</span>      return null;<a name="line.235"></a>
+<span class="sourceLineNo">236</span>    };<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.238"></a>
+<span class="sourceLineNo">239</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.239"></a>
+<span class="sourceLineNo">240</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.240"></a>
+<span class="sourceLineNo">241</span>  }<a name="line.241"></a>
+<span class="sourceLineNo">242</span><a name="line.242"></a>
+<span class="sourceLineNo">243</span>  @Test<a name="line.243"></a>
+<span class="sourceLineNo">244</span>  public void testMoveServers() throws Exception {<a name="line.244"></a>
+<span class="sourceLineNo">245</span>    AccessTestAction action = () -&gt; {<a name="line.245"></a>
+<span class="sourceLineNo">246</span>      rsGroupAdminEndpoint.checkPermission("moveServers");<a name="line.246"></a>
+<span class="sourceLineNo">247</span>      return null;<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    };<a name="line.248"></a>
+<span class="sourceLineNo">249</span><a name="line.249"></a>
+<span class="sourceLineNo">250</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.250"></a>
+<span class="sourceLineNo">251</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.251"></a>
+<span class="sourceLineNo">252</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.252"></a>
+<span class="sourceLineNo">253</span>  }<a name="line.253"></a>
+<span class="sourceLineNo">254</span><a name="line.254"></a>
+<span class="sourceLineNo">255</span>  @Test<a name="line.255"></a>
+<span class="sourceLineNo">256</span>  public void testMoveTables() throws Exception {<a name="line.256"></a>
+<span class="sourceLineNo">257</span>    AccessTestAction action = () -&gt; {<a name="line.257"></a>
+<span class="sourceLineNo">258</span>      rsGroupAdminEndpoint.checkPermission("moveTables");<a name="line.258"></a>
+<span class="sourceLineNo">259</span>      return null;<a name="line.259"></a>
+<span class="sourceLineNo">260</span>    };<a name="line.260"></a>
+<span class="sourceLineNo">261</span><a name="line.261"></a>
+<span class="sourceLineNo">262</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.262"></a>
+<span class="sourceLineNo">263</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.263"></a>
+<span class="sourceLineNo">264</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.264"></a>
+<span class="sourceLineNo">265</span>  }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span>  @Test<a name="line.267"></a>
+<span class="sourceLineNo">268</span>  public void testAddRSGroup() throws Exception {<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    AccessTestAction action = () -&gt; {<a name="line.269"></a>
+<span class="sourceLineNo">270</span>      rsGroupAdminEndpoint.checkPermission("addRSGroup");<a name="line.270"></a>
+<span class="sourceLineNo">271</span>      return null;<a name="line.271"></a>
+<span class="sourceLineNo">272</span>    };<a name="line.272"></a>
+<span class="sourceLineNo">273</span><a name="line.273"></a>
+<span class="sourceLineNo">274</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.274"></a>
+<span class="sourceLineNo">275</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.275"></a>
+<span class="sourceLineNo">276</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.276"></a>
+<span class="sourceLineNo">277</span>  }<a name="line.277"></a>
+<span class="sourceLineNo">278</span><a name="line.278"></a>
+<span class="sourceLineNo">279</span>  @Test<a name="line.279"></a>
+<span class="sourceLineNo">280</span>  public void testRemoveRSGroup() throws Exception {<a name="line.280"></a>
+<span class="sourceLineNo">281</span>    AccessTestAction action = () -&gt; {<a name="line.281"></a>
+<span class="sourceLineNo">282</span>      rsGroupAdminEndpoint.checkPermission("removeRSGroup");<a name="line.282"></a>
+<span class="sourceLineNo">283</span>      return null;<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    };<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.286"></a>
+<span class="sourceLineNo">287</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.287"></a>
+<span class="sourceLineNo">288</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.288"></a>
+<span class="sourceLineNo">289</span>  }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span>  @Test<a name="line.291"></a>
+<span class="sourceLineNo">292</span>  public void testBalanceRSGroup() throws Exception {<a name="line.292"></a>
+<span class="sourceLineNo">293</span>    AccessTestAction action = () -&gt; {<a name="line.293"></a>
+<span class="sourceLineNo">294</span>      rsGroupAdminEndpoint.checkPermission("balanceRSGroup");<a name="line.294"></a>
+<span class="sourceLineNo">295</span>      return null;<a name="line.295"></a>
+<span class="sourceLineNo">296</span>    };<a name="line.296"></a>
+<span class="sourceLineNo">297</span><a name="line.297"></a>
+<span class="sourceLineNo">298</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.298"></a>
+<span class="sourceLineNo">299</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.299"></a>
+<span class="sourceLineNo">300</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.300"></a>
+<span class="sourceLineNo">301</span>  }<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span>  @Test<a name="line.303"></a>
+<span class="sourceLineNo">304</span>  public void testListRSGroup() throws Exception {<a name="line.304"></a>
+<span class="sourceLineNo">305</span>    AccessTestAction action = () -&gt; {<a name="line.305"></a>
+<span class="sourceLineNo">306</span>      rsGroupAdminEndpoint.checkPermission("listRSGroup");<a name="line.306"></a>
+<span class="sourceLineNo">307</span>      return null;<a name="line.307"></a>
+<span class="sourceLineNo">308</span>    };<a name="line.308"></a>
+<span class="sourceLineNo">309</span><a name="line.309"></a>
+<span class="sourceLineNo">310</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.310"></a>
+<span class="sourceLineNo">311</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.311"></a>
+<span class="sourceLineNo">312</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.312"></a>
+<span class="sourceLineNo">313</span>  }<a name="line.313"></a>
+<span class="sourceLineNo">314</span><a name="line.314"></a>
+<span class="sourceLineNo">315</span>  @Test<a name="line.315"></a>
+<span class="sourceLineNo">316</span>  public void testGetRSGroupInfoOfServer() throws Exception {<a name="line.316"></a>
+<span class="sourceLineNo">317</span>    AccessTestAction action = () -&gt; {<a name="line.317"></a>
+<span class="sourceLineNo">318</span>      rsGroupAdminEndpoint.checkPermission("getRSGroupInfoOfServer");<a name="line.318"></a>
+<span class="sourceLineNo">319</span>      return null;<a name="line.319"></a>
+<span class="sourceLineNo">320</span>    };<a name="line.320"></a>
+<span class="sourceLineNo">321</span><a name="line.321"></a>
+<span class="sourceLineNo">322</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.322"></a>
+<span class="sourceLineNo">323</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.323"></a>
+<span class="sourceLineNo">324</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.324"></a>
+<span class="sourceLineNo">325</span>  }<a name="line.325"></a>
+<span class="sourceLineNo">326</span><a name="line.326"></a>
+<span class="sourceLineNo">327</span>  @Test<a name="line.327"></a>
+<span class="sourceLineNo">328</span>  public void testMoveServersAndTables() throws Exception {<a name="line.328"></a>
+<span class="sourceLineNo">329</span>    AccessTestAction action = () -&gt; {<a name="line.329"></a>
+<span class="sourceLineNo">330</span>      rsGroupAdminEndpoint.checkPermission("moveServersAndTables");<a name="line.330"></a>
+<span class="sourceLineNo">331</span>      return null;<a name="line.331"></a>
+<span class="sourceLineNo">332</span>    };<a name="line.332"></a>
+<span class="sourceLineNo">333</span><a name="line.333"></a>
+<span class="sourceLineNo">334</span>    verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_GROUP_ADMIN);<a name="line.334"></a>
+<span class="sourceLineNo">335</span>    verifyDenied(action, USER_CREATE, USER_OWNER, USER_RW, USER_RO,<a name="line.335"></a>
+<span class="sourceLineNo">336</span>        USER_NONE, USER_GROUP_READ, USER_GROUP_WRITE, USER_GROUP_CREATE);<a name="line.336"></a>
+<span class="sourceLineNo">337</span>  }<a name="line.337"></a>
+<span class="sourceLineNo">338</span>}<a name="line.338"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6bdadd97/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestDrainBarrier.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestDrainBarrier.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestDrainBarrier.html
deleted file mode 100644
index 9d0dc47..0000000
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/util/TestDrainBarrier.html
+++ /dev/null
@@ -1,199 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
-<html lang="en">
-<head>
-<title>Source code</title>
-<link rel="stylesheet" type="text/css" href="../../../../../../stylesheet.css" title="Style">
-</head>
-<body>
-<div class="sourceContainer">
-<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
-<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
-<span class="sourceLineNo">003</span> * or more contributor license agreements.  See the NOTICE file<a name="line.3"></a>
-<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
-<span class="sourceLineNo">005</span> * regarding copyright ownership.  The ASF licenses this file<a name="line.5"></a>
-<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
-<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
-<span class="sourceLineNo">008</span> * with the License.  You may obtain a copy of the License at<a name="line.8"></a>
-<span class="sourceLineNo">009</span> *<a name="line.9"></a>
-<span class="sourceLineNo">010</span> *     http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
-<span class="sourceLineNo">011</span> *<a name="line.11"></a>
-<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
-<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
-<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
-<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
-<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
-<span class="sourceLineNo">017</span> */<a name="line.17"></a>
-<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.util;<a name="line.18"></a>
-<span class="sourceLineNo">019</span><a name="line.19"></a>
-<span class="sourceLineNo">020</span>import static org.junit.Assert.assertFalse;<a name="line.20"></a>
-<span class="sourceLineNo">021</span>import static org.junit.Assert.assertTrue;<a name="line.21"></a>
-<span class="sourceLineNo">022</span>import static org.junit.Assert.fail;<a name="line.22"></a>
-<span class="sourceLineNo">023</span><a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.testclassification.MiscTests;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.junit.ClassRule;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.junit.Test;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.junit.experimental.categories.Category;<a name="line.29"></a>
-<span class="sourceLineNo">030</span><a name="line.30"></a>
-<span class="sourceLineNo">031</span>@Category({MiscTests.class, SmallTests.class})<a name="line.31"></a>
-<span class="sourceLineNo">032</span>public class TestDrainBarrier {<a name="line.32"></a>
-<span class="sourceLineNo">033</span><a name="line.33"></a>
-<span class="sourceLineNo">034</span>  @ClassRule<a name="line.34"></a>
-<span class="sourceLineNo">035</span>  public static final HBaseClassTestRule CLASS_RULE =<a name="line.35"></a>
-<span class="sourceLineNo">036</span>      HBaseClassTestRule.forClass(TestDrainBarrier.class);<a name="line.36"></a>
-<span class="sourceLineNo">037</span><a name="line.37"></a>
-<span class="sourceLineNo">038</span>  @Test<a name="line.38"></a>
-<span class="sourceLineNo">039</span>  public void testBeginEndStopWork() throws Exception {<a name="line.39"></a>
-<span class="sourceLineNo">040</span>    DrainBarrier barrier = new DrainBarrier();<a name="line.40"></a>
-<span class="sourceLineNo">041</span>    assertTrue(barrier.beginOp());<a name="line.41"></a>
-<span class="sourceLineNo">042</span>    assertTrue(barrier.beginOp());<a name="line.42"></a>
-<span class="sourceLineNo">043</span>    barrier.endOp();<a name="line.43"></a>
-<span class="sourceLineNo">044</span>    barrier.endOp();<a name="line.44"></a>
-<span class="sourceLineNo">045</span>    barrier.stopAndDrainOps();<a name="line.45"></a>
-<span class="sourceLineNo">046</span>    assertFalse(barrier.beginOp());<a name="line.46"></a>
-<span class="sourceLineNo">047</span>  }<a name="line.47"></a>
-<span class="sourceLineNo">048</span><a name="line.48"></a>
-<span class="sourceLineNo">049</span>  @Test<a name="line.49"></a>
-<span class="sourceLineNo">050</span>  public void testUnmatchedEndAssert() throws Exception {<a name="line.50"></a>
-<span class="sourceLineNo">051</span>    DrainBarrier barrier = new DrainBarrier();<a name="line.51"></a>
-<span class="sourceLineNo">052</span>    try {<a name="line.52"></a>
-<span class="sourceLineNo">053</span>      barrier.endOp();<a name="line.53"></a>
-<span class="sourceLineNo">054</span>      throw new Error("Should have asserted");<a name="line.54"></a>
-<span class="sourceLineNo">055</span>    } catch (AssertionError e) {<a name="line.55"></a>
-<span class="sourceLineNo">056</span>    }<a name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>    barrier.beginOp();<a name="line.58"></a>
-<span class="sourceLineNo">059</span>    barrier.beginOp();<a name="line.59"></a>
-<span class="sourceLineNo">060</span>    barrier.endOp();<a name="line.60"></a>
-<span class="sourceLineNo">061</span>    barrier.endOp();<a name="line.61"></a>
-<span class="sourceLineNo">062</span>    try {<a name="line.62"></a>
-<span class="sourceLineNo">063</span>      barrier.endOp();<a name="line.63"></a>
-<span class="sourceLineNo">064</span>      throw new Error("Should have asserted");<a name="line.64"></a>
-<span class="sourceLineNo">065</span>    } catch (AssertionError e) {<a name="line.65"></a>
-<span class="sourceLineNo">066</span>    }<a name="line.66"></a>
-<span class="sourceLineNo">067</span>  }<a name="line.67"></a>
-<span class="sourceLineNo">068</span><a name="line.68"></a>
-<span class="sourceLineNo">069</span>  @Test<a name="line.69"></a>
-<span class="sourceLineNo">070</span>  public void testStopWithoutOpsDoesntBlock() throws Exception {<a name="line.70"></a>
-<span class="sourceLineNo">071</span>    DrainBarrier barrier = new DrainBarrier();<a name="line.71"></a>
-<span class="sourceLineNo">072</span>    barrier.stopAndDrainOpsOnce();<a name="line.72"></a>
-<span class="sourceLineNo">073</span><a name="line.73"></a>
-<span class="sourceLineNo">074</span>    barrier = new DrainBarrier();<a name="line.74"></a>
-<span class="sourceLineNo">075</span>    barrier.beginOp();<a name="line.75"></a>
-<span class="sourceLineNo">076</span>    barrier.endOp();<a name="line.76"></a>
-<span class="sourceLineNo">077</span>    barrier.stopAndDrainOpsOnce();<a name="line.77"></a>
-<span class="sourceLineNo">078</span>  }<a name="line.78"></a>
-<span class="sourceLineNo">079</span><a name="line.79"></a>
-<span class="sourceLineNo">080</span>  @Test<a name="line.80"></a>
-<span class="sourceLineNo">081</span>  /** This test tests blocking and can have false positives in very bad timing cases. */<a name="line.81"></a>
-<span class="sourceLineNo">082</span>  public void testStopIsBlockedByOps() throws Exception {<a name="line.82"></a>
-<span class="sourceLineNo">083</span>    final DrainBarrier barrier = new DrainBarrier();<a name="line.83"></a>
-<span class="sourceLineNo">084</span>    barrier.beginOp();<a name="line.84"></a>
-<span class="sourceLineNo">085</span>    barrier.beginOp();<a name="line.85"></a>
-<span class="sourceLineNo">086</span>    barrier.beginOp();<a name="line.86"></a>
-<span class="sourceLineNo">087</span>    barrier.endOp();<a name="line.87"></a>
-<span class="sourceLineNo">088</span><a name="line.88"></a>
-<span class="sourceLineNo">089</span>    Thread stoppingThread = new Thread(new Runnable() {<a name="line.89"></a>
-<span class="sourceLineNo">090</span>      @Override<a name="line.90"></a>
-<span class="sourceLineNo">091</span>      public void run() {<a name="line.91"></a>
-<span class="sourceLineNo">092</span>        try {<a name="line.92"></a>
-<span class="sourceLineNo">093</span>          barrier.stopAndDrainOpsOnce();<a name="line.93"></a>
-<span class="sourceLineNo">094</span>        } catch (InterruptedException e) {<a name="line.94"></a>
-<span class="sourceLineNo">095</span>          fail("Should not have happened");<a name="line.95"></a>
-<span class="sourceLineNo">096</span>        }<a name="line.96"></a>
-<span class="sourceLineNo">097</span>      }<a name="line.97"></a>
-<span class="sourceLineNo">098</span>    });<a name="line.98"></a>
-<span class="sourceLineNo">099</span>    stoppingThread.start();<a name="line.99"></a>
-<span class="sourceLineNo">100</span><a name="line.100"></a>
-<span class="sourceLineNo">101</span>    // First "end" should not unblock the thread, but the second should.<a name="line.101"></a>
-<span class="sourceLineNo">102</span>    barrier.endOp();<a name="line.102"></a>
-<span class="sourceLineNo">103</span>    stoppingThread.join(1000);<a name="line.103"></a>
-<span class="sourceLineNo">104</span>    assertTrue(stoppingThread.isAlive());<a name="line.104"></a>
-<span class="sourceLineNo">105</span>    barrier.endOp();<a name="line.105"></a>
-<span class="sourceLineNo">106</span>    stoppingThread.join(30000); // When not broken, will be a very fast wait; set safe value.<a name="line.106"></a>
-<span class="sourceLineNo">107</span>    assertFalse(stoppingThread.isAlive());<a name="line.107"></a>
-<span class="sourceLineNo">108</span>  }<a name="line.108"></a>
-<span class="sourceLineNo">109</span><a name="line.109"></a>
-<span class="sourceLineNo">110</span>  @Test<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  public void testMultipleStopOnceAssert() throws Exception {<a name="line.111"></a>
-<span class="sourceLineNo">112</span>    DrainBarrier barrier = new DrainBarrier();<a name="line.112"></a>
-<span class="sourceLineNo">113</span>    barrier.stopAndDrainOpsOnce();<a name="line.113"></a>
-<span class="sourceLineNo">114</span>    try {<a name="line.114"></a>
-<span class="sourceLineNo">115</span>      barrier.stopAndDrainOpsOnce();<a name="line.115"></a>
-<span class="sourceLineNo">116</span>      throw new Error("Should have asserted");<a name="line.116"></a>
-<span class="sourceLineNo">117</span>    } catch (AssertionError e) {<a name="line.117"></a>
-<span class="sourceLineNo">118</span>    }<a name="line.118"></a>
-<span class="sourceLineNo">119</span>  }<a name="line.119"></a>
-<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span>  @Test<a name="line.121"></a>
-<span class="sourceLineNo">122</span>  public void testMultipleSloppyStopsHaveNoEffect() throws Exception {<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    DrainBarrier barrier = new DrainBarrier();<a name="line.123"></a>
-<span class="sourceLineNo">124</span>    barrier.stopAndDrainOps();<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    barrier.stopAndDrainOps();<a name="line.125"></a>
-<span class="sourceLineNo">126</span>  }<a name="line.126"></a>
-<span class="sourceLineNo">127</span>}<a name="line.127"></a>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-</pre>
-</div>
-</body>
-</html>


Mime
View raw message